refactor(linter): remove custom react perf lint rule trait#24082
Merged
graphite-app[bot] merged 1 commit intoJul 2, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
Merge activity
|
The rule trait here is convenient, but is inconsistent with the style and architecture of other linter rules. Removing this trait allows the linter codegen to understand this rule better, which enables performance optimizations not currently allowed with this style. It also makes these lint rules less "clean" but more consistent with every other lint rule that we have, which makes this easier to maintain in the long term.
graphite-app
Bot
force-pushed
the
07-02-refactor_linter_remove_custom_react_perf_lint_rule_trait
branch
from
July 2, 2026 17:19
bc94678 to
49d5a76
Compare
camc314
reviewed
Jul 2, 2026
graphite-app
Bot
deleted the
07-02-refactor_linter_remove_custom_react_perf_lint_rule_trait
branch
July 2, 2026 17:38
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
The rule trait here is convenient, but is inconsistent with the style and architecture of other linter rules. Removing this trait allows the linter codegen to understand this rule better, which enables performance optimizations not currently allowed with this style. It also makes these lint rules less "clean" but more consistent with every other lint rule that we have, which makes this easier to maintain in the long term.
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
The rule trait here is convenient, but is inconsistent with the style and architecture of other linter rules. Removing this trait allows the linter codegen to understand this rule better, which enables performance optimizations not currently allowed with this style. It also makes these lint rules less "clean" but more consistent with every other lint rule that we have, which makes this easier to maintain in the long term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule trait here is convenient, but is inconsistent with the style and architecture of other linter rules. Removing this trait allows the linter codegen to understand this rule better, which enables performance optimizations not currently allowed with this style. It also makes these lint rules less "clean" but more consistent with every other lint rule that we have, which makes this easier to maintain in the long term.