Skip to content

perf(transformer/nullish_coalescing): move cold path into separate function#23989

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-27-perf_transformer_nullish_coalescing_move_cold_path_into_separate_function
Jul 2, 2026
Merged

perf(transformer/nullish_coalescing): move cold path into separate function#23989
graphite-app[bot] merged 1 commit into
mainfrom
om/06-27-perf_transformer_nullish_coalescing_move_cold_path_into_separate_function

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 30, 2026

Copy link
Copy Markdown
Member

Small optimization to nullish coalescing transform.

Move the logic for transforming ?? into a separate #[cold] function. The vast majority of Expressions are not ?? LogicalExpressions. This allows us to inline enter_expression, which becomes just a cheap "Is it ??. No. Exit." check on the common path.

overlookmotel commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-transformer Area - Transformer / Transpiler label Jun 30, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1


Comparing om/06-27-perf_transformer_nullish_coalescing_move_cold_path_into_separate_function (2cc4353) with om/06-27-perf_transformer_object_rest_spread_pre-allocate_capacity_in_vec_ (4fc5c54)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel
overlookmotel marked this pull request as ready for review July 1, 2026 08:40
@overlookmotel
overlookmotel requested a review from Dunqing as a code owner July 1, 2026 08:40
Copilot AI review requested due to automatic review settings July 1, 2026 08:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the ES2020 nullish coalescing (??) transformer by moving the uncommon transformation work out of the hot traversal path, so enter_expression can stay small and inline well during AST traversal.

Changes:

  • Marks enter_expression as #[inline] and makes it a cheap “is this ???” check.
  • Moves the ?? transformation logic into a separate #[cold] helper to keep the common path lightweight.

Comment thread crates/oxc_transformer/src/es2020/nullish_coalescing_operator.rs
@graphite-app

graphite-app Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Merge activity

…nction (#23989)

Small optimization to nullish coalescing transform.

Move the logic for transforming `??` into a separate `#[cold]` function. The vast majority of `Expression`s are not `??` `LogicalExpression`s. This allows us to inline `enter_expression`, which becomes just a cheap "Is it `??`. No. Exit." check on the common path.
@graphite-app
graphite-app Bot force-pushed the om/06-27-perf_transformer_object_rest_spread_pre-allocate_capacity_in_vec_ branch from 4fc5c54 to c4e35b5 Compare July 2, 2026 01:32
@graphite-app
graphite-app Bot force-pushed the om/06-27-perf_transformer_nullish_coalescing_move_cold_path_into_separate_function branch from 2cc4353 to e6d48e1 Compare July 2, 2026 01:32
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 2, 2026
Base automatically changed from om/06-27-perf_transformer_object_rest_spread_pre-allocate_capacity_in_vec_ to main July 2, 2026 01:36
@graphite-app
graphite-app Bot merged commit e6d48e1 into main Jul 2, 2026
31 checks passed
@graphite-app
graphite-app Bot deleted the om/06-27-perf_transformer_nullish_coalescing_move_cold_path_into_separate_function branch July 2, 2026 01:37
camc314 pushed a commit that referenced this pull request Jul 3, 2026
…nction (#23989)

Small optimization to nullish coalescing transform.

Move the logic for transforming `??` into a separate `#[cold]` function. The vast majority of `Expression`s are not `??` `LogicalExpression`s. This allows us to inline `enter_expression`, which becomes just a cheap "Is it `??`. No. Exit." check on the common path.
Boshen added a commit that referenced this pull request Jul 6, 2026
### 🚀 Features

- 260425f semantic/examples: Include unresolved references (#24214)
(camc314)
- 2d9b0b3 minifier: Fold boolean-literal ternary branches in value
contexts (#24110) (Dunqing)
- 61fbf10 ast: Implement `ReplaceWith` on all AST types (#24013)
(overlookmotel)
- 7db7a29 allocator: Add `ReplaceWith` trait (#24012) (overlookmotel)
- 4eb074e mangler: Add `reserved` option for names that must not be
mangled (#24041) (Dunqing)
- 2e62012 data_structures: Add `StringExt` trait (#24006)
(overlookmotel)
- 60e7160 minifier: Drop side-effect-free IIFEs whose result is unused
(#23967) (Dunqing)
- 26dd9e2 ast: Add method to widen inherited enum ref to parent ref
(#23961) (overlookmotel)

### 🐛 Bug Fixes

- e8b50ee transformer: Clean up semantics for stripped TypeScript syntax
(#24180) (camc314)
- d966d0b react_compiler: Remove clippy allows (#24168) (Boshen)
- 854ef8d react_compiler: Compile generic functions instead of
over-bailing on type-param hoisting (#24158) (Boshen)
- 093586c react_compiler: Align memoization cache-slot allocation with
Babel (#24157) (Boshen)
- 09c8f59 react_compiler: Normalize snapshot fixture paths (#24142)
(camc314)
- f13df97 react_compiler: Drop stray empty statement from catch bindings
(#24133) (Boshen)
- cb2a505 react_compiler: Codegen destructuring reassignment targets
(#24131) (Boshen)
- b82c394 react_compiler: Propagate codegen invariants instead of
emitting empty bodies (#24128) (Boshen)
- 5771982 react_compiler: Render unchanged programs as source in fixture
snapshots (#24129) (Boshen)
- 4b16e1a transformer/async-to-generator: Preserve direct eval scope
flags (#24136) (camc314)
- 4e9194f react_compiler: Lower `delete obj.prop` to
Property/ComputedDelete (#24123) (Boshen)
- 0b25582 ast: Type binding node `typeAnnotation` as `TSTypeAnnotation |
null` (#23113) (Boshen)
- 018c0e5 transformer: Hoist lowered async declarations (#22770)
(camc314)
- 652fbaf mangler: Keep names of destructured exported bindings (#24036)
(Dunqing)
- e274415 minifier: Don't drop global calls that throw despite pure
arguments (#23917) (Dunqing)
- 59abb30 minifier: Only merge string literals in `try_fold_add` when
the inner operator is `+` (#23622) (Jerry Zhao)

### ⚡ Performance

- c5ca77b transformer: Avoid cloning refresh options (#24191) (camc314)
- bf1a151 react_compiler: Compile out debug printers (#24184) (Boshen)
- abb44a0 transformer: Build fixed object-rest arguments (#24190)
(camc314)
- a4db731 isolated_declarations: Use `ReplaceWith` instead of `TakeIn`
(#24016) (overlookmotel)
- ff10855 transformer: Use `ReplaceWith` instead of `TakeIn` (#24015)
(overlookmotel)
- bd49aff ecmascript: Avoid heap-allocating Math.min/max/imul operands
(#23941) (Lawrence Lin)
- e4b708b react_compiler: Skip compiled files before prefilters (#24171)
(Boshen)
- c59f2fe rust: Return impl ExactSizeIterator from slice-backed
accessors (#24144) (Boshen)
- 5d6d04a codegen: SWAR-skip boring byte runs in sourcemap line/column
scan (#24023) (Boshen)
- a55e0be traverse: Reduce string operations in `get_var_name_from_node`
(#24007) (overlookmotel)
- e6d48e1 transformer/nullish_coalescing: Move cold path into separate
function (#23989) (overlookmotel)
- c4e35b5 transformer/object_rest_spread: Pre-allocate capacity in `Vec`
(#23988) (overlookmotel)
- 527b8e5 transformer/decorators: Narrow type earlier (#23987)
(overlookmotel)

### 📚 Documentation

- 30d17f5 allocator: Clarify docs for `TakeIn::take_in_box` (#24093)
(overlookmotel)
- 675e6a8 ast: Correct doc comment for `PrivateFieldExpression` (#24008)
(overlookmotel)
- e4c30e6 minifier: Explain what `dce` mode means (#23994) (Dunqing)
- 37cbf88 ast_macros: Document fields of `StructDetails` (#23959)
(overlookmotel)
- 4de3e54 ast: Correct doc comment (#23948) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants