refactor(ast): enum conversion methods use NonNull#23962
Merged
graphite-app[bot] merged 1 commit intoJun 30, 2026
Merged
Conversation
This was referenced Jun 30, 2026
Member
Author
This was referenced Jun 30, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
overlookmotel
force-pushed
the
om/06-29-feat_ast_add_method_to_widen_inherited_enum_ref_to_parent_ref
branch
from
June 30, 2026 00:34
e8aff21 to
58c3c49
Compare
overlookmotel
force-pushed
the
om/06-30-refactor_ast_enum_conversion_methods_use_nonnull_
branch
from
June 30, 2026 00:34
f4886c3 to
9eb73e7
Compare
overlookmotel
marked this pull request as ready for review
June 30, 2026 10:12
overlookmotel
force-pushed
the
om/06-29-feat_ast_add_method_to_widen_inherited_enum_ref_to_parent_ref
branch
from
June 30, 2026 10:12
58c3c49 to
f04cece
Compare
overlookmotel
force-pushed
the
om/06-30-refactor_ast_enum_conversion_methods_use_nonnull_
branch
from
June 30, 2026 10:12
9eb73e7 to
a6718bb
Compare
Member
Author
|
@claude review |
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/06-29-feat_ast_add_method_to_widen_inherited_enum_ref_to_parent_ref
branch
from
June 30, 2026 13:12
f04cece to
4d22941
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
Refactor. Enum conversion methods (`Expression::as_member_expression` etc) use `NonNull` pointers for casting from one type to another, instead of _const /_ `*mut` pointers. This is more readable, and may also be slightly more performant - it may allow compiler to remove null pointer checks.
graphite-app
Bot
force-pushed
the
om/06-30-refactor_ast_enum_conversion_methods_use_nonnull_
branch
from
June 30, 2026 13:12
a6718bb to
a33a71d
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
overlookmotel
force-pushed
the
om/06-29-feat_ast_add_method_to_widen_inherited_enum_ref_to_parent_ref
branch
from
June 30, 2026 14:47
4d22941 to
a3019cb
Compare
overlookmotel
added a commit
that referenced
this pull request
Jun 30, 2026
Refactor. Enum conversion methods (`Expression::as_member_expression` etc) use `NonNull` pointers for casting from one type to another, instead of _const /_ `*mut` pointers. This is more readable, and may also be slightly more performant - it may allow compiler to remove null pointer checks.
overlookmotel
force-pushed
the
om/06-30-refactor_ast_enum_conversion_methods_use_nonnull_
branch
from
June 30, 2026 14:47
a33a71d to
5a93062
Compare
Refactor. Enum conversion methods (`Expression::as_member_expression` etc) use `NonNull` pointers for casting from one type to another, instead of _const /_ `*mut` pointers. This is more readable, and may also be slightly more performant - it may allow compiler to remove null pointer checks.
graphite-app
Bot
force-pushed
the
om/06-29-feat_ast_add_method_to_widen_inherited_enum_ref_to_parent_ref
branch
from
June 30, 2026 16:33
a3019cb to
26dd9e2
Compare
graphite-app
Bot
force-pushed
the
om/06-30-refactor_ast_enum_conversion_methods_use_nonnull_
branch
from
June 30, 2026 16:34
5a93062 to
a8f8e9c
Compare
Base automatically changed from
om/06-29-feat_ast_add_method_to_widen_inherited_enum_ref_to_parent_ref
to
main
June 30, 2026 16:44
graphite-app
Bot
deleted the
om/06-30-refactor_ast_enum_conversion_methods_use_nonnull_
branch
June 30, 2026 16:45
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
Refactor. Enum conversion methods (`Expression::as_member_expression` etc) use `NonNull` pointers for casting from one type to another, instead of _const /_ `*mut` pointers. This is more readable, and may also be slightly more performant - it may allow compiler to remove null pointer checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor. Enum conversion methods (
Expression::as_member_expressionetc) useNonNullpointers for casting from one type to another, instead of const /*mutpointers.This is more readable, and may also be slightly more performant - it may allow compiler to remove null pointer checks.