refactor(ast_tools): move phf::Map generation into a utility function#23956
Merged
graphite-app[bot] merged 1 commit intoJun 30, 2026
Conversation
This was referenced Jun 30, 2026
Member
Author
This was referenced Jun 30, 2026
overlookmotel
marked this pull request as ready for review
June 30, 2026 10:10
overlookmotel
force-pushed
the
om/06-29-refactor_ast_codegen_match__macros
branch
from
June 30, 2026 10:12
bd2689c to
b681ad7
Compare
overlookmotel
force-pushed
the
om/06-29-refactor_ast_tools_move_phf_map_generation_into_a_utility_function
branch
from
June 30, 2026 10:12
f8f702a to
796ff09
Compare
Member
Author
|
@claude review |
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/06-29-refactor_ast_codegen_match__macros
branch
from
June 30, 2026 13:08
b681ad7 to
ff74a20
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…on (#23956) Pure refactor. Move logic for codegenning a `phf::Map` into a utility function that takes an iterator of `(name, content)` entries.
graphite-app
Bot
force-pushed
the
om/06-29-refactor_ast_tools_move_phf_map_generation_into_a_utility_function
branch
from
June 30, 2026 13:09
796ff09 to
3a843c0
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…on (#23956) Pure refactor. Move logic for codegenning a `phf::Map` into a utility function that takes an iterator of `(name, content)` entries.
overlookmotel
changed the base branch from
om/06-29-refactor_ast_codegen_match__macros
to
graphite-base/23956
June 30, 2026 14:46
overlookmotel
force-pushed
the
graphite-base/23956
branch
from
June 30, 2026 14:47
ff74a20 to
084eb3b
Compare
overlookmotel
force-pushed
the
om/06-29-refactor_ast_tools_move_phf_map_generation_into_a_utility_function
branch
from
June 30, 2026 14:47
3a843c0 to
287a0c3
Compare
overlookmotel
changed the base branch from
graphite-base/23956
to
om/06-29-refactor_ast_codegen_match__macros
June 30, 2026 14:47
Base automatically changed from
om/06-29-refactor_ast_codegen_match__macros
to
main
June 30, 2026 16:29
graphite-app
Bot
deleted the
om/06-29-refactor_ast_tools_move_phf_map_generation_into_a_utility_function
branch
June 30, 2026 16:30
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
…on (#23956) Pure refactor. Move logic for codegenning a `phf::Map` into a utility function that takes an iterator of `(name, content)` entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
Move logic for codegenning a
phf::Mapinto a utility function that takes an iterator of(name, content)entries.