refactor(ast): codegen match_*! macros#23955
Merged
graphite-app[bot] merged 1 commit intoJun 30, 2026
Merged
Conversation
This was referenced Jun 30, 2026
Member
Author
This was referenced Jun 30, 2026
This was referenced Jun 30, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
overlookmotel
force-pushed
the
om/06-29-refactor_ast_codegen_match__macros
branch
from
June 30, 2026 10:12
bd2689c to
b681ad7
Compare
overlookmotel
marked this pull request as ready for review
June 30, 2026 10:13
Member
Author
|
@claude review |
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/06-29-feat_ast_tools_store_reverse-mapping_of_enum_inheritance_in_schema
branch
from
June 30, 2026 13:08
4bb5baa to
6279a61
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
Pure refactor. `oxc_ast` contained 9 hand-written macros e.g. `match_expression!`. Codegen these macros instead. The macros are exactly the same as they were before, just they're now codegenned, so will reflect any changes made to AST automatically.
graphite-app
Bot
force-pushed
the
om/06-29-refactor_ast_codegen_match__macros
branch
from
June 30, 2026 13:08
b681ad7 to
ff74a20
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pure refactor. `oxc_ast` contained 9 hand-written macros e.g. `match_expression!`. Codegen these macros instead. The macros are exactly the same as they were before, just they're now codegenned, so will reflect any changes made to AST automatically.
overlookmotel
force-pushed
the
om/06-29-feat_ast_tools_store_reverse-mapping_of_enum_inheritance_in_schema
branch
from
June 30, 2026 14:46
6279a61 to
ecf2392
Compare
overlookmotel
force-pushed
the
om/06-29-refactor_ast_codegen_match__macros
branch
from
June 30, 2026 14:46
ff74a20 to
084eb3b
Compare
Base automatically changed from
om/06-29-feat_ast_tools_store_reverse-mapping_of_enum_inheritance_in_schema
to
main
June 30, 2026 16:28
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
Pure refactor. `oxc_ast` contained 9 hand-written macros e.g. `match_expression!`. Codegen these macros instead. The macros are exactly the same as they were before, just they're now codegenned, so will reflect any changes made to AST automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
oxc_astcontained 9 hand-written macros e.g.match_expression!. Codegen these macros instead.The macros are exactly the same as they were before, just they're now codegenned, so will reflect any changes made to AST automatically.