refactor(ast): declare enum inheritance with `INHERIT` by overlookmotel · Pull Request #23953 · oxc-project/oxc

overlookmotel · 2026-06-30T00:00:03Z

Change the syntax used to declare that one enum inherits the variants from another.

Before:

enum Expression<'a> {
    // ... own variants ...
    @inherit MemberExpression
}

After:

enum Expression<'a> {
    // ... own variants ...
    INHERIT(MemberExpression<'a>),
}

Reason for this change is that the latter is valid Rust code, and can be parsed normally by Rust compiler and syn.

This removes the need for custom parsing logic in ast_tools - now we can just use syn's standard parser for enums.

The downside it that this complicates the inherit_variants! macro - this PR reimplements it as a TT-muncher. But this macro is removed entirely in a later PR (#23960).

No change to behavior - only affects how inheritance is declared, not how it works.

overlookmotel · 2026-06-30T00:00:24Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-06-30T00:08:47Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks¹

_{Comparing om/06-30-refactor_ast_declare_enum_inheritance_with_inherit_ (35c71e3) with om/06-28-refactor_ast_remove_shared_enum_variants_macro (7af6a70)²}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on om/06-28-refactor_ast_remove_shared_enum_variants_macro (e6d6e5a) during the generation of this report, so feccfd7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

overlookmotel · 2026-06-30T10:28:50Z

@claude review

graphite-app · 2026-06-30T13:04:13Z

Merge activity

Jun 30, 1:04 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jun 30, 1:14 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #23948.
Jun 30, 1:14 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #23948.
Jun 30, 4:19 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jun 30, 4:26 PM UTC: Merged by the Graphite merge queue.

@inherit

Change the syntax used to declare that one enum inherits the variants from another. Before: ```rust enum Expression<'a> { // ... own variants ... @inherit MemberExpression } ``` After: ```rust enum Expression<'a> { // ... own variants ... INHERIT(MemberExpression<'a>), } ``` Reason for this change is that the latter is valid Rust code, and can be parsed normally by Rust compiler and `syn`. This removes the need for custom parsing logic in `ast_tools` - now we can just use `syn`'s standard parser for enums. The downside it that this complicates the `inherit_variants!` macro - this PR reimplements it as a TT-muncher. But this macro is removed entirely in a later PR (#23960). No change to behavior - only affects _how_ inheritance is declared, not how it works.

camc314 · 2026-06-30T14:08:47Z

@codex review

chatgpt-codex-connector · 2026-06-30T14:14:00Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 2616fc69d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@inherit

Change the syntax used to declare that one enum inherits the variants from another. Before: ```rust enum Expression<'a> { // ... own variants ... @inherit MemberExpression } ``` After: ```rust enum Expression<'a> { // ... own variants ... INHERIT(MemberExpression<'a>), } ``` Reason for this change is that the latter is valid Rust code, and can be parsed normally by Rust compiler and `syn`. This removes the need for custom parsing logic in `ast_tools` - now we can just use `syn`'s standard parser for enums. The downside it that this complicates the `inherit_variants!` macro - this PR reimplements it as a TT-muncher. But this macro is removed entirely in a later PR (#23960). No change to behavior - only affects _how_ inheritance is declared, not how it works.

@inherit

Change the syntax used to declare that one enum inherits the variants from another. Before: ```rust enum Expression<'a> { // ... own variants ... @inherit MemberExpression } ``` After: ```rust enum Expression<'a> { // ... own variants ... INHERIT(MemberExpression<'a>), } ``` Reason for this change is that the latter is valid Rust code, and can be parsed normally by Rust compiler and `syn`. This removes the need for custom parsing logic in `ast_tools` - now we can just use `syn`'s standard parser for enums. The downside it that this complicates the `inherit_variants!` macro - this PR reimplements it as a TT-muncher. But this macro is removed entirely in a later PR (#23960). No change to behavior - only affects _how_ inheritance is declared, not how it works.

This was referenced Jun 30, 2026

feat(ast_tools): store reverse-mapping of enum inheritance in schema #23954

Merged

refactor(ast): codegen match_*! macros #23955

Merged

github-actions Bot added A-ast Area - AST A-ast-tools Area - AST tools labels Jun 30, 2026

overlookmotel self-assigned this Jun 30, 2026

overlookmotel marked this pull request as ready for review June 30, 2026 09:19

Copilot AI review requested due to automatic review settings June 30, 2026 09:19

Copilot AI reviewed Jun 30, 2026

graphite-app Bot force-pushed the om/06-28-refactor_ast_remove_shared_enum_variants_macro branch from 4d05d3e to 7af6a70 Compare June 30, 2026 13:07

graphite-app Bot force-pushed the om/06-30-refactor_ast_declare_enum_inheritance_with_inherit_ branch from 107bd64 to 2616fc6 Compare June 30, 2026 13:07

overlookmotel force-pushed the om/06-28-refactor_ast_remove_shared_enum_variants_macro branch from 7af6a70 to e6d6e5a Compare June 30, 2026 14:46

overlookmotel force-pushed the om/06-30-refactor_ast_declare_enum_inheritance_with_inherit_ branch from 2616fc6 to 35c71e3 Compare June 30, 2026 14:46

Base automatically changed from om/06-28-refactor_ast_remove_shared_enum_variants_macro to main June 30, 2026 16:25

graphite-app Bot merged commit 35c71e3 into main Jun 30, 2026
74 of 92 checks passed

graphite-app Bot deleted the om/06-30-refactor_ast_declare_enum_inheritance_with_inherit_ branch June 30, 2026 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(ast): declare enum inheritance with `INHERIT`#23953

refactor(ast): declare enum inheritance with `INHERIT`#23953
graphite-app[bot] merged 1 commit into
mainfrom
om/06-30-refactor_ast_declare_enum_inheritance_with_inherit_

overlookmotel commented Jun 30, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Jun 30, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

overlookmotel commented Jun 30, 2026

Uh oh!

graphite-app Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

camc314 commented Jun 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

overlookmotel commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

overlookmotel commented Jun 30, 2026

Uh oh!

graphite-app Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

camc314 commented Jun 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Jun 30, 2026 •

edited

Loading

overlookmotel commented Jun 30, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 30, 2026 •

edited

Loading

graphite-app Bot commented Jun 30, 2026 •

edited

Loading