Skip to content

refactor(ast): remove shared_enum_variants! macro#23952

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-28-refactor_ast_remove_shared_enum_variants_macro
Jun 30, 2026
Merged

refactor(ast): remove shared_enum_variants! macro#23952
graphite-app[bot] merged 1 commit into
mainfrom
om/06-28-refactor_ast_remove_shared_enum_variants_macro

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Remove the shared_enum_variants! macro from oxc_ast crate. Generate the same code using ast_tools codegen instead.

This was referenced Jun 30, 2026
Merged
Merged
Merged
@overlookmotel Graphite App

overlookmotel commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Jun 30, 2026
Merged
@github-actions github-actions Bot added A-ast Area - AST A-ast-tools Area - AST tools labels Jun 30, 2026
This was referenced Jun 30, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-28-refactor_ast_remove_shared_enum_variants_macro (e6d6e5a) with main (003768b)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on om/06-30-refactor_ast_tools_move_article_for_to_utils_module (6e2205f) during the generation of this report, so main (003768b) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel self-assigned this Jun 30, 2026
@overlookmotel
overlookmotel marked this pull request as ready for review June 30, 2026 09:12
Copilot AI review requested due to automatic review settings June 30, 2026 09:12
Copilot AI reviewed Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overlookmotel

overlookmotel commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@claude review

@graphite-app

graphite-app Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app
graphite-app Bot force-pushed the om/06-30-refactor_ast_tools_move_article_for_to_utils_module branch from 6869f96 to 1115701 Compare June 30, 2026 13:06
graphite-app Bot pushed a commit that referenced this pull request Jun 30, 2026
@overlookmotel
refactor(ast): remove shared_enum_variants! macro (#23952)
7af6a70 
Remove the `shared_enum_variants!` macro from `oxc_ast` crate. Generate the same code using `ast_tools` codegen instead.
@graphite-app
graphite-app Bot force-pushed the om/06-28-refactor_ast_remove_shared_enum_variants_macro branch from 4d05d3e to 7af6a70 Compare June 30, 2026 13:07
@camc314

camc314 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 7af6a7020d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@overlookmotel
refactor(ast): remove shared_enum_variants! macro (#23952)
e6d6e5a 
Remove the `shared_enum_variants!` macro from `oxc_ast` crate. Generate the same code using `ast_tools` codegen instead.
@overlookmotel
overlookmotel force-pushed the om/06-28-refactor_ast_remove_shared_enum_variants_macro branch from 7af6a70 to e6d6e5a Compare June 30, 2026 14:46
@overlookmotel
overlookmotel force-pushed the om/06-30-refactor_ast_tools_move_article_for_to_utils_module branch from 1115701 to 6e2205f Compare June 30, 2026 14:46
Base automatically changed from om/06-30-refactor_ast_tools_move_article_for_to_utils_module to main June 30, 2026 16:25
@graphite-app
graphite-app Bot merged commit e6d6e5a into main Jun 30, 2026
51 of 69 checks passed
@graphite-app
graphite-app Bot deleted the om/06-28-refactor_ast_remove_shared_enum_variants_macro branch June 30, 2026 16:25
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
refactor(ast): remove shared_enum_variants! macro (#23952)
9c3beed 
Remove the `shared_enum_variants!` macro from `oxc_ast` crate. Generate the same code using `ast_tools` codegen instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-ast Area - AST A-ast-tools Area - AST tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314