feat(ast_tools): add EnumDef::all_inherits method#23950
Merged
graphite-app[bot] merged 1 commit intoJun 30, 2026
Merged
Conversation
Member
Author
This was referenced Jun 30, 2026
This was referenced Jun 30, 2026
overlookmotel
marked this pull request as ready for review
June 30, 2026 09:10
Member
Author
|
@claude review |
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s
branch
from
June 30, 2026 13:05
bb3a201 to
84f8e5b
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
`EnumDef::inherits_enums` returns an iterator of enums that an enum _directly_ inherits from. Add a method `EnumDef::all_inherits` which yields _all_ inherited enums, including that which are inherited from transitively. e.g.: - `AssignmentTarget` inherits `SimpleAssignmentTarget` and `AssignmentTargetPattern` - `SimpleAssignmentTarget` inherits `MemberExpression`. The 2 methods returns iterators yielding: - `inherits_enums`: `SimpleAssignmentTarget`, `AssignmentTargetPattern` - `all_inherits`: `SimpleAssignmentTarget`, `MemberExpression`, `AssignmentTargetPattern` Use the new `AllInheritsIter` iterator to simplify the `AllVariantsIter` iterator.
graphite-app
Bot
force-pushed
the
om/06-29-feat_ast_tools_add_enumdef_all_inherits_method
branch
from
June 30, 2026 13:05
ef7bdaf to
d917fdb
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 similar comment
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
`EnumDef::inherits_enums` returns an iterator of enums that an enum _directly_ inherits from. Add a method `EnumDef::all_inherits` which yields _all_ inherited enums, including that which are inherited from transitively. e.g.: - `AssignmentTarget` inherits `SimpleAssignmentTarget` and `AssignmentTargetPattern` - `SimpleAssignmentTarget` inherits `MemberExpression`. The 2 methods returns iterators yielding: - `inherits_enums`: `SimpleAssignmentTarget`, `AssignmentTargetPattern` - `all_inherits`: `SimpleAssignmentTarget`, `MemberExpression`, `AssignmentTargetPattern` Use the new `AllInheritsIter` iterator to simplify the `AllVariantsIter` iterator.
overlookmotel
force-pushed
the
om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s
branch
from
June 30, 2026 14:46
84f8e5b to
a10ac8f
Compare
overlookmotel
force-pushed
the
om/06-29-feat_ast_tools_add_enumdef_all_inherits_method
branch
from
June 30, 2026 14:46
d917fdb to
1bb1702
Compare
Base automatically changed from
om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s
to
main
June 30, 2026 16:22
graphite-app
Bot
deleted the
om/06-29-feat_ast_tools_add_enumdef_all_inherits_method
branch
June 30, 2026 16:24
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
`EnumDef::inherits_enums` returns an iterator of enums that an enum _directly_ inherits from. Add a method `EnumDef::all_inherits` which yields _all_ inherited enums, including that which are inherited from transitively. e.g.: - `AssignmentTarget` inherits `SimpleAssignmentTarget` and `AssignmentTargetPattern` - `SimpleAssignmentTarget` inherits `MemberExpression`. The 2 methods returns iterators yielding: - `inherits_enums`: `SimpleAssignmentTarget`, `AssignmentTargetPattern` - `all_inherits`: `SimpleAssignmentTarget`, `MemberExpression`, `AssignmentTargetPattern` Use the new `AllInheritsIter` iterator to simplify the `AllVariantsIter` iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnumDef::inherits_enumsreturns an iterator of enums that an enum directly inherits from.Add a method
EnumDef::all_inheritswhich yields all inherited enums, including that which are inherited from transitively.e.g.:
AssignmentTargetinheritsSimpleAssignmentTargetandAssignmentTargetPatternSimpleAssignmentTargetinheritsMemberExpression.The 2 methods returns iterators yielding:
inherits_enums:SimpleAssignmentTarget,AssignmentTargetPatternall_inherits:SimpleAssignmentTarget,MemberExpression,AssignmentTargetPatternUse the new
AllInheritsIteriterator to simplify theAllVariantsIteriterator.