Skip to content

refactor(ast_tools): EnumDef::inherits_enums return iterator of &EnumDefs#23949

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s
Jun 30, 2026
Merged

refactor(ast_tools): EnumDef::inherits_enums return iterator of &EnumDefs#23949
graphite-app[bot] merged 1 commit into
mainfrom
om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

EnumDef::inherits_enums returns an iterator of enums that an enum inherits variants from. Inheritance only operates on enums, so make it yield &EnumDefs not &TypeDefs.

@overlookmotel Graphite App

overlookmotel commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 30, 2026
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added the A-ast-tools Area - AST tools label Jun 30, 2026
This was referenced Jun 30, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel overlookmotel self-assigned this Jun 30, 2026
@overlookmotel
overlookmotel marked this pull request as ready for review June 30, 2026 09:10
Copilot AI review requested due to automatic review settings June 30, 2026 09:10
Copilot AI reviewed Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overlookmotel

overlookmotel commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@claude review

@graphite-app

graphite-app Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app
graphite-app Bot force-pushed the om/06-29-docs_ast_correct_doc_comment branch from 1a7f1d4 to 232cafb Compare June 30, 2026 13:04
graphite-app Bot pushed a commit that referenced this pull request Jun 30, 2026
@overlookmotel
refactor(ast_tools): EnumDef::inherits_enums return iterator of `&E…
84f8e5b 
…numDef`s (#23949)

`EnumDef::inherits_enums` returns an iterator of enums that an enum inherits variants from. Inheritance only operates on enums, so make it yield `&EnumDef`s not `&TypeDef`s.
@graphite-app
graphite-app Bot force-pushed the om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s branch from bb3a201 to 84f8e5b Compare June 30, 2026 13:05
@camc314

camc314 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 84f8e5bf85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@overlookmotel
refactor(ast_tools): EnumDef::inherits_enums return iterator of `&E…
a10ac8f 
…numDef`s (#23949)

`EnumDef::inherits_enums` returns an iterator of enums that an enum inherits variants from. Inheritance only operates on enums, so make it yield `&EnumDef`s not `&TypeDef`s.
@overlookmotel
overlookmotel force-pushed the om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s branch from 84f8e5b to a10ac8f Compare June 30, 2026 14:46
@overlookmotel
overlookmotel force-pushed the om/06-29-docs_ast_correct_doc_comment branch from 232cafb to 4de3e54 Compare June 30, 2026 14:46
Base automatically changed from om/06-29-docs_ast_correct_doc_comment to main June 30, 2026 16:20
@graphite-app
graphite-app Bot merged commit a10ac8f into main Jun 30, 2026
39 of 55 checks passed
@graphite-app
graphite-app Bot deleted the om/06-29-refactor_ast_tools_enumdef_inherits_enums_return_iterator_of_enumdef_s branch June 30, 2026 16:22
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
refactor(ast_tools): EnumDef::inherits_enums return iterator of `&E…
b611f60 
…numDef`s (#23949)

`EnumDef::inherits_enums` returns an iterator of enums that an enum inherits variants from. Inheritance only operates on enums, so make it yield `&EnumDef`s not `&TypeDef`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-ast-tools Area - AST tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314