test(linter/no-useless-assignment): cover conditional for updates#23792
Merged
graphite-app[bot] merged 1 commit intoJun 25, 2026
Merged
Conversation
graphite-app
Bot
force-pushed
the
fix/semantic-cfg-for-update
branch
from
June 25, 2026 17:26
af06514 to
869ac20
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
Merge activity
|
…3792) fixes #23789 closes #23789 by adding a regression test case. The test verifies that both branches of a conditional `for` update expression are considered used by the next loop iteration: ```ts forward ? index++ : index-- ``` Note, this was fixed via the CFG correction in #23791 - the update branches were disconnected from the loop test and incorrectly reported as useless assignments. Stacked on #23791.
graphite-app
Bot
force-pushed
the
test/no-useless-assignment-conditional-for-update
branch
from
June 25, 2026 17:32
50c574e to
48c0e47
Compare
graphite-app
Bot
deleted the
test/no-useless-assignment-conditional-for-update
branch
June 25, 2026 17:50
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
…3792) fixes #23789 closes #23789 by adding a regression test case. The test verifies that both branches of a conditional `for` update expression are considered used by the next loop iteration: ```ts forward ? index++ : index-- ``` Note, this was fixed via the CFG correction in #23791 - the update branches were disconnected from the loop test and incorrectly reported as useless assignments. Stacked on #23791.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23789
closes #23789 by adding a regression test case.
The test verifies that both branches of a conditional
forupdate expression are considered used by the next loop iteration:Note, this was fixed via the CFG correction in #23791 - the update branches were disconnected from the loop test and incorrectly reported as useless assignments.
Stacked on #23791.