test(lsp): add test for non-blocking requests#23694
Open
Sysix wants to merge 1 commit into
Open
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
06-21-test_lsp_add_test_for_non-blocking_requests
branch
from
June 24, 2026 18:18
5cacee4 to
4780095
Compare
Sysix
force-pushed
the
06-21-test_lsp_add_test_for_non-blocking_requests
branch
from
June 24, 2026 19:07
4780095 to
ee1f6aa
Compare
Sysix
marked this pull request as ready for review
June 24, 2026 19:15
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related oxc-project/oxc-vscode#310 (comment)
When the
oxc_linterdiagnostic run takes longer (because oftsgolint) the code action request, should not be blocked by the diagnostic request.Added a test (which currently fails) to make sure that we never block on this request-combination.
The
codeActionrequests is sent by the editor multiple times and should be quickly resolved. This is currently noticeable with "code actions on save"-path, where the editor is blocked until the diagnostic is responded.