fix(linter): pre-compile jest assert-function patterns and skip invalid ones#23644
Closed
shulaoda wants to merge 1 commit into
Closed
fix(linter): pre-compile jest assert-function patterns and skip invalid ones#23644shulaoda wants to merge 1 commit into
shulaoda wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
shulaoda
marked this pull request as draft
June 19, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matches_assert_function_name(used byjest/prefer-ending-with-an-expect) recompiled every pattern withRegex::new(...)on every node visited — a hot path — and used.unwrap(), so a user-suppliedassertFunctionNamespattern that expands to an invalid regex (e.g."["→(?ui)^[(\.|$)) would panic the linter.Patterns are now compiled once when the rule config is built (mirroring the existing
expect-expectrule), stored in a#[serde(skip)]field, andmatches_assert_function_nametakes the pre-compiled&[Regex]. Invalid patterns are skipped viaRegex::new(...).ok()instead of panicking. This fixes both the per-call recompilation and the panic.Regression tests: a malformed pattern no longer panics and the test block is still reported; a valid pattern alongside a malformed one still matches.