Skip to content

fix(linter/unicorn/prefer-modern-dom-apis): skip fixer for non identifier arguments#23630

Merged
camc314 merged 2 commits into
oxc-project:mainfrom
shulaoda:06-19-fix_prefer_modern_dom_apis_identifier_arguments
Jul 3, 2026
Merged

fix(linter/unicorn/prefer-modern-dom-apis): skip fixer for non identifier arguments#23630
camc314 merged 2 commits into
oxc-project:mainfrom
shulaoda:06-19-fix_prefer_modern_dom_apis_identifier_arguments

Conversation

@shulaoda

@shulaoda shulaoda commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

unicorn/prefer-modern-dom-apis reported (and offered a precedence-breaking suggestion for) replaceChild/insertBefore calls whose arguments are not plain identifiers.

Problem

The argument guard was arguments.all(|a| !a.is_undefined()), which only excludes the literal undefined — it accepts any expression. For parentNode.replaceChild(a, cond ? c : d) the rule offered cond ? c : d.replaceWith(a), which parses as cond ? c : (d.replaceWith(a)) — wrong precedence and wrong semantics. The existing Identifier check applied to member_expr.object (the receiver), not to the arguments.

Fix

Only provide a fixer if both arguments are non-undefined identifiers.

@shulaoda
shulaoda requested a review from camc314 as a code owner June 19, 2026 04:58
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing shulaoda:06-19-fix_prefer_modern_dom_apis_identifier_arguments (13117ae) with main (4f4313e)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix added the A-linter Area - Linter label Jun 19, 2026
Sysix
Sysix previously requested changes Jun 19, 2026

@Sysix Sysix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you still report the error but do not provide a fix?
It is still a non-modern DOM API, but is not safe to fix.

@shulaoda
shulaoda marked this pull request as draft June 19, 2026 13:31
@camc314 camc314 self-assigned this Jun 19, 2026
@camc314
camc314 marked this pull request as ready for review July 3, 2026 14:18
Copilot AI review requested due to automatic review settings July 3, 2026 14:18
@camc314
camc314 force-pushed the 06-19-fix_prefer_modern_dom_apis_identifier_arguments branch from a0f99db to 13117ae Compare July 3, 2026 14:18

@camc314 camc314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@camc314
camc314 dismissed Sysix’s stale review July 3, 2026 14:19

stale - we now report the error and skip fixing

@camc314 camc314 changed the title fix(linter/prefer-modern-dom-apis): require identifier arguments for replaceChild/insertBefore fix(linter/prefer-modern-dom-apis): skip fixer for non identifier arguments for replaceChild/insertBefore Jul 3, 2026
@camc314 camc314 changed the title fix(linter/prefer-modern-dom-apis): skip fixer for non identifier arguments for replaceChild/insertBefore fix(linter/unicorn/prefer-modern-dom-apis): skip fixer for non identifier arguments Jul 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13117aee55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/oxc_linter/src/rules/unicorn/prefer_modern_dom_apis.rs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the unicorn/prefer-modern-dom-apis linter rule to avoid unsafe autofix suggestions for replaceChild/insertBefore when arguments aren’t “simple” identifiers, addressing a precedence/evaluation-order correctness issue.

Changes:

  • Restricts suggestions for replaceChild/insertBefore rewrites to cases where both arguments are non-undefined identifiers.
  • Updates the rule’s tests and snapshot output to cover (and currently assert diagnostics for) non-identifier argument cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/oxc_linter/src/rules/unicorn/prefer_modern_dom_apis.rs Gates the rewrite suggestion behind an identifier-only argument check and updates the rule’s test cases.
crates/oxc_linter/src/snapshots/unicorn_prefer_modern_dom_apis.snap Snapshot updated to include diagnostics for newly added non-identifier argument cases.

Comment thread crates/oxc_linter/src/rules/unicorn/prefer_modern_dom_apis.rs
Comment thread crates/oxc_linter/src/rules/unicorn/prefer_modern_dom_apis.rs
@camc314
camc314 merged commit e383843 into oxc-project:main Jul 3, 2026
35 checks passed
camc314 added a commit that referenced this pull request Jul 3, 2026
…fier arguments (#23630)

### Summary

`unicorn/prefer-modern-dom-apis` reported (and offered a
precedence-breaking suggestion for) `replaceChild`/`insertBefore` calls
whose arguments are not plain identifiers.

### Problem

The argument guard was `arguments.all(|a| !a.is_undefined())`, which
only excludes the literal `undefined` — it accepts any expression. For
`parentNode.replaceChild(a, cond ? c : d)` the rule offered `cond ? c :
d.replaceWith(a)`, which parses as `cond ? c : (d.replaceWith(a))` —
wrong precedence and wrong semantics. The existing `Identifier` check
applied to `member_expr.object` (the receiver), not to the arguments.

### Fix

Only provide a fixer if both arguments are non-`undefined` identifiers.

---------

Co-authored-by: Cameron <[email protected]>
camc314 added a commit that referenced this pull request Jul 3, 2026
…fier arguments (#23630)

### Summary

`unicorn/prefer-modern-dom-apis` reported (and offered a
precedence-breaking suggestion for) `replaceChild`/`insertBefore` calls
whose arguments are not plain identifiers.

### Problem

The argument guard was `arguments.all(|a| !a.is_undefined())`, which
only excludes the literal `undefined` — it accepts any expression. For
`parentNode.replaceChild(a, cond ? c : d)` the rule offered `cond ? c :
d.replaceWith(a)`, which parses as `cond ? c : (d.replaceWith(a))` —
wrong precedence and wrong semantics. The existing `Identifier` check
applied to `member_expr.object` (the receiver), not to the arguments.

### Fix

Only provide a fixer if both arguments are non-`undefined` identifiers.

---------

Co-authored-by: Cameron <[email protected]>
Boshen added a commit that referenced this pull request Jul 6, 2026
# Oxlint
### 🚀 Features

- 7db7a29 allocator: Add `ReplaceWith` trait (#24012) (overlookmotel)
- a2c97f3 linter/unicorn: Implement `explicit-timer-delay` rule (#23612)
(Mikhail Baev)
- 85735cb linter/unicorn: Implement `no-confusing-array-with` rule
(#23638) (Shekhu☺️)
- cb4fbb9 linter/eslint: Implement no-unreachable-loop rule (#23975)
(Todor Andonov)
- dc32112 linter/eslint/no-constant-binary-expression: Check relational
comparisons (#24088) (camc314)
- 439c344 linter/jsdoc: Added missing options to `jsdoc/require-param`
rule (#23364) (kapobajza)
- 62af717 linter/unicorn/filename-case: Add `lowercase` and
`screamingSnakeCase` (#24045) (Boshen)
- d963967 linter/unicorn/no-array-sort: Add `allowAfterSpread` option
(#24043) (Boshen)
- 0a75682 linter: Add per-rule timings for type-aware linting (#22488)
(camchenry)
- 743e222 linter/react: Add `disallowedValues` option for
`forbid-dom-props` rule (#23970) (Mikhail Baev)

### 🐛 Bug Fixes

- 7b80010 linter: Use direct binding symbol ids (#24216) (camc314)
- 8f94b49 linter/import/no-duplicates: Don't flag a type-only import
beside a side-effect import (#24030) (Boshen)
- d8c3fee linter/react/rules-of-hooks: Flag `useEffectEvent` escapes
(#23764) (Rayan Salhab)
- 0a7312b linter/no-deprecated-functions: Map `require.requireActual` to
`jest.requireActual` (#23627) (Jerry Zhao)
- d9e3ab3 linter/eslint/no-useless-return: Handle switch case
continuation (#23984) (camc314)
- 0b25582 ast: Type binding node `typeAnnotation` as `TSTypeAnnotation |
null` (#23113) (Boshen)
- 122d112 linter/eslint/no-restricted-imports: Flag dynamic import()
expressions (#24029) (Boshen)
- 59b6b83 linter: Avoid `OnceLock` re-entry on cyclic `export *`
re-exports (#23632) (Jerry Zhao)
- dd09af0 linter/import/namespace: Avoid panic on destructuring of an
unresolvable namespace re-export (#23626) (Jerry Zhao)
- bdb51c7 linter/jest/prefer-ending-with-an-expect: Validate config
patterns (#24122) (camc314)
- e383843 linter/unicorn/prefer-modern-dom-apis: Skip fixer for non
identifier arguments (#23630) (Jerry Zhao)
- 0ac4c83 linter: Detect circular config extends (#24115) (camc314)
- bae1edf linter/import/namespace: Check namespace imports after named
imports (#24094) (camc314)
- cd8fdfe linter/eslint/no-eval: Recognize Array.from family thisArg
(#24091) (camc314)
- 851ee43 linter/eslint/no-eval: Resolve this binding for functions
returned from an IIFE (#23643) (Jerry Zhao)
- 002ab35 linter/unicorn: Avoid prefer-array-find rest destructuring
false positive (#23654) (ColemanDunn)
- 01c8775 linter/unicorn/filename-case: Keep digits attached in
screamingSnakeCase (#24056) (Boshen)
- f256941 linter: Recognize `@effect/vitest` as a vitest import source
(#24025) (Boshen)
- 73eeb1d linter/import/extensions: Honor per-extension `never` for
explicit extensions (#24031) (Boshen)
- d4ebe1f linter: Reject non-object oxlint config files (#24026)
(Boshen)
- 45d607d linter/react/forbid-component-props: Make allow/disallow lists
optional in schema (#24024) (Boshen)
- 54076ad linter/unicorn/no-array-for-each: Suggest entries loop for
index callbacks (#24004) (camc314)
- d057736 linter/jsdoc: Avoid param root underflow (#23945) (camc314)
- 29c76bf linter/unicorn/prefer-at: Skip object numeric-key access
(#23909) (Gaurav Dubey)

### ⚡ Performance

- 657a8fc linter/oxc/bad-array-method-on-arguments: Only run on member
expressions instead of all identifiers (#24164) (camchenry)
- 073d9e7 linter/eslint/prefer-rest-params: Run on functions instead of
all identifiers (#24163) (camchenry)
- e5a4162 linter/jest/no-confusing-set-timeout: Early exit fast path
(#24092) (camc314)
- bca7ce5 linter: Only run react-perf rules on JSX attribute nodes
(#24083) (camchenry)
- 6881bf6 linter: Compute `apply_overrides` rule set lazily (#23648)
(Jerry Zhao)
- 911c106 linter/eslint/no-obj-calls: Use resolved reference instead of
scope walk (#23895) (Marius Schulz)
- dc8fd9a linter/unicorn/prefer-dom-node-text-content: Change dispatch
to run only on less common node types (#23897) (Connor Shea)
- fdbd34d linter/eslint/no-useless-call: Fast-path static callees
(#24077) (camc314)
- b1be114 linter/import/extensions: Skip empty config and borrow
extensions (#24075) (camc314)
- 4781b2d linter/eslint/no-obj-calls: Use direct global matches (#24076)
(camc314)
- e6cee89 linter: Avoid node-chain allocation for non-Jest calls
(#23907) (Yagiz Nizipli)
- 30dc517 linter/typescript/no-restricted-types: O(1) banned-type
lookups (#23827) (Yagiz Nizipli)

### 📚 Documentation

- 6ca9125 linter/typescript: Clarify consistent-type-imports behavior
(#23972) (camc314)
# Oxfmt
### 🚀 Features

- 4f4313e formatter_css: Update oxc-css-parser 0.0.5 (#24120) (leaysgur)
- 0ccd8a1 formatter_graphql: Update oxc-graphql-parser 0.0.5 (#24106)
(leaysgur)
- 89ec3d9 formatter_core: Add literal line and root indention primitives
(#24051) (leaysgur)
- 213a96b formatter_core: Add no-expand-parent for multiline text
(#24050) (leaysgur)
- 0e5bcc9 formatter_graphql: Update oxc-graphql-parser 0.0.4 (#24039)
(leaysgur)
- e0b35a1 formatter_css: Update `[email protected]` (#23974)
(leaysgur)

### 🐛 Bug Fixes

- 1fe6546 formatter: Omit unneeded `;` for type members with `no-semi`
(#24212) (leaysgur)
- 0ad7316 formatter: Print space for `ForStatement`.`update` only if
exists (#24211) (leaysgur)
- 3abbed5 formatter: Print `;` before jsdoc type-cast parens with
no-semi (#24208) (leaysgur)
- 9af3833 formatter_css: Make scss formatter consistent (#24207)
(leaysgur)
- 46d7194 formatter_css: Use fill IR for `@forward` members (#24206)
(leaysgur)
- e31038f formatter_css: Keep comment inside sass config list (#24205)
(leaysgur)
- d3b9591 formatter: Add parens around `await/yield` with `<T>` (#24202)
(leaysgur)
- 2121a55 oxfmt: Reuse tinypool process during the same LSP process
(#24197) (leaysgur)
- 9bf4b4a formatter_css: Align CSS output to Prettier 3.9.1 (#24100)
(leaysgur)
- cd2452e formatter_css: Align SCSS output to Prettier 3.9.1 (#24097)
(leaysgur)
- 4ee8745 formatter_css: Keep selector value contain line-break without
breaking line (#24055) (leaysgur)
- e1ece97 formatter_graphql: Break `implements` list by print-width
(#23997) (leaysgur)
- 0a6b16c formatter_json: Preserve key and literal value for
json-stringify (#23996) (leaysgur)
- 903ab6e formatter_css: Preserve newlines in css-in-js selector list
(#23992) (leaysgur)
- ea5d095 oxfmt: Update `--migrate prettier` (#23963) (leaysgur)

### ⚡ Performance

- 468e1e3 formatter_core: Make printer queues cursor-based (#24098)
(Boshen)
- c59f2fe rust: Return impl ExactSizeIterator from slice-backed
accessors (#24144) (Boshen)
- c292fb2 formatter: Inline fits element dispatcher (#23982) (camc314)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants