refactor(minifier): remove dead SymbolValue::scope_id field#23464
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2026
Dunqing
marked this pull request as ready for review
June 16, 2026 01:57
Merging this PR will not alter performance
Comparing 
Footnotes
|
graphite-app
Bot
force-pushed
the
feat/minifier-inline-readonly-vars
branch
from
June 16, 2026 02:03
06c82aa to
d251662
Compare
graphite-app
Bot
force-pushed
the
feat/minifier-inline-readonly-vars
branch
from
June 16, 2026 02:04
d251662 to
8fcaf80
Compare
graphite-app
Bot
force-pushed
the
refactor/minifier-remove-dead-scope-id
branch
from
June 16, 2026 02:04
0fa5bb1 to
67351b4
Compare
graphite-app
Bot
changed the base branch from
feat/minifier-inline-readonly-vars
to
graphite-base/23464
June 16, 2026 02:09
graphite-app
Bot
force-pushed
the
graphite-base/23464
branch
from
June 16, 2026 02:13
8fcaf80 to
09762d9
Compare
graphite-app
Bot
force-pushed
the
refactor/minifier-remove-dead-scope-id
branch
from
June 16, 2026 02:13
67351b4 to
91ff1c1
Compare
graphite-app
Bot
force-pushed
the
refactor/minifier-remove-dead-scope-id
branch
from
June 16, 2026 02:14
91ff1c1 to
91509fb
Compare
Member
Author
Merge activity
|
## Summary - Remove `SymbolValue::scope_id`: it was written in `init_value` but never read. The declaring scope is still looked up locally there to gate `initialized_constant` on the `DirectEval` flag — only the stored-but-unused field (and the now-dead `ScopeId` import) are dropped. - No behavior change; pure dead-field removal. Verified by `cargo test -p oxc_minifier` (535 + 2 passed).
graphite-app
Bot
force-pushed
the
refactor/minifier-remove-dead-scope-id
branch
from
June 16, 2026 02:38
91509fb to
01fe442
Compare
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
## Summary - Remove `SymbolValue::scope_id`: it was written in `init_value` but never read. The declaring scope is still looked up locally there to gate `initialized_constant` on the `DirectEval` flag — only the stored-but-unused field (and the now-dead `ScopeId` import) are dropped. - No behavior change; pure dead-field removal. Verified by `cargo test -p oxc_minifier` (535 + 2 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SymbolValue::scope_id: it was written ininit_valuebut never read. The declaring scope is still looked up locally there to gateinitialized_constanton theDirectEvalflag — only the stored-but-unused field (and the now-deadScopeIdimport) are dropped.cargo test -p oxc_minifier(535 + 2 passed).