Skip to content

refactor(oxfmt): use unified embedded ir results#23325

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-12-refactor_oxfmt_use_unified_embedded_ir_results
Jun 29, 2026
Merged

refactor(oxfmt): use unified embedded ir results#23325
graphite-app[bot] merged 1 commit into
mainfrom
06-12-refactor_oxfmt_use_unified_embedded_ir_results

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Add EmbeddedIr struct in oxc_formatter_core
  • Each format_to_ir implementation returns this as unified result

This was referenced Jun 12, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@leaysgur Graphite App

leaysgur commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 12, 2026
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 12, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 14 skipped benchmarks1

Comparing 06-12-refactor_oxfmt_use_unified_embedded_ir_results (3c3e4af) with main (e1f89ab)2

Open in CodSpeed

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 06-12-refactor_oxfmt_remove_prettier_fallback_for_css (6fdc23e) during the generation of this report, so main (e1f89ab) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from ef3b50d to e20eabf Compare June 12, 2026 07:44
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch 2 times, most recently from 4132591 to 74e46e5 Compare June 12, 2026 07:47
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from 58af702 to ff23826 Compare June 12, 2026 07:58
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 74e46e5 to 845cd47 Compare June 12, 2026 07:58
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from ff23826 to d924eb7 Compare June 12, 2026 08:25
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch 2 times, most recently from 7089ce1 to 9465af4 Compare June 12, 2026 08:45
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from d924eb7 to 81b320c Compare June 12, 2026 08:45
@leaysgur
leaysgur changed the base branch from 06-12-refactor_oxfmt_remove_prettier_fallback_for_css to graphite-base/23325 June 15, 2026 01:28
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 81b320c to a204713 Compare June 15, 2026 01:29
@leaysgur
leaysgur force-pushed the graphite-base/23325 branch from 9465af4 to 9a272cb Compare June 15, 2026 01:29
@leaysgur
leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 15, 2026 01:29
@leaysgur leaysgur mentioned this pull request Jun 15, 2026
Merged
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from e92460d to 4b04022 Compare June 25, 2026 00:58
@leaysgur leaysgur mentioned this pull request Jun 25, 2026
Merged
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 925d8f6 to ad7168e Compare June 25, 2026 01:05
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 4b04022 to b869fd5 Compare June 25, 2026 01:05
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from ad7168e to 62b514d Compare June 25, 2026 01:26
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from 271809c to 84a8300 Compare June 25, 2026 01:30
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 62b514d to 4a9db0d Compare June 25, 2026 01:30
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 84a8300 to f3d779b Compare June 25, 2026 01:39
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 4a9db0d to ae49f5e Compare June 25, 2026 01:39
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from f3d779b to 9a25032 Compare June 25, 2026 15:02
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from ae49f5e to c8c67c0 Compare June 25, 2026 15:02
@leaysgur leaysgur mentioned this pull request Jun 25, 2026
Merged
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from c8c67c0 to 9fb27b8 Compare June 26, 2026 07:00
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 9a25032 to 95061b3 Compare June 26, 2026 07:00
This was referenced Jun 26, 2026
Merged
Merged
Merged
Merged
Merged
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 95061b3 to e94df89 Compare June 29, 2026 02:31
@leaysgur
leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 9fb27b8 to 6fdc23e Compare June 29, 2026 02:31
This was referenced Jun 29, 2026
Merged
Merged
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app
graphite-app Bot force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 63245ed to 8bccc22 Compare June 29, 2026 03:03
@graphite-app
graphite-app Bot force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 3c3e4af to ae573df Compare June 29, 2026 03:03
@graphite-app

graphite-app Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@leaysgur
refactor(oxfmt): use unified embedded ir results (#23325)
72a5d08 
- Add `EmbeddedIr` struct in `oxc_formatter_core`
- Each `format_to_ir` implementation returns this as unified result
@graphite-app
graphite-app Bot force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 8bccc22 to 721667e Compare June 29, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing

Assignees

No one assigned

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur