fix(parser): reject module-referencing imports/exports in a namespace body by Boshen · Pull Request #22829 · oxc-project/oxc

Boshen · 2026-05-29T10:56:23Z

Inside an internal namespace N {} / module N {}, statements that reference a
module are not permitted — this matches both babel and TypeScript:

import ... from "m" / import x = require("m") → TS1147
export ... from "m" / export * from "m" → TS1194
export default ... → TS1319
export = ... → TS1063

Bare export { x } (re-export of locals, no module source) and import x = A.B
(entity alias) stay valid, as do external modules (declare module "x" {}) where
these forms are allowed — the check only runs for internal namespaces, so those
never reach it.

Also removes TS1147 from the coverage denylist (NOT_SUPPORTED_ERROR_CODES), since
oxc now detects it.

Conformance (no regressions, positive/AST stay 100% everywhere):

parser_babel negative 1696 → 1704
parser_typescript negative 1585 → 1594

Boshen · 2026-05-29T10:56:36Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-05-29T11:03:54Z

Merging this PR will not alter performance

✅ 57 untouched benchmarks

_{Comparing fix/namespace-body-module-refs (56b18d9) with fix/const-modifier-type-alias (3ed3157)¹}

No successful run was found on fix/const-modifier-type-alias (b817ee4) during the generation of this report, so 10095f7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Boshen · 2026-05-31T09:29:01Z

Merge activity

May 31, 9:29 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 7, 1:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 7, 2:37 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 7, 3:03 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 8, 4:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 8, 4:31 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 8, 4:53 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 8, 4:53 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

### 💥 BREAKING CHANGES - 7a24911 codegen: [**BREAKING**] Borrow sourcemaps from codegen (#23422) (Boshen) - bb0ed44 transformer: [**BREAKING**] Disable styled-components transpileTemplateLiterals by default (#23171) (Boshen) ### 🚀 Features - 1490a0a linter/react: Implement react-compiler rule (#23202) (Boshen) - 6c0bdf0 transformer/react-refresh: Support `module.property.useHook()` (#23190) (Dunqing) - 47991bd semantic: Report TS1228 for invalid type predicates (#23174) (camc314) - 1d3af58 parser: Add TS2398 parameter property diagnostic (#23216) (camc314) - 44313da semantic: Add `scope_is_descendant_of` api (#22313) (camc314) - e5050c0 parser: Improve diagnostic for rest initializer (#23205) (camc314) - ec266bb transformer: Run React Compiler as a feature-gated transform pass (#23201) (Boshen) - e7374fe parser: Report error for `const` modifier on interface type parameter (#23173) (camc314) - a7c1c9b parser: Report ambient definite variable assertions (#23165) (camc314) - d169fcd parser: Report invalid class definite assertions (#23164) (camc314) - 00244d8 parser: Report definite property initializer errors (#23160) (camc314) ### 🐛 Bug Fixes - 52d0c31 transformer: Replace ambient dot defines (#23231) (camc314) - 2c28748 transformer/class: Parent generated constructors to class scope (#23222) (camc314) - 8edd234 parser: Report accessor definite assertion on token (#23203) (camc314) - de38a3f react_compiler: Keep imports referenced only by a local re-export (#23176) (Boshen) - f5721c2 codegen: Preserve parentheses around `intrinsic` type reference (#23156) (Boshen) - e89f81d parser: Don't emit TS1477 for parenthesized instantiation expression (#23147) (Boshen) - 8a04149 parser: Reject module-referencing imports/exports in a namespace body (#22829) (Boshen) ### ⚡ Performance - 2783295 parser: Table-driven operator precedence lookup (#23346) (Boshen) - 231d5de parser: Single-match member expression dispatch (#23347) (Boshen) - e89729b codegen: Accept one-shot wrap closures (#23265) (camc314) - a6c11fa parser: Force-inline read_non_decimal to fold per-digit number dispatch (#23157) (Boshen) - d74964c parser: Store class definite assertion offset (#23170) (camc314) - f0fda4d parser: Shrink-wrap cold diagnostic tails out of hot frames (#23159) (Boshen) - a082180 parser: Store definite assertion offset (#23167) (camc314) - 534f9c6 oxc: Conditionally rebuild semantic in compiler pipeline (#23153) (Boshen) - b435c6a parser: Skip checkpoint for `infer T extends U` constraint in disallow context (#23128) (Boshen) - 7464dce parser: Peek instead of checkpoint/rewind for `export default` modifier (#23124) (Boshen) - 80a9a32 parser: Fast-path single-keyword TS declarations (#23083) (Boshen) - da1a6c6 diagnostics: Migrate to allocation-optimized oxc-miette (#23094) (Boshen) - b7b08ce parser: Peek once for the static modifier disambiguation (#23079) (Boshen) - e7e07a3 parser: Fold unary dispatch into a single match (#23076) (Boshen) ### 📚 Documentation - d241add semantic: Add `AGENTS.md` test guidance for agents (#23441) (camc314) - 026f1ae parser: Add `AGENTS.md` test guidance for agents (#23440) (camc314) - 09755ac transformer: Add `AGENTS.md` test guidance for agents (#23439) (camc314) - e6bdfd4 lexer: Correct reference link for `byte_handlers!` (#23313) (Dunqing) - 65b6d7a allocator: Fix memory leaks in `Arena` examples (#23257) (overlookmotel) Co-authored-by: Boshen <[email protected]>

… body (#22829) Inside an internal `namespace N {}` / `module N {}`, statements that reference a module are not permitted — this matches both babel and TypeScript: - `import ... from "m"` / `import x = require("m")` → TS1147 - `export ... from "m"` / `export * from "m"` → TS1194 - `export default ...` → TS1319 - `export = ...` → TS1063 Bare `export { x }` (re-export of locals, no module source) and `import x = A.B` (entity alias) stay valid, as do external modules (`declare module "x" {}`) where these forms are allowed — the check only runs for internal namespaces, so those never reach it. Also removes TS1147 from the coverage denylist (`NOT_SUPPORTED_ERROR_CODES`), since oxc now detects it. Conformance (no regressions, positive/AST stay 100% everywhere): - parser_babel negative 1696 → 1704 - parser_typescript negative 1585 → 1594

### 💥 BREAKING CHANGES - 7a24911 codegen: [**BREAKING**] Borrow sourcemaps from codegen (#23422) (Boshen) - bb0ed44 transformer: [**BREAKING**] Disable styled-components transpileTemplateLiterals by default (#23171) (Boshen) ### 🚀 Features - 1490a0a linter/react: Implement react-compiler rule (#23202) (Boshen) - 6c0bdf0 transformer/react-refresh: Support `module.property.useHook()` (#23190) (Dunqing) - 47991bd semantic: Report TS1228 for invalid type predicates (#23174) (camc314) - 1d3af58 parser: Add TS2398 parameter property diagnostic (#23216) (camc314) - 44313da semantic: Add `scope_is_descendant_of` api (#22313) (camc314) - e5050c0 parser: Improve diagnostic for rest initializer (#23205) (camc314) - ec266bb transformer: Run React Compiler as a feature-gated transform pass (#23201) (Boshen) - e7374fe parser: Report error for `const` modifier on interface type parameter (#23173) (camc314) - a7c1c9b parser: Report ambient definite variable assertions (#23165) (camc314) - d169fcd parser: Report invalid class definite assertions (#23164) (camc314) - 00244d8 parser: Report definite property initializer errors (#23160) (camc314) ### 🐛 Bug Fixes - 52d0c31 transformer: Replace ambient dot defines (#23231) (camc314) - 2c28748 transformer/class: Parent generated constructors to class scope (#23222) (camc314) - 8edd234 parser: Report accessor definite assertion on token (#23203) (camc314) - de38a3f react_compiler: Keep imports referenced only by a local re-export (#23176) (Boshen) - f5721c2 codegen: Preserve parentheses around `intrinsic` type reference (#23156) (Boshen) - e89f81d parser: Don't emit TS1477 for parenthesized instantiation expression (#23147) (Boshen) - 8a04149 parser: Reject module-referencing imports/exports in a namespace body (#22829) (Boshen) ### ⚡ Performance - 2783295 parser: Table-driven operator precedence lookup (#23346) (Boshen) - 231d5de parser: Single-match member expression dispatch (#23347) (Boshen) - e89729b codegen: Accept one-shot wrap closures (#23265) (camc314) - a6c11fa parser: Force-inline read_non_decimal to fold per-digit number dispatch (#23157) (Boshen) - d74964c parser: Store class definite assertion offset (#23170) (camc314) - f0fda4d parser: Shrink-wrap cold diagnostic tails out of hot frames (#23159) (Boshen) - a082180 parser: Store definite assertion offset (#23167) (camc314) - 534f9c6 oxc: Conditionally rebuild semantic in compiler pipeline (#23153) (Boshen) - b435c6a parser: Skip checkpoint for `infer T extends U` constraint in disallow context (#23128) (Boshen) - 7464dce parser: Peek instead of checkpoint/rewind for `export default` modifier (#23124) (Boshen) - 80a9a32 parser: Fast-path single-keyword TS declarations (#23083) (Boshen) - da1a6c6 diagnostics: Migrate to allocation-optimized oxc-miette (#23094) (Boshen) - b7b08ce parser: Peek once for the static modifier disambiguation (#23079) (Boshen) - e7e07a3 parser: Fold unary dispatch into a single match (#23076) (Boshen) ### 📚 Documentation - d241add semantic: Add `AGENTS.md` test guidance for agents (#23441) (camc314) - 026f1ae parser: Add `AGENTS.md` test guidance for agents (#23440) (camc314) - 09755ac transformer: Add `AGENTS.md` test guidance for agents (#23439) (camc314) - e6bdfd4 lexer: Correct reference link for `byte_handlers!` (#23313) (Dunqing) - 65b6d7a allocator: Fix memory leaks in `Arena` examples (#23257) (overlookmotel) Co-authored-by: Boshen <[email protected]>

This was referenced May 29, 2026

fix(parser): reject 'const' modifier on type alias type parameter #22828

Closed

fix(parser): reject TypeScript declarations in single-statement context #22827

Merged

github-actions Bot added the A-parser Area - Parser label May 29, 2026

Boshen marked this pull request as ready for review May 29, 2026 10:57

Boshen force-pushed the fix/namespace-body-module-refs branch 3 times, most recently from 4f6f0dd to 56b18d9 Compare May 29, 2026 14:37

Boshen added the 0-merge Merge with Graphite Merge Queue label May 31, 2026

Boshen changed the base branch from fix/const-modifier-type-alias to main May 31, 2026 09:43

Boshen force-pushed the fix/namespace-body-module-refs branch from 56b18d9 to 8b0372b Compare June 5, 2026 06:43

camc314 reviewed Jun 5, 2026

View reviewed changes

Comment thread crates/oxc_parser/src/diagnostics.rs Outdated

Boshen force-pushed the fix/namespace-body-module-refs branch from 8b0372b to a7c0320 Compare June 7, 2026 01:44

Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jun 7, 2026

camc314 added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jun 7, 2026

Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jun 7, 2026

Boshen force-pushed the fix/namespace-body-module-refs branch from a7c0320 to 16947f0 Compare June 8, 2026 16:13

Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jun 8, 2026

fix(parser): reject 'const' modifier on type alias type parameter

af1e189

Boshen force-pushed the fix/namespace-body-module-refs branch from 16947f0 to af1e189 Compare June 8, 2026 16:31

Boshen merged commit 8a04149 into main Jun 8, 2026
29 checks passed

Boshen deleted the fix/namespace-body-module-refs branch June 8, 2026 16:53

oxc-guard Bot mentioned this pull request Jun 15, 2026

release(crates): oxc v0.136.0 #23443

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(parser): reject module-referencing imports/exports in a namespace body#22829

fix(parser): reject module-referencing imports/exports in a namespace body#22829
Boshen merged 1 commit into
mainfrom
fix/namespace-body-module-refs

Boshen commented May 29, 2026

Uh oh!

Boshen commented May 29, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented May 29, 2026 •

edited

Loading

Uh oh!

Boshen commented May 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Boshen commented May 29, 2026

Uh oh!

Boshen commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Boshen commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Boshen commented May 29, 2026 •

edited

Loading

codspeed-hq Bot commented May 29, 2026 •

edited

Loading

Boshen commented May 31, 2026 •

edited

Loading