Skip to content

perf(semantic): skip unresolved checks for re-exports#22660

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports
May 22, 2026
Merged

perf(semantic): skip unresolved checks for re-exports#22660
graphite-app[bot] merged 1 commit into
mainfrom
c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports

Conversation

@camc314

@camc314 camc314 commented May 21, 2026

Copy link
Copy Markdown
Contributor

check_unresolved_exports scans named exports in JavaScript modules and verifies that local export specifiers resolve to local bindings.

Sourced re-exports, such as export { value as name } from "pkg", do not need this local binding check. This adds a decl.source.is_none() guard so check_unresolved_exports skips the specifier/reference loop for sourced re-exports entirely.

camc314 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review May 21, 2026 20:45
@camc314 camc314 requested a review from Dunqing as a code owner May 21, 2026 20:46
Copilot AI review requested due to automatic review settings May 21, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Optimizes the JavaScript semantic early-error check check_unresolved_exports by skipping local-binding resolution work for sourced re-exports (e.g. export { x as y } from "pkg"), since those specifiers are not required to resolve to local bindings.

Changes:

  • Add a decl.source.is_none() guard so only local named exports are scanned for unresolved local bindings.
  • Avoids iterating specifiers / computing available root-scope binding names for sourced re-export declarations.

@codspeed-hq

codspeed-hq Bot commented May 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports (0a926d7) with c/05-21-perf_semantic_store_class_parents_in_indexvec (7078e0d)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on c/05-21-perf_semantic_store_class_parents_in_indexvec (ab047bb) during the generation of this report, so 2c30476 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314

camc314 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-05-21 at 21 51 20

seems to be ~1% faster in this case. note this code path doesn't run for TS/ non module code, so RadixUIAdoptionSection.jsx is the only test case that will bench this path

@graphite-app graphite-app Bot force-pushed the c/05-21-perf_semantic_store_class_parents_in_indexvec branch from 94ae935 to 7078e0d Compare May 22, 2026 00:57
@graphite-app graphite-app Bot force-pushed the c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports branch from 9b61df6 to fbd809c Compare May 22, 2026 00:58
@graphite-app graphite-app Bot force-pushed the c/05-21-perf_semantic_store_class_parents_in_indexvec branch 2 times, most recently from 749b0f9 to ab047bb Compare May 22, 2026 04:29
@graphite-app graphite-app Bot force-pushed the c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports branch from fbd809c to 0a926d7 Compare May 22, 2026 04:29
@camc314 camc314 changed the base branch from c/05-21-perf_semantic_store_class_parents_in_indexvec to graphite-base/22660 May 22, 2026 09:48
@camc314 camc314 force-pushed the c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports branch from 0a926d7 to fed18fe Compare May 22, 2026 09:48
@camc314 camc314 force-pushed the graphite-base/22660 branch from ab047bb to b0c0955 Compare May 22, 2026 09:48
@camc314 camc314 changed the base branch from graphite-base/22660 to main May 22, 2026 09:48
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 22, 2026

camc314 commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

@camc314 camc314 force-pushed the c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports branch from fed18fe to 13daf6d Compare May 22, 2026 09:54
`check_unresolved_exports` scans named exports in JavaScript modules and verifies that local export specifiers resolve to local bindings.

Sourced re-exports, such as `export { value as name } from "pkg"`, do not need this local binding check. This adds a `decl.source.is_none()` guard so `check_unresolved_exports` skips the specifier/reference loop for sourced re-exports entirely.
@graphite-app graphite-app Bot force-pushed the c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports branch from 13daf6d to 2f623b0 Compare May 22, 2026 09:58
@graphite-app graphite-app Bot merged commit 2f623b0 into main May 22, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 22, 2026
@graphite-app graphite-app Bot deleted the c/05-21-perf_semantic_skip_unresolved_checks_for_re-exports branch May 22, 2026 10:02
Dunqing added a commit that referenced this pull request May 26, 2026
### 🚀 Features

- e857b0c napi/minify: Expose legalComments option and result (#20370)
(Boshen)
- 661132d parser: More friendly error messages for rest assignment
target and rest binding element (#22719) (sapphi-red)
- ee659b6 transformer/legacy-decorator: Add `strictNullChecks` option
for nullable-union design:type (#22266) (Kyle Cannon)

### 🐛 Bug Fixes

- e1d064e transformer/class-properties: Reparent lifted private method
helpers (#22716) (Cameron)
- 4ac0fca minifier: Preserve `0 && (module.exports = { ... })`
cjs-module-lexer hint (#22729) (Dunqing)
- 40ff611 minifier: Mark peephole loop changed when dropping
dead-after-throw statement (#22722) (Dunqing)
- 2f7b210 codegen: Emit pife-arrow/function leading comments inside the
wrap (#22720) (Dunqing)
- e184f74 parser: Improve invalid `import` property access diagnostic
(#22693) (camc314)
- 7baed9c transformer/private-method: Clear inherited strict flags
(#22508) (camc314)
- a9ad27e parser: Keep annotation comments leading without preceding
newline (#22711) (Dunqing)
- 9ea4d64 minifier: Re-evaluate pure/no-side-effects flags after
peephole inlining (#22595) (Dunqing)
- 07afbb6 minifier: Drop empty-body IIFE wrapper when called with
arguments (#22589) (Dunqing)
- fa7c463 semantic: Correct TS enum member symbol spans (#22689)
(camc314)
- 26b9396 semantic: Resolve parameter decorators outside parameter scope
(#22623) (camc314)
- b284045 parser: Switch to module goal eagerly on `export` (#22684)
(Boshen)
- dfa931d semantic: Propagate unresolved auto-increment enum value
instead of defaulting to 0 (#22646) (Dunqing)
- 69a6ba6 transformer/legacy-decorator: Emit Array for ReadonlyArray<T>
in decorator metadata (#22265) (Kyle Cannon)
- e421ef0 transformer/legacy-decorator: Return runtime binding for
design:type (#22640) (Dunqing)
- d61e1d7 codegen: Preserve verbatim text of pure/no-side-effects
comments (#22525) (Dunqing)
- 702b14e minifier: Preserve IIFE structure in DCE-only mode (#22547)
(Dunqing)
- 917da24 parser: Apply PURE comment through member-access chains
(#22566) (Dunqing)
- a069b1c codegen: Preserve quotes for cjs-module-lexer equality strings
(#22551) (Dunqing)

### ⚡ Performance

- 2f623b0 semantic: Skip unresolved checks for re-exports (#22660)
(camc314)
- 0d9553d semantic: Early-exit `check_object_expression` for objects
with <2 properties (#22668) (Dunqing)
- d721ad9 semantic: Use direct grandparent lookup for TS type parameters
(#22658) (camc314)
- 0aff288 semantic: Reorder numeric literal strict mode checks (#22657)
(camc314)
- 4d5ddb1 semantic: Reorder binding identifier checks (#22656) (camc314)
- e32acd8 semantic: Reorder identifier ambient binding check (#22653)
(camc314)
- 09fe178 semantic: Reorder ident reference strict mode check (#22652)
(camc314)
- 4b6add2 semantic: Avoid duplicate ident clone for bindings (#22663)
(camc314)
- 82f9662 parser: Check identifier kind before context flag (#22662)
(camc314)
- d7cd951 parser: Fast path identifier parsing and inline operator
helpers (#22650) (Boshen)
- 7b84314 semantic: Use direct byte access for numeric leading-zero
check (#22642) (camc314)
- 0345a31 semantic: Pre-size class elements hash map (#22618) (camc314)
- 04d3065 minifier: Drop per-call buffers in try_fold_concat (#22596)
(Dunqing)
- 4f289f1 semantic: Resolve_references_for_current_scope without a temp
Vec (#22599) (Dunqing)
- e862c15 semantic: Avoid heap alloc for var hoist scope ids (#22603)
(Dunqing)
- 8ff8674 semantic: Early return if `excess` is `0` in
`Stats::increase_by` (#22616) (camc314)
- 7a4120e semantic: Pre-reserve unresolved_references using
Stats::references (#22580) (Dunqing)

Co-authored-by: Dunqing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants