fix(linter): `no-misleading-character-class` fix `is_unicode_code_point_escape` check by Sysix · Pull Request #22655 · oxc-project/oxc

Sysix · 2026-05-21T17:10:48Z

Pull request overview

This PR adjusts the eslint/no-misleading-character-class implementation to better distinguish Unicode code point escapes (\u{...}) from Unicode code unit escapes (\u....), and updates the associated snapshot output accordingly.

Found the right snippet and AI generated a simpler implementation 🤖

Sysix · 2026-05-21T17:11:01Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-05-21T17:24:11Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 55 skipped benchmarks¹

_{Comparing 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check (24a35a8) with 05-21-fix_oxlint_no-misleading-character-class_own_diagnostic_for_surrogate_pairs_without_u_flog (820eb76)}

55 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

This PR adjusts the eslint/no-misleading-character-class implementation to better distinguish Unicode code point escapes (\u{...}) from Unicode code unit escapes (\u....), and updates the associated snapshot output accordingly.

Changes:

Refines is_unicode_code_point_escape to check for \u{...} syntax rather than relying on CharacterKind::UnicodeEscape.
Updates diagnostics selection for surrogate-pair cases, which changes the emitted help: text.
Refreshes the rule’s snapshot to match the new diagnostic output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/eslint/no_misleading_character_class.rs	Updates escape detection logic used to decide which surrogate-pair diagnostic/help to emit.
crates/oxc_linter/src/snapshots/eslint_no_misleading_character_class.snap	Updates expected snapshot output for `no-misleading-character-class` warnings/help text.

graphite-app · 2026-05-21T21:13:34Z

Merge activity

May 21, 9:13 PM UTC: camc314 added this pull request to the Graphite merge queue.
May 21, 9:18 PM UTC: Merged by the Graphite merge queue.

…nt_escape` check (#22655) > ## Pull request overview > > This PR adjusts the `eslint/no-misleading-character-class` implementation to better distinguish Unicode code point escapes (`\u{...}`) from Unicode code unit escapes (`\u....`), and updates the associated snapshot output accordingly. Found the right snippet and AI generated a simpler implementation 🤖

# Oxlint ### 🚀 Features - 10da26b linter: `no-misleading-character-class` add suggestions for regex literal (#22681) (Sysix) - b84941e linter/vue: Implement no-expose-after-await rule (#22675) (bab) - 98b98c1 linter/vue: Implement no-computed-properties-in-data rule (#22674) (bab) - 868e2e8 linter: Add suggestion for `no-misleading-character-class` (#22631) (Sysix) - 2d4c919 oxlint: Support `vite-plus/resolveConfig` for vite.config.ts (#22456) (leaysgur) - 2a60012 linter/vue: Implement require-render-return rule (#22613) (bab) - 9f227fd linter/vue: Implement no-deprecated-props-default-this rule (#21892) (bab) - 9cd28b3 linter: Add debug option to print files to be linted (#22546) (camchenry) - 87f065e linter/vue: Implement return-in-emits-validator rule (#21935) (bab) - ea0380c linter/unicorn: Implement `import-style` rule (#22173) (Hao Chen) - dde40fe linter/vue: Implement no-watch-after-await rule (#22006) (bab) - a735eb0 linter/vue: Implement valid-next-tick rule (#22531) (bab) - 6dc615d linter/vue: Implement no-shared-component-data rule (#21842) (bab) - a656418 linter/vue: Implement valid-define-options rule (#22107) (bab) - bb6f1b2 linter/vue: Implement require-slots-as-functions rule (#22244) (bab) - 5fa4774 linter/n: Implement `callback-return` rule (#22470) (Mikhail Baev) ### 🐛 Bug Fixes - 52bd016 linter: Respect allow unused disable directives in LSP (#22715) (camc314) - fa7c463 semantic: Correct TS enum member symbol spans (#22689) (camc314) - ed445ba linter: Respect flags overrides for `RegExp(/regex/i, "u")` (#22678) (Sysix) - 26b9396 semantic: Resolve parameter decorators outside parameter scope (#22623) (camc314) - 203952d linter: `no-misleading-character-class` fix `is_unicode_code_point_escape` check (#22655) (Sysix) - 2f64d3d linter: `no-misleading-character-class` own diagnostic for surrogate pairs without u flag (#22654) (Sysix) - 0c6ebc2 linter/eslint/no-lone-blocks: Do not flag empty loops (#22649) (Mikhail Baev) - 2a7562e linter/no-focused-tests: Mark fixer as a suggestion (#22645) (camc314) - dbe644f linter: Respect args none for unused rest parameters (#22627) (camc314) - d0211b0 linter: Allow undefined in DummyRuleMap index (#22626) (camc314) - 36fc0ec oxlint/lsp: "ignore this" actions merge with existing directive (#22604) (Sysix) - f7f370e linter/vitest/prefer-expect-type-of: Recommend `toBeTypeOf` instead of `expectTypeOf` (#22612) (Mikhail Baev) - 77063e5 linter/consistent-indexed-object-style: Preserve interface modifiers in fixes (#22579) (camc314) - 4f33aa7 linter: Treat `TSGlobalDeclaration` as ambient in `has_ambient_typescript_ancestor` (#22577) (camc314) ### ⚡ Performance - c22938d linter/no-async-endpoint-handlers: Populate node types (#22601) (camc314) - 607486e linter/no-negated-condition: Populate node types (#22602) (camc314) - 4dcaa59 linter/consistent-type-imports: Populate node types (#22600) (camc314) - 5bd3b25 linter/no-unused-vars: Avoid cloned ancestor iterator (#22598) (camc314) - 97fe9ba linter/no-extra-non-null-assertion: Reduce node matches (#22588) (camc314) - ae98296 linter/consistent-indexed-object-style: Populate node types (#22578) (camc314) # Oxfmt ### 🚀 Features - 16b8058 oxfmt: Support `vite-plus/resolveConfig` for vite.config.ts (#22454) (leaysgur) ### 🐛 Bug Fixes - 5a26479 formatter: Preserve import phases (#22692) (Cameron) ### ⚡ Performance - 78cf83f formatter: Pre-size output buffer using source text length (#22594) (Dunqing) Co-authored-by: Dunqing <[email protected]>

github-actions Bot added the A-linter Area - Linter label May 21, 2026

Sysix mentioned this pull request May 21, 2026

fix(linter): no-misleading-character-class own diagnostic for surrogate pairs without u flag #22654

Merged

Sysix force-pushed the 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check branch from 510f0df to 09a70c5 Compare May 21, 2026 17:16

Sysix force-pushed the 05-21-fix_oxlint_no-misleading-character-class_own_diagnostic_for_surrogate_pairs_without_u_flog branch from ad28eef to 46d4fcf Compare May 21, 2026 17:16

Sysix mentioned this pull request May 21, 2026

feat(linter): add suggestion for no-misleading-character-class #22631

Merged

Sysix force-pushed the 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check branch from 09a70c5 to 75c660f Compare May 21, 2026 19:53

Sysix force-pushed the 05-21-fix_oxlint_no-misleading-character-class_own_diagnostic_for_surrogate_pairs_without_u_flog branch from 46d4fcf to 64b9cd3 Compare May 21, 2026 19:53

Sysix requested a review from Copilot May 21, 2026 19:56

Copilot started reviewing on behalf of Sysix May 21, 2026 19:56 View session

Sysix force-pushed the 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check branch from 75c660f to a31a88a Compare May 21, 2026 19:58

Sysix force-pushed the 05-21-fix_oxlint_no-misleading-character-class_own_diagnostic_for_surrogate_pairs_without_u_flog branch from 64b9cd3 to 820eb76 Compare May 21, 2026 19:58

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/rules/eslint/no_misleading_character_class.rs

Sysix force-pushed the 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check branch from a31a88a to 24a35a8 Compare May 21, 2026 20:06

Sysix marked this pull request as ready for review May 21, 2026 20:09

Sysix requested a review from camc314 as a code owner May 21, 2026 20:09

Sysix added the C-bug Category - Bug label May 21, 2026

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label May 21, 2026

graphite-app Bot force-pushed the 05-21-fix_oxlint_no-misleading-character-class_own_diagnostic_for_surrogate_pairs_without_u_flog branch from 820eb76 to 2f64d3d Compare May 21, 2026 21:14

graphite-app Bot force-pushed the 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check branch from 24a35a8 to 203952d Compare May 21, 2026 21:14

camc314 approved these changes May 21, 2026

View reviewed changes

Base automatically changed from 05-21-fix_oxlint_no-misleading-character-class_own_diagnostic_for_surrogate_pairs_without_u_flog to main May 21, 2026 21:17

graphite-app Bot merged commit 203952d into main May 21, 2026
31 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 21, 2026

graphite-app Bot deleted the 05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check branch May 21, 2026 21:18

oxc-guard Bot mentioned this pull request May 26, 2026

release(apps): oxlint v1.67.0 && oxfmt v0.52.0 #22735

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): `no-misleading-character-class` fix `is_unicode_code_point_escape` check#22655

fix(linter): `no-misleading-character-class` fix `is_unicode_code_point_escape` check#22655
graphite-app[bot] merged 1 commit into
mainfrom
05-21-fix_linter_no-misleading-character-class_fix_is_unicode_code_point_escape_check

Sysix commented May 21, 2026 •

edited

Loading

Uh oh!

Sysix commented May 21, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Sysix commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Uh oh!

Sysix commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented May 21, 2026 •

edited

Loading

Sysix commented May 21, 2026 •

edited

Loading

codspeed-hq Bot commented May 21, 2026 •

edited

Loading

graphite-app Bot commented May 21, 2026 •

edited

Loading