fix(parser): avoid duplicate export in top-level await reparse#22520
Closed
eyupcanakman wants to merge 1 commit into
Closed
fix(parser): avoid duplicate export in top-level await reparse#22520eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
camc314
requested changes
May 18, 2026
camc314
left a comment
camc314
left a comment
Contributor
There was a problem hiding this comment.
This adds a lot of overhead to the hot path.
iirc, we can use std::mem::replace after the first reparse to just replace the module record
Contributor
Author
|
happy for #22524 to land |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22158.
In unambiguous mode,
export var x = await + 1;reports a falseDuplicated export 'x'diagnostic. The parser sees top-levelawait, queues a reparse, then re-walks the export statement and registersxa second time on the module record.ModuleRecordBuildernow has asuppressedflag that returns early from everyvisit_*method, andreparse_potential_top_level_awaitssets the flag around its loop so pass 2 updates the AST without re-recording entries the first parse already captured.AI assisted.