refactor(codegen): extract consume_pending_indent_space helper#22211
Merged
graphite-app[bot] merged 1 commit intoMay 7, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Dunqing
force-pushed
the
refactor/codegen-extract-pending-indent-space-helpers
branch
from
b7949e1 to
17664a3
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
Dunqing
changed the title
consume_pending_indent_space helper
Dunqing
force-pushed
the
refactor/codegen-extract-pending-indent-space-helpers
branch
from
17664a3 to
f14f340
Compare
Member
Author
|
Pure refactor |
Member
Author
Merge activity
|
) Stacked on #22206. Pure refactor — no behavior change. The `print_next_indent_as_space` flag was being read inline at **five** sites in `gen.rs` via copy-pasted `if flag { print_hard_space(); flag = false }` blocks. Two named private helpers replace those: - `consume_pending_indent_space() -> bool` — emit space + clear flag, returns whether anything was emitted - `clear_pending_indent_space()` — drop the flag without emitting `print_indent` continues to call `consume_pending_indent_space` internally, preserving the flag-as-space contract at every existing `print_indent` site. ## Test plan - [x] `cargo test -p oxc_codegen` passes (100 integration tests, no new tests added since the existing `top_level_decl_mappings_start_after_generated_indent` from #22206 already covers the `Directive` indent path) - [x] `cargo test -p oxc_isolated_declarations` passes (the namespace / `declare module` snapshot fixtures that already exercise indented import/export decls) - [x] No snapshot updates needed
graphite-app
Bot
force-pushed
the
fix/codegen-indent-before-mapping-for-decls
branch
from
a623ceb to
29a3cd7
Compare
graphite-app
Bot
force-pushed
the
refactor/codegen-extract-pending-indent-space-helpers
branch
from
f14f340 to
5bdf497
Compare
Base automatically changed from
fix/codegen-indent-before-mapping-for-decls
to
main
May 7, 2026 14:16
graphite-app
Bot
deleted the
refactor/codegen-extract-pending-indent-space-helpers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #22206. Pure refactor — no behavior change.
The
print_next_indent_as_spaceflag was being read inline at five sites ingen.rsvia copy-pastedif flag { print_hard_space(); flag = false }blocks. Two named private helpers replace those:consume_pending_indent_space() -> bool— emit space + clear flag, returns whether anything was emittedclear_pending_indent_space()— drop the flag without emittingprint_indentcontinues to callconsume_pending_indent_spaceinternally, preserving the flag-as-space contract at every existingprint_indentsite.Test plan
cargo test -p oxc_codegenpasses (100 integration tests, no new tests added since the existingtop_level_decl_mappings_start_after_generated_indentfrom fix(codegen): swap mapping/indent order for top-level decls #22206 already covers theDirectiveindent path)cargo test -p oxc_isolated_declarationspasses (the namespace /declare modulesnapshot fixtures that already exercise indented import/export decls)