refactor(linter): remove fixer eslint compat option#22076
Merged
Conversation
camc314
force-pushed
the
codex/remove-eslint-compat-options
branch
from
May 2, 2026 11:10
f99fa22 to
8034d30
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the now-redundant “ESLint compat” toggle for fix-overlap handling, making boundary-adjacent fixes always be treated as overlapping (ESLint behavior) across the Rust fixer and the JS/plugin-facing fix application path.
Changes:
- Removes the
Fixereslint_compatoption andwith_eslint_compatbuilder, and simplifies overlap detection to always treat adjacent ranges as overlapping. - Updates the JS NAPI binding (
applyFixes) and RuleTester fix application path to drop theeslintCompatargument for fix application. - Updates/streamlines adjacent-fix tests to reflect the single behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_linter/src/fixer/mod.rs | Removes the ESLint-compat toggle and makes adjacent-fix overlap behavior unconditional. |
| apps/oxlint/test/rule_tester.test.ts | Updates adjacent-fix test expectations to match the single overlap behavior. |
| apps/oxlint/src/js_plugins/fix.rs | Changes NAPI apply_fixes binding signature to remove the compat flag. |
| apps/oxlint/src-js/package/rule_tester.ts | Stops threading eslintCompat into fix application; updates calls accordingly. |
| apps/oxlint/src-js/bindings.d.ts | Updates the TS declaration for applyFixes to the new 2-arg signature. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
Merge activity
|
Remove the now-redundant fixer eslint_compat option now that ESLint-compatible adjacent-fix handling is the only behavior. follow on from #22071
graphite-app
Bot
force-pushed
the
codex/remove-eslint-compat-options
branch
from
May 2, 2026 11:35
8034d30 to
bc1408c
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the now-redundant fixer eslint_compat option now that ESLint-compatible adjacent-fix handling is the only behavior.
follow on from #22071