fix(transformer/legacy-decorator): preserve accessor type annotation for emitDecoratorMetadata#21966
Merged
graphite-app[bot] merged 1 commit intoMay 7, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing Footnotes
|
bea18eb to
fc921b8
Compare
b6dbc77 to
a733fec
Compare
Member
Author
Merge activity
|
…for emitDecoratorMetadata (#21966) Fixes bug 7 of #21922. ## The bug `@dec accessor x: T` always emitted `design:type = Object` regardless of `T`: ```ts class Entity { @dec accessor name: string = ""; // tsc: design:type = String @dec accessor count: number = 0; // tsc: design:type = Number } ``` `Reflect.getMetadata("design:type", entity, "name")` returned `Object` instead of `String`. Frameworks reading `design:type` (NestJS Swagger, class-validator, TypeORM column metadata) silently degraded for every typed accessor field. ## Cause `lower_accessor_properties` (in `enter_class`) rewrites ```ts @dec accessor x: T = init; ``` into three members — a private storage field, a synthesized getter, and a synthesized setter — and transfers the decorators to the getter so the existing decorator pipeline picks them up. But it dropped the type annotation: the synth getter was constructed with `return_type: NONE`. The metadata pass runs later and takes the getter branch: ```rust if method.kind.is_get() { (self.serialize_type_annotation(method.value.return_type.as_ref(), ctx), None) } ``` `return_type` is `None` because lowering discarded it, so `serialize_type_annotation` correctly fell through to `Object` for what it sees as an untyped getter. The metadata pass's `enter_accessor_property` dispatch exists, but it never fires because the `AccessorProperty` no longer exists by the time traversal reaches the class body. ## Fix Stop dropping the type annotation. In `lower_accessor_properties`: ```rust let decorators = std::mem::replace(&mut accessor.decorators, ctx.ast.vec()); let type_annotation = accessor.type_annotation.take(); ``` Thread `type_annotation` through `create_accessor_method` to the getter (setter passes `None`). To avoid a post-construction patch on the synthesized `MethodDefinition`, `create_class_method` now takes a `return_type: Option<ArenaBox<TSTypeAnnotation>>` parameter and threads it directly into the function's return-type slot. The other caller (`create_class_constructor_with_params`) passes `None`. The lowered AST is now self-consistent — the synth getter for `accessor x: T` reads as a getter that returns `T`, which is what it semantically is, and the existing getter-metadata path serializes it correctly. ## Out of scope (architectural limit) `type Uuid = string; @dec accessor x: Uuid` still emits `Object`, same as for non-accessor properties. Resolving type-alias references to their primitive constituent requires a name-based alias-resolution pass (the same one that `tsc`'s checker provides via `getTypeReferenceSerializationKind`). That's bug 1 of #21922 and a separate change from this fix; flagged here so reviewers don't mistake it for an omission. ## Test plan - [x] Conformance fixture `oxc/metadata/accessor` covers primitives, untyped (correctly stays `Object`), `string[]` → `Array`, `static accessor`, and computed-key (`@dec accessor ["computed"]: number`) - [x] `cargo test -p oxc_transformer` — 31 + 5 passed - [x] `cargo run -p oxc_transform_conformance -- --filter legacy-decorators` — 73 pass / 23 fail (baseline 72/24, +1 new fixture, **0 regressions**) - [x] `cargo run -p oxc_transform_conformance -- --exec` — accessor exec test verifies `Reflect.getMetadata` returns the correct constructor at runtime - [x] `cargo fmt -p oxc_transformer`
a733fec to
dd88726
Compare
camc314
added a commit
that referenced
this pull request
May 11, 2026
### 🚀 Features - 66c9b01 transformer/typescript: Debug_assert that `enum_eval` ran in semantic (#22252) (Dunqing) - ffe6475 minifier: Fold `Array` constructor with safe spreads (#22215) (camc314) ### 🐛 Bug Fixes - d3d0b18 traverse: Handle `ChainElement::TSNonNullExpression` in `GatherNodeParts` (#22247) (leaysgur) - 4e880de transformer/object-rest-spread: Declare temp vars for computed keys (#22284) (camc314) - a7c3e22 semantic: Clear member write target for computed keys (#22302) (camc314) - 6a8852d codegen: Emit newline after legal-comment orphan flush (#22304) (Dunqing) - 5da9fda transformer/explicit-resource-management: Preserve class names (#22306) (Dunqing) - b5d970f transformer/explicit-resource-management: Preserve class names (#22290) (camc314) - bc54fd4 minifier: Keep function / class names if direct eval is present in the scope (#22241) (sapphi-red) - 7a810c0 minifier: Refresh direct eval flags after DCE (#21787) (Dunqing) - dd88726 transformer/legacy-decorator: Preserve accessor type annotation for emitDecoratorMetadata (#21966) (Dunqing) - 29a3cd7 codegen: Swap mapping/indent order for top-level decls (#22206) (Dunqing) - 73b4f40 minifier: Preserve catch binding with direct eval (#22221) (camc314) - 0e13d17 minifier: Preserve optional chain base side effects (#22219) (camc314) - 0c7c01c transformer/typescript: Inline optional-chain enum member access (#21834) (Dunqing) - a6aff7e codegen: Emit block/array/object end mapping at close char (#22200) (Dunqing) - a099b03 codegen: Emit call end mapping at `)` position, not past it (#22199) (Dunqing) - 5753774 minifier: Cap if-return ternary collapse for firefox (#21841) (Gurupungav Narayanan) - 2493bdd codegen: Correct sourcemap end mappings for closing delimiters (#22001) (Mark Dalgleish) - 3b385e2 minifier: Bail optimizing `Array` with unknown arg count (#22188) (camc314) - 9fa2122 parser: Parse array computed class keys (#22159) (camc314) ### 📚 Documentation - a4a6892 napi/parser: Correct code comment (#22278) (overlookmotel) - 9305373 oxc: Update README (#22178) (camc314) Co-authored-by: Cameron <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes bug 7 of #21922.
The bug
@dec accessor x: Talways emitteddesign:type = Objectregardless ofT:Reflect.getMetadata("design:type", entity, "name")returnedObjectinstead ofString. Frameworks readingdesign:type(NestJS Swagger, class-validator, TypeORM column metadata) silently degraded for every typed accessor field.Cause
lower_accessor_properties(inenter_class) rewritesinto three members — a private storage field, a synthesized getter, and a synthesized setter — and transfers the decorators to the getter so the existing decorator pipeline picks them up. But it dropped the type annotation: the synth getter was constructed with
return_type: NONE.The metadata pass runs later and takes the getter branch:
return_typeisNonebecause lowering discarded it, soserialize_type_annotationcorrectly fell through toObjectfor what it sees as an untyped getter.The metadata pass's
enter_accessor_propertydispatch exists, but it never fires because theAccessorPropertyno longer exists by the time traversal reaches the class body.Fix
Stop dropping the type annotation. In
lower_accessor_properties:Thread
type_annotationthroughcreate_accessor_methodto the getter (setter passesNone). To avoid a post-construction patch on the synthesizedMethodDefinition,create_class_methodnow takes areturn_type: Option<ArenaBox<TSTypeAnnotation>>parameter and threads it directly into the function's return-type slot. The other caller (create_class_constructor_with_params) passesNone.The lowered AST is now self-consistent — the synth getter for
accessor x: Treads as a getter that returnsT, which is what it semantically is, and the existing getter-metadata path serializes it correctly.Out of scope (architectural limit)
type Uuid = string; @dec accessor x: Uuidstill emitsObject, same as for non-accessor properties. Resolving type-alias references to their primitive constituent requires a name-based alias-resolution pass (the same one thattsc's checker provides viagetTypeReferenceSerializationKind). That's bug 1 of #21922 and a separate change from this fix; flagged here so reviewers don't mistake it for an omission.Test plan
oxc/metadata/accessorcovers primitives, untyped (correctly staysObject),string[]→Array,static accessor, and computed-key (@dec accessor ["computed"]: number)cargo test -p oxc_transformer— 31 + 5 passedcargo run -p oxc_transform_conformance -- --filter legacy-decorators— 73 pass / 23 fail (baseline 72/24, +1 new fixture, 0 regressions)cargo run -p oxc_transform_conformance -- --exec— accessor exec test verifiesReflect.getMetadatareturns the correct constructor at runtimecargo fmt -p oxc_transformer