fix(minifier): refresh direct eval flags after DCE#21787
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
force-pushed
the
fix/minifier-compressor-idempotency
branch
from
fc0be6a to
d1c71e5
Compare
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
0eca4b1 to
9b1aadc
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
9b1aadc to
627e0ac
Compare
Dunqing
force-pushed
the
fix/minifier-compressor-idempotency
branch
from
d1c71e5 to
f5ad5f5
Compare
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
627e0ac to
1718603
Compare
Dunqing
force-pushed
the
fix/minifier-compressor-idempotency
branch
from
f5ad5f5 to
bb6bc86
Compare
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
1718603 to
28f2e93
Compare
Dunqing
force-pushed
the
fix/minifier-compressor-idempotency
branch
2 times, most recently
from
ead983e to
e2d329d
Compare
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
28f2e93 to
aacbb9f
Compare
Dunqing
force-pushed
the
fix/minifier-compressor-idempotency
branch
from
e2d329d to
f9554bb
Compare
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
2 times, most recently
from
f423d92 to
b7a5415
Compare
Dunqing
force-pushed
the
fix/minifier-compressor-idempotency
branch
from
f9554bb to
5e7520a
Compare
graphite-app
Bot
changed the base branch from
fix/minifier-compressor-idempotency
to
graphite-base/21787
camc314
approved these changes
May 7, 2026
Contributor
Merge activity
|
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
5e4f20f to
866155d
Compare
camc314
force-pushed
the
graphite-base/21787
branch
from
5e7520a to
24946be
Compare
sapphi-red
approved these changes
May 8, 2026
Dunqing
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
866155d to
45dd0cf
Compare
Stacked on #21645. ## Summary Fixes stale `DirectEval` scope flags after peephole passes remove a dead direct eval. ## Problem Semantic analysis marks scopes that contain direct eval. The minifier uses that flag conservatively: if a scope may contain direct eval, declarations in that scope cannot always be removed because eval may reference them dynamically. However, peephole compression can remove the direct eval itself: ```js function f(){if(false)eval('x');var x}f() ``` Before this fix, the AST no longer contained the `eval`, but the semantic scope still kept the stale `DirectEval` flag. That stale flag made declaration removal too conservative during the same minifier run. A fresh reparse did not have the stale flag, so a second minifier run could produce smaller output, which exposed the `monitor-oxc` idempotency failure. ## Fix - After a changed peephole pass, collect direct eval scope IDs from the live AST. - Refresh `DirectEval` flags in semantic scoping from that live set. - Keep `DirectEval` protection for scopes that still contain a live direct eval. - Remove stale `DirectEval` protection only for scopes whose direct eval was eliminated by earlier compression. ## Test Adds a minimal regression in `remove_unused_declaration.rs` using the existing `test_options` helper: ```js function f(){if(false)eval('x');var x}f() ``` The test verifies the dead eval no longer keeps `var x` alive in the same minifier run. ## Testing - `cargo test -p oxc_minifier remove_unused_declaration_after_dead_direct_eval`
graphite-app
Bot
force-pushed
the
fix/minifier-direct-eval-idempotency
branch
from
45dd0cf to
7a810c0
Compare
3 tasks
camc314
added a commit
that referenced
this pull request
May 11, 2026
### 🚀 Features - 66c9b01 transformer/typescript: Debug_assert that `enum_eval` ran in semantic (#22252) (Dunqing) - ffe6475 minifier: Fold `Array` constructor with safe spreads (#22215) (camc314) ### 🐛 Bug Fixes - d3d0b18 traverse: Handle `ChainElement::TSNonNullExpression` in `GatherNodeParts` (#22247) (leaysgur) - 4e880de transformer/object-rest-spread: Declare temp vars for computed keys (#22284) (camc314) - a7c3e22 semantic: Clear member write target for computed keys (#22302) (camc314) - 6a8852d codegen: Emit newline after legal-comment orphan flush (#22304) (Dunqing) - 5da9fda transformer/explicit-resource-management: Preserve class names (#22306) (Dunqing) - b5d970f transformer/explicit-resource-management: Preserve class names (#22290) (camc314) - bc54fd4 minifier: Keep function / class names if direct eval is present in the scope (#22241) (sapphi-red) - 7a810c0 minifier: Refresh direct eval flags after DCE (#21787) (Dunqing) - dd88726 transformer/legacy-decorator: Preserve accessor type annotation for emitDecoratorMetadata (#21966) (Dunqing) - 29a3cd7 codegen: Swap mapping/indent order for top-level decls (#22206) (Dunqing) - 73b4f40 minifier: Preserve catch binding with direct eval (#22221) (camc314) - 0e13d17 minifier: Preserve optional chain base side effects (#22219) (camc314) - 0c7c01c transformer/typescript: Inline optional-chain enum member access (#21834) (Dunqing) - a6aff7e codegen: Emit block/array/object end mapping at close char (#22200) (Dunqing) - a099b03 codegen: Emit call end mapping at `)` position, not past it (#22199) (Dunqing) - 5753774 minifier: Cap if-return ternary collapse for firefox (#21841) (Gurupungav Narayanan) - 2493bdd codegen: Correct sourcemap end mappings for closing delimiters (#22001) (Mark Dalgleish) - 3b385e2 minifier: Bail optimizing `Array` with unknown arg count (#22188) (camc314) - 9fa2122 parser: Parse array computed class keys (#22159) (camc314) ### 📚 Documentation - a4a6892 napi/parser: Correct code comment (#22278) (overlookmotel) - 9305373 oxc: Update README (#22178) (camc314) Co-authored-by: Cameron <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #21645.
Summary
Fixes stale
DirectEvalscope flags after peephole passes remove a dead direct eval.Problem
Semantic analysis marks scopes that contain direct eval. The minifier uses that flag conservatively: if a scope may contain direct eval, declarations in that scope cannot always be removed because eval may reference them dynamically.
However, peephole compression can remove the direct eval itself:
Before this fix, the AST no longer contained the
eval, but the semantic scope still kept the staleDirectEvalflag. That stale flag made declaration removal too conservative during the same minifier run. A fresh reparse did not have the stale flag, so a second minifier run could produce smaller output, which exposed themonitor-oxcidempotency failure.Fix
DirectEvalflags in semantic scoping from that live set.DirectEvalprotection for scopes that still contain a live direct eval.DirectEvalprotection only for scopes whose direct eval was eliminated by earlier compression.Test
Adds a minimal regression in
remove_unused_declaration.rsusing the existingtest_optionshelper:The test verifies the dead eval no longer keeps
var xalive in the same minifier run.Testing
cargo test -p oxc_minifier remove_unused_declaration_after_dead_direct_eval