refactor(allocator): rename EMPTY_CHUNK to EMPTY_CHUNK_FOOTER#21735
Merged
graphite-app[bot] merged 1 commit intoApr 24, 2026
Merged
Conversation
This was referenced Apr 24, 2026
Member
Author
This was referenced Apr 24, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
overlookmotel
marked this pull request as ready for review
April 24, 2026 19:53
overlookmotel
added
C-cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the allocator arena internals by renaming the canonical “empty chunk” static to better reflect that it represents a chunk footer, improving clarity in comments and call sites without changing behavior.
Changes:
- Renamed
EMPTY_CHUNKtoEMPTY_CHUNK_FOOTERinarenamodule internals. - Updated documentation and all internal references/imports in arena submodules to use the new name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_allocator/src/arena/mod.rs | Renames the canonical empty chunk static and updates related doc comments and is_empty() check. |
| crates/oxc_allocator/src/arena/from_raw_parts.rs | Updates internal import and initialization to reference EMPTY_CHUNK_FOOTER. |
| crates/oxc_allocator/src/arena/drop.rs | Updates internal import and reset() logic to use EMPTY_CHUNK_FOOTER. |
| crates/oxc_allocator/src/arena/create.rs | Updates internal import and constructors to use EMPTY_CHUNK_FOOTER. |
Contributor
Merge activity
|
…1735) Pure refactor. Rename this var to better reflect what it is.
graphite-app
Bot
force-pushed
the
om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_
branch
from
April 24, 2026 21:18
ceaa3c5 to
dfc2451
Compare
graphite-app
Bot
force-pushed
the
om/04-24-refactor_allocator_rename_empty_chunk_to_empty_chunk_footer_
branch
from
April 24, 2026 21:19
cbe7690 to
0c0831b
Compare
Base automatically changed from
om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_
to
main
April 24, 2026 21:26
graphite-app
Bot
deleted the
om/04-24-refactor_allocator_rename_empty_chunk_to_empty_chunk_footer_
branch
April 24, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Rename this var to better reflect what it is.