refactor(linter): extract reusable config discovery helper#21640
Merged
graphite-app[bot] merged 1 commit intoApr 22, 2026
Merged
Conversation
This was referenced Apr 22, 2026
Contributor
Author
This was referenced Apr 22, 2026
graphite-app
Bot
changed the base branch from
c/04-22-feat_linter_support_nested_vite_config_discovery
to
graphite-base/21640
April 22, 2026 16:13
graphite-app
Bot
force-pushed
the
c/04-22-refactor_linter_extract_reusable_config_discovery_helper
branch
from
April 22, 2026 16:24
dac94c8 to
e978e6a
Compare
graphite-app
Bot
force-pushed
the
graphite-base/21640
branch
from
April 22, 2026 16:24
1c7a595 to
63ec351
Compare
graphite-app
Bot
force-pushed
the
c/04-22-refactor_linter_extract_reusable_config_discovery_helper
branch
from
April 22, 2026 16:25
e978e6a to
2fc70db
Compare
camc314
force-pushed
the
c/04-22-refactor_linter_extract_reusable_config_discovery_helper
branch
2 times, most recently
from
April 22, 2026 16:34
4530ee7 to
ca4e3b0
Compare
camc314
marked this pull request as ready for review
April 22, 2026 16:38
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors oxlint’s configuration file discovery by extracting reusable discovery logic into a dedicated helper, and updates expected diagnostic output to match the new behavior.
Changes:
- Introduces
ConfigDiscovery+ConfigFileNamesto centralize config file matching and conflict detection. - Refactors
config_loaderto use the new helper for directory scanning and single-config selection. - Updates a fixture snapshot to reflect changed ordering in the conflict diagnostic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxlint/test/fixtures/js_config_nested_conflict/output.snap.md | Updates expected conflict message output order in the fixture snapshot. |
| apps/oxlint/src/config_loader.rs | Replaces inline config-discovery logic with calls to ConfigDiscovery (including unique-config selection). |
| apps/oxlint/src/config_discovery.rs | Adds reusable discovery structs and adjusts conflict message generation (test-only sorting). |
Contributor
Author
Merge activity
|
graphite-app
Bot
force-pushed
the
c/04-22-refactor_linter_extract_reusable_config_discovery_helper
branch
from
April 22, 2026 16:49
c371af9 to
9c4815f
Compare
graphite-app
Bot
deleted the
c/04-22-refactor_linter_extract_reusable_config_discovery_helper
branch
April 22, 2026 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.