Skip to content

feat(oxfmt): Use resolveConfig from vite-plus to load vite.config.ts#21603

Closed
leaysgur wants to merge 1 commit into
mainfrom
04-21-feat_oxfmt_use_resolveconfig_from_vite-plus_to_load_vite.config.ts
Closed

feat(oxfmt): Use resolveConfig from vite-plus to load vite.config.ts#21603
leaysgur wants to merge 1 commit into
mainfrom
04-21-feat_oxfmt_use_resolveconfig_from_vite-plus_to_load_vite.config.ts

Conversation

@leaysgur

@leaysgur leaysgur commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #21418

  • Add vite-plus to pnpm catalog
  • Use it devDeps for apps/oxfmt
  • Mark it as optional peerDeps for npm/oxfmt
  • Load vite.config.ts with resolveConfig from vite-plus

@leaysgur Graphite App

leaysgur commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title feat(oxfmt): Use resolveConfig from vite-plus to load vite.config.ts feat(oxfmt): Use resolveConfig from vite-plus to load vite.config.ts Apr 21, 2026
@leaysgur leaysgur force-pushed the 04-21-feat_oxfmt_use_resolveconfig_from_vite-plus_to_load_vite.config.ts branch 4 times, most recently from a21d3d4 to fdf072d Compare April 21, 2026 04:55
@leaysgur

leaysgur commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

@camc314 It would be best to branch off from this one for the Oxlint work. (And please merge whole stack after you finished)

@leaysgur leaysgur force-pushed the 04-21-feat_oxfmt_use_resolveconfig_from_vite-plus_to_load_vite.config.ts branch 2 times, most recently from 89afd27 to 3e79cfa Compare April 23, 2026 14:27
@leaysgur leaysgur force-pushed the 04-21-feat_oxfmt_use_resolveconfig_from_vite-plus_to_load_vite.config.ts branch from 3e79cfa to adfee1b Compare April 27, 2026 01:40
@camc314 camc314 added the A-formatter Area - Formatter label May 7, 2026
@leaysgur leaysgur mentioned this pull request May 15, 2026
Merged
@leaysgur

leaysgur commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Outdated, closed by #22454

@leaysgur leaysgur closed this May 18, 2026
@leaysgur leaysgur deleted the 04-21-feat_oxfmt_use_resolveconfig_from_vite-plus_to_load_vite.config.ts branch May 18, 2026 05:44
graphite-app Bot pushed a commit that referenced this pull request May 20, 2026
@leaysgur
feat(oxfmt): Support vite-plus/resolveConfig for vite.config.ts (#2…
16b8058 
…2454)

Closes #21603, fixes #21418

To simplify the review process, I'll first add support to Oxfmt.

In the next PR, I'll move that implementation to `shared`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

oxfmt: Support full vite.config.ts syntax

2 participants

@leaysgur @camc314