refactor(transformer): remove unused span parameter from helper_call/helper_call_expr#21579
Merged
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Dunqing
changed the base branch from
fix/transformer-helper-call-span-fix
to
graphite-base/21579
April 20, 2026 14:48
Dunqing
force-pushed
the
graphite-base/21579
branch
from
April 20, 2026 14:48
7bc49d6 to
ebec0b3
Compare
Dunqing
force-pushed
the
fix/transformer-helper-call-span
branch
from
April 20, 2026 14:48
3b50f61 to
1c4cb2d
Compare
Dunqing
changed the base branch from
graphite-base/21579
to
fix/transformer-helper-call-span-fix
April 20, 2026 14:48
Dunqing
marked this pull request as ready for review
April 20, 2026 15:59
Dunqing
marked this pull request as draft
April 21, 2026 07:10
Dunqing
marked this pull request as ready for review
April 22, 2026 09:27
Member
Author
Merge activity
|
graphite-app
Bot
changed the base branch from
fix/transformer-helper-call-span-fix
to
graphite-base/21579
April 22, 2026 09:32
graphite-app
Bot
force-pushed
the
graphite-base/21579
branch
from
April 22, 2026 09:43
ebec0b3 to
c92bd3b
Compare
graphite-app
Bot
force-pushed
the
fix/transformer-helper-call-span
branch
from
April 22, 2026 09:43
1c4cb2d to
53b13f8
Compare
graphite-app
Bot
force-pushed
the
fix/transformer-helper-call-span
branch
from
April 22, 2026 09:44
53b13f8 to
280ff0d
Compare
…helper_call_expr (#21579) ## Summary Follow-up to #21578. Since helper calls now always use `SPAN`, the `span` parameter is unnecessary. This removes it from `helper_call` and `helper_call_expr` and cleans up all 28 call sites across 12 files. Also removes now-unused `span` parameters from internal functions that only existed to pass through to helper calls: - `create_private_field_get` - `create_private_field_set` - `create_check_in_rhs` - `create_private_instance_init_assignment_not_loose` ## Test plan - `cargo build -p oxc_transformer` — no warnings (except pre-existing `oxc_allocator`) - `cargo test -p oxc_transformer` — all pass - `cargo run -p oxc_transform_conformance` — no snapshot changes
graphite-app
Bot
force-pushed
the
fix/transformer-helper-call-span
branch
from
April 22, 2026 09:56
62832f2 to
c3f71a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #21578. Since helper calls now always use
SPAN, thespanparameter is unnecessary. This removes it fromhelper_callandhelper_call_exprand cleans up all 28 call sites across 12 files.Also removes now-unused
spanparameters from internal functions that only existed to pass through to helper calls:create_private_field_getcreate_private_field_setcreate_check_in_rhscreate_private_instance_init_assignment_not_looseTest plan
cargo build -p oxc_transformer— no warnings (except pre-existingoxc_allocator)cargo test -p oxc_transformer— all passcargo run -p oxc_transform_conformance— no snapshot changes