refactor(linter): simplify `no-param-reassign` using `MemberWriteTarget` flag by Dunqing · Pull Request #21206 · oxc-project/oxc

Dunqing · 2026-04-09T05:14:39Z

Summary

Replace the 97-line is_modifying_property() ancestor-walking function with a single reference.flags().is_member_write_target() check
Now that MemberWriteTarget covers all property modification patterns (simple =, compound +=, update ++/--, delete), the manual ancestor walk is no longer needed

Depends on #21205.

Test plan

Existing no-param-reassign tests pass unchanged
just ready passes

🤖 Generated with Claude Code

Dunqing · 2026-04-09T05:14:53Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-04-09T05:21:25Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing refactor/no-param-reassign-member-write-target (bc7e404) with main (6dd061c)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Dunqing · 2026-04-10T03:20:36Z

Pure refactor

camc314 · 2026-04-13T08:27:01Z

Merge activity

Apr 13, 8:27 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 13, 8:27 AM UTC: camc314 added this pull request to the Graphite merge queue.
Apr 13, 8:36 AM UTC: Merged by the Graphite merge queue.

…et` flag (#21206) ## Summary - Replace the 97-line `is_modifying_property()` ancestor-walking function with a single `reference.flags().is_member_write_target()` check - Now that `MemberWriteTarget` covers all property modification patterns (simple `=`, compound `+=`, update `++/--`, `delete`), the manual ancestor walk is no longer needed Depends on #21205. ## Test plan - [x] Existing `no-param-reassign` tests pass unchanged - [x] `just ready` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Dunqing mentioned this pull request Apr 9, 2026

feat(semantic): extend MemberWriteTarget to cover all property modification patterns #21205

Merged

3 tasks

github-actions Bot added A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 9, 2026

Dunqing marked this pull request as ready for review April 9, 2026 05:15

Dunqing requested a review from camc314 as a code owner April 9, 2026 05:15

Dunqing force-pushed the feat/semantic-extend-member-write-target branch from a56bb73 to 327c2a5 Compare April 10, 2026 02:57

Dunqing force-pushed the refactor/no-param-reassign-member-write-target branch from 854aba9 to fc3807a Compare April 10, 2026 02:57

Dunqing changed the base branch from feat/semantic-extend-member-write-target to graphite-base/21206 April 10, 2026 03:04

Dunqing force-pushed the graphite-base/21206 branch from 327c2a5 to deb7c6d Compare April 10, 2026 03:04

Dunqing force-pushed the refactor/no-param-reassign-member-write-target branch from fc3807a to 27f6843 Compare April 10, 2026 03:04

Dunqing mentioned this pull request Apr 10, 2026

feat(semantic): extend MemberWriteTarget to cover all property modification patterns #21292

Closed

2 tasks

Dunqing force-pushed the graphite-base/21206 branch from deb7c6d to 327c2a5 Compare April 10, 2026 03:11

Dunqing force-pushed the refactor/no-param-reassign-member-write-target branch from 27f6843 to 3f3268f Compare April 10, 2026 03:11

Dunqing force-pushed the graphite-base/21206 branch from 327c2a5 to 20c48c5 Compare April 10, 2026 03:14

Dunqing force-pushed the refactor/no-param-reassign-member-write-target branch from 3f3268f to e205db9 Compare April 10, 2026 03:14

Dunqing changed the base branch from graphite-base/21206 to feat/semantic-extend-member-write-target April 10, 2026 03:14

Dunqing force-pushed the refactor/no-param-reassign-member-write-target branch from e205db9 to 60463f2 Compare April 10, 2026 03:23

Dunqing force-pushed the feat/semantic-extend-member-write-target branch from 20c48c5 to 30c2301 Compare April 10, 2026 03:23

Dunqing force-pushed the refactor/no-param-reassign-member-write-target branch from 60463f2 to 006c9be Compare April 10, 2026 03:24

Dunqing force-pushed the feat/semantic-extend-member-write-target branch from 30c2301 to 3560adb Compare April 10, 2026 03:24

graphite-app Bot changed the base branch from feat/semantic-extend-member-write-target to graphite-base/21206 April 11, 2026 14:31

graphite-app Bot force-pushed the refactor/no-param-reassign-member-write-target branch from 006c9be to 428d19e Compare April 11, 2026 14:36

graphite-app Bot force-pushed the graphite-base/21206 branch from 3560adb to 6dd061c Compare April 11, 2026 14:36

graphite-app Bot changed the base branch from graphite-base/21206 to main April 11, 2026 14:37

graphite-app Bot force-pushed the refactor/no-param-reassign-member-write-target branch from 428d19e to bc7e404 Compare April 11, 2026 14:37

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026

camc314 self-assigned this Apr 13, 2026

graphite-app Bot force-pushed the refactor/no-param-reassign-member-write-target branch from bc7e404 to 4cf38dd Compare April 13, 2026 08:33

graphite-app Bot merged commit 4cf38dd into main Apr 13, 2026
26 checks passed

graphite-app Bot deleted the refactor/no-param-reassign-member-write-target branch April 13, 2026 08:36

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter): simplify `no-param-reassign` using `MemberWriteTarget` flag#21206

refactor(linter): simplify `no-param-reassign` using `MemberWriteTarget` flag#21206
graphite-app[bot] merged 1 commit into
mainfrom
refactor/no-param-reassign-member-write-target

Dunqing commented Apr 9, 2026 •

edited

Loading

Uh oh!

Dunqing commented Apr 9, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Dunqing commented Apr 10, 2026

Uh oh!

camc314 commented Apr 13, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Dunqing commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Dunqing commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Dunqing commented Apr 10, 2026

Uh oh!

camc314 commented Apr 13, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dunqing commented Apr 9, 2026 •

edited

Loading

Dunqing commented Apr 9, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 9, 2026 •

edited

Loading

camc314 commented Apr 13, 2026 •

edited by graphite-app Bot

Loading