refactor(napi/parser, linter/plugins): add int32 buffer view#21131
Merged
graphite-app[bot] merged 1 commit intoApr 7, 2026
Merged
Conversation
This was referenced Apr 7, 2026
Member
Author
github-actions
Bot
added
A-linter
github-actions
Bot
added
the
C-cleanup
This was referenced Apr 7, 2026
overlookmotel
marked this pull request as ready for review
April 7, 2026 15:48
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Int32Array view (int32) to the raw-transfer Uint8Array buffer shape so deserializers and linter/parser plumbing can access signed 32-bit values without reinterpreting uint32.
Changes:
- Extend raw-transfer buffer construction to attach
buffer.int32alongsideuint32/float64. - Update generated TypeScript declarations (parser + oxlint) to include
int32inBufferWithArrays. - Update the raw-transfer generator template to wire up the
int32view in generated deserializers.
Reviewed changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tasks/ast_tools/src/generators/raw_transfer.rs | Updates generator prelude + emitted .d.ts buffer types to include int32. |
| napi/parser/src-js/raw-transfer/common.js | Attaches int32 view when creating parser raw-transfer buffers. |
| napi/parser/src-js/generated/deserialize/*.d.ts | Updates parser deserializer buffer type to require int32. |
| apps/oxlint/src-js/plugins/types.ts | Extends BufferWithArrays interface with int32. |
| apps/oxlint/src-js/plugins/lint.ts | Ensures incoming buffers get an int32 view attached before use. |
| apps/oxlint/src-js/package/parse.ts | Attaches int32 view when creating the RuleTester raw-transfer buffer. |
| apps/oxlint/src-js/generated/deserialize.d.ts | Updates oxlint deserializer buffer type to require int32. |
overlookmotel
force-pushed
the
om/04-07-refactor_napi_parser_linter_plugins_add_int32_buffer_view
branch
from
April 7, 2026 16:27
35ececf to
73f8ddd
Compare
overlookmotel
force-pushed
the
om/04-07-docs_linter_plugins_correct_comments
branch
from
April 7, 2026 16:27
0b2c4b6 to
19478f6
Compare
graphite-app
Bot
force-pushed
the
om/04-07-docs_linter_plugins_correct_comments
branch
2 times, most recently
from
April 7, 2026 17:16
6ee47c0 to
81781ed
Compare
graphite-app
Bot
force-pushed
the
om/04-07-refactor_napi_parser_linter_plugins_add_int32_buffer_view
branch
from
April 7, 2026 17:17
73f8ddd to
ca49dcb
Compare
Contributor
Merge activity
|
Add an `Int32Array` view of the buffer for raw transfer. It will be used in PRs later in this stack.
graphite-app
Bot
force-pushed
the
om/04-07-docs_linter_plugins_correct_comments
branch
from
April 7, 2026 17:25
81781ed to
305350d
Compare
graphite-app
Bot
force-pushed
the
om/04-07-refactor_napi_parser_linter_plugins_add_int32_buffer_view
branch
from
April 7, 2026 17:26
ca49dcb to
c70a8e9
Compare
Base automatically changed from
om/04-07-docs_linter_plugins_correct_comments
to
main
April 7, 2026 17:29
graphite-app
Bot
deleted the
om/04-07-refactor_napi_parser_linter_plugins_add_int32_buffer_view
branch
April 7, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
Int32Arrayview of the buffer for raw transfer. It will be used in PRs later in this stack.