perf(ast_tools): introduce StructsMut iterator and use it where possible#20949
Merged
graphite-app[bot] merged 1 commit intoApr 1, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
A-ast-tools
overlookmotel
marked this pull request as ready for review
April 1, 2026 20:20
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves ast_tools generator performance by adding a mutable iterator that walks only AST structs (and stops once non-AST types begin), avoiding repeated full-schema scans.
Changes:
- Added
Schema::structs_mut()and a newStructsMutiterator to yield&mut StructDefefficiently. - Updated
AstKindGenerator::prepareto usestructs_mut()instead of iterating allschema.types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/ast_tools/src/schema/mod.rs | Introduces StructsMut and Schema::structs_mut() for efficient mutable iteration over AST structs with early termination. |
| tasks/ast_tools/src/generators/ast_kind.rs | Uses schema.structs_mut() to set has_kind only on structs, avoiding scanning all type defs. |
Member
Author
Merge activity
|
graphite-app
Bot
force-pushed
the
om/04-01-perf_ast_tools_introduce_structsmut_iterator_and_use_it_where_possible
branch
from
April 1, 2026 20:28
d8a5101 to
2ac7527
Compare
graphite-app
Bot
deleted the
om/04-01-perf_ast_tools_introduce_structsmut_iterator_and_use_it_where_possible
branch
April 1, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #20943. Introduce a
StructsMutiterator, which is more efficient than iterating through all types.