feat(linter)!: report error on unknown builtin rule by camc314 · Pull Request #20464 · oxc-project/oxc

camc314 · 2026-03-17T16:46:06Z

No description provided.

camc314 · 2026-03-17T16:46:20Z

feat(linter)!: report error on unknown builtin rule #20464 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR makes oxlint configs fail fast when referencing an unknown builtin rule, while preserving prior behavior of ignoring rules that are known but unavailable due to a disabled plugin.

Changes:

Added a new OverrideRulesError::RuleNotFound and surfaced it when a builtin rule key cannot be resolved.
Preserved the “ignore if plugin disabled” behavior for known builtin rules, even when not available in the active rule set.
Added unit/integration tests plus CLI fixtures & snapshots for missing builtin rule errors across JSON and JS/TS config paths.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/config/rules.rs	Introduces `RuleNotFound`, emits it for unknown builtin rules, and adds tests for disabled-plugin behavior.
crates/oxc_linter/src/config/config_builder.rs	Updates build error docs and adds tests that validate unknown builtin rules error in root/overrides.
apps/oxlint/test/fixtures/js_config_dynamic_missing_builtin_rule/oxlint.config.ts	Adds a JS-config fixture that references a missing builtin rule.
apps/oxlint/test/fixtures/js_config_dynamic_missing_builtin_rule/output.snap.md	Adds expected CLI output snapshot for the JS-config missing-rule fixture.
apps/oxlint/src/snapshots/[email protected]	Adds CLI snapshot for invalid `.oxlintrc.json` missing rule fixture.
apps/oxlint/src/lint.rs	Adds a snapshot test case for the new CLI fixture.
apps/oxlint/src/config_loader.rs	Adds NAPI-path test coverage ensuring JS/TS root config rejects missing builtin rules.
apps/oxlint/fixtures/cli/invalid_config_missing_builtin_rule/.oxlintrc.json	Adds a JSON config fixture that references a missing builtin rule.

You can also share your feedback on Copilot code review. Take the survey.

crates/oxc_linter/src/config/rules.rs

crates/oxc_linter/src/config/config_builder.rs

codspeed-hq · 2026-03-17T16:52:46Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

_{Comparing c/03-17-feat_linter_report_error_on_unknown_builtin_rule (f516bb2) with main (43f4827)}

52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

connorshea · 2026-03-18T03:33:43Z

I would call this out as a breaking change in the changelog, but otherwise I am a big fan of this

camc314 · 2026-03-25T21:42:18Z

Merge activity

Mar 25, 9:42 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 25, 9:42 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 25, 9:50 PM UTC: Merged by the Graphite merge queue.

# Oxlint ### 💥 BREAKING CHANGES - c0ebbce linter: [**BREAKING**] Report error on unknown builtin rule (#20464) (camc314) ### 🚀 Features - 04f85e5 linter/no-unused-vars: Add safe-fix option for import fixes (#20839) (Marcell Toth) - 32a3706 linter/eslint-vitest-plugin: Implements `require-test-timeout` rule (#20806) (Said Atrahouch) - ae03653 linter: Implement suggestion for `eslint/no-useless-computed-key` rule (#20805) (Mikhail Baev) - 6624513 linter/prefer-string-starts-ends-with: Move rule from nursery to style (#20797) (camc314) - 58941f8 linter/prefer-readonly: Move rule from nursery to style (#20796) (camc314) - 8837ffd linter/prefer-regexp-exec: Move rule from nursery to style (#20795) (camc314) - 7e88871 linter/prefer-find: Move rule out of nursery (#20794) (camc314) - ca6e5bc linter/vitest: Implement prefer-called-exactly-once-with (#17562) (Said Atrahouch) - e80c0bf linter/eslint-plugin-vitest: Implement `require-mock-type-parameters` (#20785) (Said Atrahouch) - cec8b8f linter/vitest: Implement require-awaited-expect-poll rule (#20702) (Said Atrahouch) - d8e9d01 linter/eslint-plugin-vitest: Set `prefer-to-have-been-called-times` compatible with jest (#20703) (Said Atrahouch) - caf8231 linter: Enhance import plugin diagnostics with help messages (#20766) (离谱) - f44adfa linter: Improve the oxlint config generated by `--init`. (#20632) (connorshea) - 43f4827 linter: Add help text to jest and promise diagnostics (#20640) (kszongic) - 16516de linter: Enhance types for `DummyRule` (#20751) (camc314) - 27374e8 linter: Add hint about node version when ts config fail to import (#20570) (camc314) - 8e34150 linter/eslint-plugin-vitest: Sync rule with JS implementation (#20679) (Said Atrahouch) ### 🐛 Bug Fixes - df057d5 linter/no-noninteractive-tabindex: Add missing composite widget … (#20860) (bab) - bb34073 linter: Mark vitest/valid-title as a compatible jest rules (#20463) (Nicolas Le Cam) - bd2c76b linter: Handle shadowed locals in no-restricted-globals (#20811) (Ulrich Stark) - 62e39be linter: Sort nested object keys in fix of `eslint/sort-keys` in one pass (#20838) (Ulrich Stark) - 3ef37da oxlint/lsp: Error on unknown command (#20841) (Sysix) - ab1070d oxlint/cli: Skip parsing base config again for nested config search (#20809) (Sysix) - 2be3728 oxlint/lsp: Skip parsing base config again for nested config search (#20808) (Sysix) - 6171217 oxlint: Respect `NO_COLOR` env for `format=stylish` (#20804) (Sysix) - d89ae8f linter/plugins: Patch `WeakMap` to emulate `WeakMap`s keyed by `sourceCode` (#20799) (overlookmotel) - c610666 linter/no-shadow: Respect env settings when builtinGlobals is enabled (#20429) (vvnikita74) - 6bb502f linter/no-invalid-void-type: Allow void generic args in heritage clauses (#20780) (camc314) - 365bb7d linter: Skip typed nested literals in explicit-module-boundary-types (#20776) (camc314) - 0aa1ff0 linter/plugins: Ensure `after` hook is always called in ESLint compat mode (#20721) (overlookmotel) - 31145a9 linter/plugins: Fire `after` hook after CFG events in ESLint compat (#20720) (overlookmotel) - c09a5ab diagnostics: Skip minified fallback for single-line reporters (#20716) (camc314) - e4dc9a1 linter: Isolate `--init` config writes from parallel tests (#20717) (camc314) - 7e394ec linter: Clarify empty replacement fixer help text (#20698) (camc314) - d15a99c linter/jsx-curly-brace-presence: Flag empty string literals (#20690) (camc314) ### 📚 Documentation - c722495 linter: Update JS Plugins + LS references (#20843) (camc314) - e1f9748 linter/jsdoc/require-property: Fix typo (#20792) (Benjaming61001) - be3dcc1 linter: Add note about node version + custom TS plugin (#19381) (camc314) # Oxfmt ### 🚀 Features - 6ef440a oxfmt: Support bool for object style options (#20853) (leaysgur) - 23050fa oxfmt: Support markdown-in-js substitution (#20683) (leaysgur) - 4087295 oxfmt: Support angular-in-js substitution (#20676) (leaysgur)

camc314 marked this pull request as ready for review March 17, 2026 16:46

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Mar 17, 2026

Copilot AI review requested due to automatic review settings March 17, 2026 16:46

github-actions bot added the C-enhancement Category - New feature or request label Mar 17, 2026

camc314 self-assigned this Mar 17, 2026

Copilot started reviewing on behalf of camc314 March 17, 2026 16:46 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

crates/oxc_linter/src/config/rules.rs Show resolved Hide resolved

crates/oxc_linter/src/config/rules.rs Show resolved Hide resolved

crates/oxc_linter/src/config/config_builder.rs Show resolved Hide resolved

camc314 force-pushed the c/03-17-feat_linter_report_error_on_unknown_builtin_rule branch from 265aec4 to 59d1786 Compare March 18, 2026 09:04

camc314 force-pushed the c/03-17-feat_linter_report_error_on_unknown_builtin_rule branch from 59d1786 to fa337fd Compare March 25, 2026 21:32

camc314 changed the title ~~feat(linter): report error on unknown builtin rule~~ ffat(linter)!: report error on unknown builtin rule Mar 25, 2026

camc314 changed the title ~~ffat(linter)!: report error on unknown builtin rule~~ feat(linter)!: report error on unknown builtin rule Mar 25, 2026

camc314 force-pushed the c/03-17-feat_linter_report_error_on_unknown_builtin_rule branch 2 times, most recently from 208be3e to f516bb2 Compare March 25, 2026 21:37

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026

feat(linter)!: report error on unknown builtin rule (#20464)

c0ebbce

graphite-app bot force-pushed the c/03-17-feat_linter_report_error_on_unknown_builtin_rule branch from f516bb2 to c0ebbce Compare March 25, 2026 21:47

graphite-app bot merged commit c0ebbce into main Mar 25, 2026
26 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026

graphite-app bot deleted the c/03-17-feat_linter_report_error_on_unknown_builtin_rule branch March 25, 2026 21:50

Boshen mentioned this pull request Mar 30, 2026

release(apps): oxlint v1.58.0 && oxfmt v0.43.0 #20867

Merged

navin-moorthy mentioned this pull request Mar 31, 2026

oxlint 1.58.0 compatibility: config fails on removed/unknown rules haydenbleasel/ultracite#635

Closed

camc314 mentioned this pull request Mar 31, 2026

linter: Parse configuration fails because of missing rules in vue plugin #20895

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter)!: report error on unknown builtin rule#20464

feat(linter)!: report error on unknown builtin rule#20464
graphite-app[bot] merged 1 commit intomainfrom
c/03-17-feat_linter_report_error_on_unknown_builtin_rule

camc314 commented Mar 17, 2026

Uh oh!

camc314 commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

connorshea commented Mar 18, 2026

Uh oh!

camc314 commented Mar 25, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Mar 17, 2026

Uh oh!

camc314 commented Mar 17, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

connorshea commented Mar 18, 2026

Uh oh!

camc314 commented Mar 25, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Mar 17, 2026 •

edited

Loading

camc314 commented Mar 25, 2026 •

edited by graphite-app bot

Loading