refactor(estree/tokens): move logic for excluding legacy identifiers into visitor#19720
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 25, 2026
Conversation
This was referenced Feb 25, 2026
This was referenced Feb 25, 2026
Member
Author
Merging this PR will not alter performance
Comparing Footnotes
|
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor.
ESTree tokens serialization has to determine whether a keyword token
let,yield, orstaticshould be aKeywordorIdentifiertoken in ESTree tokens. The behavior is different between Espree and TS-ESLint (Espree's behavior is bizarre, but hey!).Move the code which makes this decision from the 2nd pass loop into the 1st pass visitor.
This is part of an effort to move all logic out of the 2nd pass loop, in order to eventually remove the 2nd pass alltogther.