refactor(estree/tokens): replace stored token when re-lexing#19698
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
This was referenced Feb 25, 2026
Member
Author
Merging this PR will not alter performance
Comparing Footnotes
|
1eac4b3 to
7233548
Compare
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously the ESTree tokens serializer had a special case to skip a
<<token which has same start as preceding<token. Instead, solve this problem at source - prevent this duplicate token from being in theVec<Token>in the first place, by modifying the parser.This is important because we want to move to sending tokens to JS via raw transfer, and we need the
Vec<Token>to have the right number of tokens in it to start with, so we can do lazy deserialization and just get a token at a specific index. This breaks down if there are extra tokens that need to be skipped.The logic around this in parser is quite labyrinthine, so add lengthy comments explaining it.
This change also simplifies the main loop in ESTree serializer, so has side effect of +1% on
estree_tokensbenchmark. Conversely, it doesn't affect theparser_tokensbenchmark perf, because the path in parser which got more complex is not commonly taken.