test(oxlint/lsp): add test for .oxlintrc.json config change#19552
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Sysix
force-pushed
the
02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change
branch
from
58b6c00 to
f369f67
Compare
Sysix
changed the title
.oxlintrc.json serverity change.oxlintrc.json config change
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an LSP regression test to verify diagnostics are refreshed after configuration file content changes (e.g. .oxlintrc.json / oxlint.config.ts) by simulating workspace/didChangeWatchedFiles and waiting for a diagnostic refresh.
Changes:
- Extend the LSP test client helper with
didChangeWatchedFiles()and aworkspace/diagnostic/refreshwaiter. - Add a new
file_config_changeVitest suite with fixtures and snapshots for config-change scenarios. - Introduce fixtures for both
.oxlintrc.json-based config andoxlint.config.ts-based config.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| apps/oxlint/test/lsp/utils.ts | Adds test utilities to simulate watched-file changes and await diagnostic refresh, plus a helper to snapshot diagnostics before/after a config content change. |
| apps/oxlint/test/lsp/file_config_change/file_config_change.test.ts | New test suite covering diagnostics behavior across config changes. |
| apps/oxlint/test/lsp/file_config_change/snapshots/file_config_change.test.ts.snap | Snapshots for the new config-change test suite. |
| apps/oxlint/test/lsp/file_config_change/fixtures/** | New fixtures representing config files and lint targets used by the test. |
Sysix
force-pushed
the
02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change
branch
from
f369f67 to
35e48ce
Compare
camc314
approved these changes
Feb 20, 2026
Contributor
Merge activity
|
> Adds an LSP regression test to verify diagnostics are refreshed after configuration file content changes (e.g. .oxlintrc.json / oxlint.config.ts) by simulating workspace/didChangeWatchedFiles and waiting for a diagnostic refresh. This shows the error for #19526 where the config is not refreshed and still shows an error. This is fixed in the downstream PR
graphite-app
bot
force-pushed
the
02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change
branch
from
35e48ce to
ad43ccc
Compare
graphite-app
bot
deleted the
02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows the error for #19526 where the config is not refreshed and still shows an error. This is fixed in the downstream PR