Skip to content

refactor(linter/preserve-caught-error): use IdentifierReference::reference_id over cell access#19493

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess
Feb 17, 2026
Merged

refactor(linter/preserve-caught-error): use IdentifierReference::reference_id over cell access#19493
graphite-app[bot] merged 1 commit intomainfrom
c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 17, 2026

No description provided.

This was referenced Feb 17, 2026
Merged
Merged
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Feb 17, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 17, 2026
This was referenced Feb 17, 2026
Merged
Merged
@camc314 camc314 marked this pull request as ready for review February 17, 2026 13:25
Copilot AI review requested due to automatic review settings February 17, 2026 13:25
@camc314 camc314 changed the title refactor(linter/preserve-caught-error): use IdentifierReference::reference_id over cell acess refactor(linter/preserve-caught-error): use IdentifierReference::reference_id over cell access Feb 17, 2026
Copilot AI reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the preserve-caught-error linter rule to simplify code by using the IdentifierReference::reference_id() method instead of manually accessing the reference_id cell and checking for None.

Changes:

  • Replaced manual cell access ident.reference_id.get() with method call ident.reference_id()
  • Removed explicit None check that was previously returning false
  • Simplified the code from 4 lines to 1 line

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess (01ed3da) with main (735d0e4)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess (4be0ba0) during the generation of this report, so main (735d0e4) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 17, 2026 •
edited
Loading

Merge activity

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
@camc314 camc314 force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 01ed3da to 33e1db7 Compare February 17, 2026 13:48
@camc314 camc314 force-pushed the c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess branch from 4be0ba0 to 8f659ba Compare February 17, 2026 13:48
@graphite-app graphite-app bot changed the base branch from c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess to graphite-base/19493 February 17, 2026 14:00
@camc314 camc314 force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 33e1db7 to 71067ff Compare February 17, 2026 16:35
@camc314 camc314 force-pushed the graphite-base/19493 branch from 8f659ba to 296a62c Compare February 17, 2026 16:35
@camc314 camc314 changed the base branch from graphite-base/19493 to c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess February 17, 2026 16:35
@graphite-app graphite-app bot changed the base branch from c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess to graphite-base/19493 February 17, 2026 16:52
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 71067ff to 7bad5a4 Compare February 17, 2026 16:58
@graphite-app graphite-app bot force-pushed the graphite-base/19493 branch from 296a62c to fbcbb45 Compare February 17, 2026 16:58
@graphite-app graphite-app bot changed the base branch from graphite-base/19493 to main February 17, 2026 16:59
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 7bad5a4 to 9bc4658 Compare February 17, 2026 16:59
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 9bc4658 to 36bf284 Compare February 17, 2026 17:06
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
@camc314 camc314 self-assigned this Feb 17, 2026
@graphite-app graphite-app bot merged commit 36bf284 into main Feb 17, 2026
21 checks passed
@graphite-app graphite-app bot deleted the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch February 17, 2026 17:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314

Comments