feat(formatter/sort_imports)!: Report invalid group name with renaming `side-effect` > `side_effect` by leaysgur · Pull Request #19416 · oxc-project/oxc

leaysgur · 2026-02-16T02:05:17Z

Breaking: Rename ambiguous modifier/selector names
- side-effect → side_effect
- side-effect-style → side_effect_style
- Now - is used only for joiner (modifier-modifier-selector)
  - before: value-side-effect-style 🆚 after: value-side_effect_style
Breaking: Add config-time validation for invalid group names
- previously silently ignored...
- or wrongly applied (and user didn't notice)

leaysgur · 2026-02-16T02:05:31Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR updates the sort-imports configuration model to remove selector/modifier name ambiguity, introduces config-time validation for unknown group names, and renames the side-effect* selector/modifier strings to side_effect*.

Changes:

Breaking rename of selector/modifier names: side-effect → side_effect, side-effect-style → side_effect_style (docs, schema, and tests updated).
SortImportsOptions.groups is now parsed into a structured GroupEntry (predefined/custom/unknown) instead of raw strings.
oxfmtrc parsing now errors on unknown groups entries instead of silently ignoring them.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tasks/website_formatter/src/snapshots/schema_markdown.snap	Updates documented selector/modifier possible values to the new `side_effect*` names.
tasks/website_formatter/src/snapshots/schema_json.snap	Updates schema JSON snapshot descriptions to reflect renamed selector/modifier values.
npm/oxfmt/configuration_schema.json	Updates published configuration schema docs for renamed selector/modifier values.
crates/oxc_formatter/tests/ir_transform/sort_imports/groups.rs	Updates test configs to use the new group names (`side_effect*`).
crates/oxc_formatter/tests/ir_transform/sort_imports/custom_groups.rs	Updates custom-group test configs to use the new group names (`side_effect*`).
crates/oxc_formatter/tests/ir_transform/mod.rs	Adjusts test config parsing to produce `GroupEntry` instead of strings.
crates/oxc_formatter/src/ir_transform/sort_imports/options.rs	Changes `groups` type to `Vec<Vec<GroupEntry>>` and updates defaults accordingly.
crates/oxc_formatter/src/ir_transform/sort_imports/group_matcher.rs	Updates matcher to consume `GroupEntry` and map custom/predefined/unknown correctly.
crates/oxc_formatter/src/ir_transform/sort_imports/group_config.rs	Introduces `GroupEntry` and simplifies `GroupName::parse` by splitting on `-`.
apps/oxfmt/src/core/oxfmtrc.rs	Parses `groups` into `GroupEntry` with validation for unknown group names; updates docs for renamed values.

crates/oxc_formatter/tests/ir_transform/mod.rs

apps/oxfmt/src/core/oxfmtrc.rs

crates/oxc_formatter/src/ir_transform/sort_imports/group_config.rs

codspeed-hq · 2026-02-16T02:12:49Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity (abd9424) with main (5f705e7)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

graphite-app · 2026-02-16T05:04:35Z

Merge activity

Feb 16, 5:04 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Feb 16, 5:11 AM UTC: Merged by the Graphite merge queue.

…g `side-effect` > `side_effect` (#19416) - Breaking: Rename ambiguous modifier/selector names - `side-effect` → `side_effect` - `side-effect-style` → `side_effect_style` - Now `-` is used only for joiner (`modifier-modifier-selector`) - before: `value-side-effect-style` 🆚 after: `value-side_effect_style` - Breaking: Add config-time validation for invalid group names - previously silently ignored... - or wrongly applied (and user didn't notice)

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

Jungzl · 2026-02-16T15:24:25Z

apps/oxfmt/src/core/oxfmtrc.rs

+                                    GroupEntry::Predefined(group_name)
+                                } else {
+                                    return Err(format!(
+                                        "Invalid `sortImports` configuration: unknown group name `{name}` in `groups`"


I just updated to the latest oxfmt and got this error message. After checking the documentation, I found it still uses kebab case notation, which confused me. I eventually found my way here.
I think adding , use xx_xx instead. might make it clearer.

Sorry, docs are outdated, I will update today.

…g `side-effect` > `side_effect` (oxc-project#19416) - Breaking: Rename ambiguous modifier/selector names - `side-effect` → `side_effect` - `side-effect-style` → `side_effect_style` - Now `-` is used only for joiner (`modifier-modifier-selector`) - before: `value-side-effect-style` 🆚 after: `value-side_effect_style` - Breaking: Add config-time validation for invalid group names - previously silently ignored... - or wrongly applied (and user didn't notice)

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (oxc-project#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (oxc-project#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (oxc-project#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (oxc-project#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (oxc-project#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (oxc-project#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (oxc-project#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (oxc-project#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (oxc-project#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (oxc-project#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (oxc-project#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (oxc-project#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (oxc-project#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (oxc-project#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (oxc-project#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (oxc-project#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (oxc-project#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (oxc-project#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (oxc-project#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (oxc-project#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (oxc-project#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (oxc-project#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (oxc-project#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (oxc-project#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (oxc-project#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (oxc-project#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (oxc-project#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (oxc-project#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (oxc-project#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (oxc-project#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (oxc-project#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (oxc-project#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (oxc-project#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (oxc-project#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (oxc-project#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (oxc-project#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (oxc-project#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (oxc-project#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (oxc-project#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (oxc-project#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red)

leaysgur requested a review from Dunqing as a code owner February 16, 2026 02:05

Copilot AI review requested due to automatic review settings February 16, 2026 02:05

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Feb 16, 2026

Copilot started reviewing on behalf of leaysgur February 16, 2026 02:05 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

leaysgur force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch from 6cacaeb to 91232e6 Compare February 16, 2026 02:11

leaysgur mentioned this pull request Feb 16, 2026

refactor(formatter,oxfmt): Simplify sort_imports options parsing #19418

Merged

leaysgur force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch 3 times, most recently from 4635829 to abd9424 Compare February 16, 2026 03:48

leaysgur changed the title ~~feat(formatter/sort_imports)!: Report invalid group name with removing selector and modifier ambiguity~~ feat(formatter/sort_imports)!: Report invalid group name with renaming side-effect > side_effect Feb 16, 2026

This was referenced Feb 16, 2026

refactor(oxfmt): Remove redundant error message #19421

Merged

feat(playground): Support more sort-imports options #19424

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 16, 2026

graphite-app bot force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch from abd9424 to 9c34f72 Compare February 16, 2026 05:05

graphite-app bot merged commit 9c34f72 into main Feb 16, 2026
21 checks passed

graphite-app bot deleted the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch February 16, 2026 05:11

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 16, 2026

Boshen mentioned this pull request Feb 16, 2026

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

Jungzl reviewed Feb 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(formatter/sort_imports)!: Report invalid group name with renaming `side-effect` > `side_effect`#19416

feat(formatter/sort_imports)!: Report invalid group name with renaming `side-effect` > `side_effect`#19416
graphite-app[bot] merged 1 commit intomainfrom
02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity

leaysgur commented Feb 16, 2026 •

edited

Loading

Uh oh!

leaysgur commented Feb 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Jungzl Feb 16, 2026

Uh oh!

leaysgur Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

leaysgur commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Jungzl Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

leaysgur Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

leaysgur commented Feb 16, 2026 •

edited

Loading

leaysgur commented Feb 16, 2026 •

edited

Loading

codspeed-hq bot commented Feb 16, 2026 •

edited

Loading

graphite-app bot commented Feb 16, 2026 •

edited

Loading