feat(oxlint)!: `no-shadow-restricted-names` report `globalThis` by default by Sysix · Pull Request #19407 · oxc-project/oxc

Sysix · 2026-02-15T18:52:42Z

upstream PR: eslint/eslint#20027

found here: https://github.com/oxc-project/eslint-plugin-oxlint/actions/runs/22040552727/job/63680629647?pr=632

updated the test via just new-rule no-shadow-restricted-names, there is a simpler command, but it works :)

note: this is a default rule in oxlint: https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-shadow-restricted-names.html

Sysix · 2026-02-15T18:52:55Z

feat(oxlint)!: no-shadow-restricted-names report globalThis by default #19407 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-15T18:57:48Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing 02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default (2111a69) with main (88d0548)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

This PR aligns eslint/no-shadow-restricted-names behavior with upstream ESLint by reporting globalThis shadowing by default (while still allowing it to be disabled via config).

Changes:

Changed reportGlobalThis default to true via a custom Default impl on NoShadowRestrictedNamesConfig.
Updated rule docs/examples to include globalThis.
Updated rule tests and refreshed the corresponding snapshot output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs	Enables `globalThis` reporting by default and updates tests/docs accordingly.
crates/oxc_linter/src/snapshots/eslint_no_shadow_restricted_names.snap	Updates snapshot output to match the new default behavior and test set.

Comments suppressed due to low confidence (1)

crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs:175

The test removed the simple failing cases (var undefined = 5;, function NaN(){}, try {} catch(eval){}), which reduces coverage for the basic forms this rule is expected to catch. Consider adding these back (even if you keep the more complex cases) so regressions in the simplest patterns are still detected.

    let fail = vec![
        ("function NaN(NaN) { var NaN; !function NaN(NaN) { try {} catch(NaN) {} }; }", None),
        (
            "function undefined(undefined) { !function undefined(undefined) { try {} catch(undefined) {} }; }",
            None,
        ),

crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs

camc314 · 2026-02-15T21:42:59Z

Merge activity

Feb 15, 9:42 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 15, 9:43 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 15, 9:49 PM UTC: Merged by the Graphite merge queue.

…fault (#19407) upstream PR: eslint/eslint#20027 found here: https://github.com/oxc-project/eslint-plugin-oxlint/actions/runs/22040552727/job/63680629647?pr=632 updated the test via `just new-rule no-shadow-restricted-names`, there is a simpler command, but it works :) note: this is a default rule in oxlint: https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-shadow-restricted-names.html

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

…fault (oxc-project#19407) upstream PR: eslint/eslint#20027 found here: https://github.com/oxc-project/eslint-plugin-oxlint/actions/runs/22040552727/job/63680629647?pr=632 updated the test via `just new-rule no-shadow-restricted-names`, there is a simpler command, but it works :) note: this is a default rule in oxlint: https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-shadow-restricted-names.html

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (oxc-project#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (oxc-project#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (oxc-project#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (oxc-project#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (oxc-project#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (oxc-project#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (oxc-project#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (oxc-project#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (oxc-project#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (oxc-project#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (oxc-project#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (oxc-project#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (oxc-project#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (oxc-project#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (oxc-project#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (oxc-project#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (oxc-project#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (oxc-project#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (oxc-project#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (oxc-project#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (oxc-project#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (oxc-project#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (oxc-project#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (oxc-project#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (oxc-project#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (oxc-project#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (oxc-project#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (oxc-project#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (oxc-project#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (oxc-project#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (oxc-project#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (oxc-project#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (oxc-project#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (oxc-project#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (oxc-project#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (oxc-project#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (oxc-project#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (oxc-project#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (oxc-project#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (oxc-project#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red)

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 15, 2026

Sysix force-pushed the 02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default branch from 4069adb to af62631 Compare February 15, 2026 18:56

Sysix force-pushed the 02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default branch from af62631 to c1c1587 Compare February 15, 2026 18:59

Sysix marked this pull request as ready for review February 15, 2026 19:08

Sysix requested a review from camc314 as a code owner February 15, 2026 19:08

Copilot AI review requested due to automatic review settings February 15, 2026 19:08

Copilot started reviewing on behalf of Sysix February 15, 2026 19:08 View session

Copilot AI reviewed Feb 15, 2026

View reviewed changes

crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs Show resolved Hide resolved

Sysix force-pushed the 02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default branch from c1c1587 to 2111a69 Compare February 15, 2026 19:40

Sysix assigned camc314 Feb 15, 2026

camc314 approved these changes Feb 15, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 15, 2026

graphite-app bot force-pushed the 02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default branch from 2111a69 to 7711821 Compare February 15, 2026 21:43

graphite-app bot merged commit 7711821 into main Feb 15, 2026
21 checks passed

graphite-app bot deleted the 02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default branch February 15, 2026 21:49

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 15, 2026

Boshen mentioned this pull request Feb 16, 2026

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(oxlint)!: `no-shadow-restricted-names` report `globalThis` by default#19407

feat(oxlint)!: `no-shadow-restricted-names` report `globalThis` by default#19407
graphite-app[bot] merged 1 commit intomainfrom
02-15-feat_oxlint_no-shadow-restricted-names_report_globalthis_by_default

Sysix commented Feb 15, 2026 •

edited

Loading

Uh oh!

Sysix commented Feb 15, 2026

Uh oh!

codspeed-hq bot commented Feb 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 15, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

Sysix commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Feb 15, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 15, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Sysix commented Feb 15, 2026 •

edited

Loading

codspeed-hq bot commented Feb 15, 2026 •

edited

Loading

camc314 commented Feb 15, 2026 •

edited by graphite-app bot

Loading