perf(syntax): optimize `is_identifier_name_patched` by sapphi-red · Pull Request #19386 · oxc-project/oxc

sapphi-red · 2026-02-14T16:27:36Z

Dedupe the duplicated is_identifier_name_patched function and apply the same optimization with is_identifier_name.

sapphi-red · 2026-02-14T16:27:49Z

perf(syntax): optimize is_identifier_name_patched #19386 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-14T16:34:51Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing 02-15-perf_syntax_optimize_is_identifier_name_patched_ (f81ccbb) with main (4baebef)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (7a333c1) during the generation of this report, so 4baebef was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR centralizes and optimizes identifier-name validation by deduplicating the “patched” identifier check (which rejects Katakana middle dots for legacy Unicode compatibility) and reusing the same optimized implementation across the codebase.

Changes:

Adds is_identifier_name_patched to oxc_syntax and dedupes logic via a shared is_identifier_name_impl<const PATCHED: bool>.
Removes duplicated is_identifier_name_patched implementations from the minifier traverse context and formatter utilities.
Updates minifier + formatter call sites to use oxc_syntax::identifier::is_identifier_name_patched, and adds targeted tests for the patched behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_syntax/src/identifier.rs	Introduces shared impl for identifier-name validation and adds the patched variant + tests for Katakana dot rejection.
crates/oxc_minifier/src/traverse_context/ecma_context.rs	Removes the duplicated patched helper from `TraverseCtx`.
crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs	Switches property-key optimization to use the centralized patched helper.
crates/oxc_minifier/src/peephole/convert_to_dotted_properties.rs	Switches dotted-property conversion gate to use the centralized patched helper.
crates/oxc_formatter/src/utils/string.rs	Removes duplicated patched helper and imports the centralized one.
crates/oxc_formatter/src/utils/object.rs	Updates imports/usage to use the centralized patched helper.
crates/oxc_formatter/src/print/import_declaration.rs	Updates imports/usage to use the centralized patched helper.

Dunqing

LGTM

Dunqing · 2026-02-15T16:00:55Z

Merge activity

Feb 15, 4:00 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 15, 4:00 PM UTC: Dunqing added this pull request to the Graphite merge queue.
Feb 15, 4:07 PM UTC: Merged by the Graphite merge queue.

Dedupe the duplicated `is_identifier_name_patched` function and apply the same optimization with `is_identifier_name`.

### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (#19306) (Boshen)

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

Dedupe the duplicated `is_identifier_name_patched` function and apply the same optimization with `is_identifier_name`.

### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (oxc-project#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (oxc-project#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (oxc-project#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (oxc-project#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (oxc-project#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (oxc-project#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (oxc-project#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (oxc-project#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (oxc-project#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (oxc-project#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (oxc-project#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (oxc-project#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (oxc-project#19306) (Boshen)

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (oxc-project#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (oxc-project#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (oxc-project#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (oxc-project#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (oxc-project#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (oxc-project#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (oxc-project#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (oxc-project#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (oxc-project#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (oxc-project#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (oxc-project#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (oxc-project#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (oxc-project#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (oxc-project#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (oxc-project#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (oxc-project#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (oxc-project#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (oxc-project#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (oxc-project#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (oxc-project#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (oxc-project#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (oxc-project#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (oxc-project#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (oxc-project#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (oxc-project#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (oxc-project#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (oxc-project#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (oxc-project#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (oxc-project#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (oxc-project#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (oxc-project#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (oxc-project#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (oxc-project#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (oxc-project#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (oxc-project#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (oxc-project#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (oxc-project#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (oxc-project#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (oxc-project#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (oxc-project#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red)

github-actions bot added A-minifier Area - Minifier A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance labels Feb 14, 2026

sapphi-red force-pushed the 02-15-perf_syntax_optimize_is_identifier_name_patched_ branch from aaf7fee to f81ccbb Compare February 14, 2026 17:10

sapphi-red marked this pull request as ready for review February 14, 2026 17:24

sapphi-red requested a review from Dunqing as a code owner February 14, 2026 17:24

Copilot AI review requested due to automatic review settings February 14, 2026 17:24

sapphi-red assigned Dunqing Feb 14, 2026

Copilot started reviewing on behalf of sapphi-red February 14, 2026 17:24 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

Dunqing approved these changes Feb 15, 2026

View reviewed changes

Dunqing added the 0-merge Merge with Graphite Merge Queue label Feb 15, 2026

perf(syntax): optimize is_identifier_name_patched (#19386)

c169c77

Dedupe the duplicated `is_identifier_name_patched` function and apply the same optimization with `is_identifier_name`.

graphite-app bot force-pushed the 02-15-perf_syntax_optimize_is_identifier_name_patched_ branch from f81ccbb to c169c77 Compare February 15, 2026 16:01

graphite-app bot merged commit c169c77 into main Feb 15, 2026
21 checks passed

graphite-app bot deleted the 02-15-perf_syntax_optimize_is_identifier_name_patched_ branch February 15, 2026 16:07

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 15, 2026

This was referenced Feb 16, 2026

release(crates): oxc v0.114.0 #19429

Merged

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

OskarLebuda pushed a commit to OskarLebuda/oxc that referenced this pull request Feb 17, 2026

perf(syntax): optimize is_identifier_name_patched (oxc-project#19386)

9cc631d

Dedupe the duplicated `is_identifier_name_patched` function and apply the same optimization with `is_identifier_name`.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(syntax): optimize `is_identifier_name_patched`#19386

perf(syntax): optimize `is_identifier_name_patched`#19386
graphite-app[bot] merged 1 commit intomainfrom
02-15-perf_syntax_optimize_is_identifier_name_patched_

sapphi-red commented Feb 14, 2026 •

edited

Loading

Uh oh!

sapphi-red commented Feb 14, 2026

Uh oh!

codspeed-hq bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Dunqing left a comment

Uh oh!

Dunqing commented Feb 15, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

sapphi-red commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Feb 14, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Dunqing left a comment

Choose a reason for hiding this comment

Uh oh!

Dunqing commented Feb 15, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

sapphi-red commented Feb 14, 2026 •

edited

Loading

codspeed-hq bot commented Feb 14, 2026 •

edited

Loading

Dunqing commented Feb 15, 2026 •

edited by graphite-app bot

Loading