Skip to content

refactor(semantic): remove AstNode::id#19301

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-12-semantic_keep_astnode_id_api_and_remove_node_id_callsites
Feb 12, 2026
Merged

refactor(semantic): remove AstNode::id#19301
graphite-app[bot] merged 1 commit intomainfrom
02-12-semantic_keep_astnode_id_api_and_remove_node_id_callsites

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Feb 12, 2026

No description provided.

Copy link
Member Author

Boshen commented Feb 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Feb 12, 2026
@Boshen Boshen changed the title semantic: keep AstNode::id API and remove node_id callsites refactor(semantic): keep AstNode::id API and remove node_id callsites Feb 12, 2026
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 12, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing 02-12-semantic_keep_astnode_id_api_and_remove_node_id_callsites (6c2ab6e) with 02-11-semantic_assign_ast_node_ids_during_semantic_build_entire-checkpoint_a4f3fdbfe5b0 (7f79408)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen changed the title refactor(semantic): keep AstNode::id API and remove node_id callsites refactor(semantic): remove AstNode::id Feb 12, 2026
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026
Copy link
Member Author

Boshen commented Feb 12, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 02-11-semantic_assign_ast_node_ids_during_semantic_build_entire-checkpoint_a4f3fdbfe5b0 branch from 7f79408 to 429d876 Compare February 12, 2026 08:07
@graphite-app graphite-app bot force-pushed the 02-12-semantic_keep_astnode_id_api_and_remove_node_id_callsites branch from 6c2ab6e to 16907e4 Compare February 12, 2026 08:07
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026
Base automatically changed from 02-11-semantic_assign_ast_node_ids_during_semantic_build_entire-checkpoint_a4f3fdbfe5b0 to main February 12, 2026 08:14
@graphite-app graphite-app bot merged commit 16907e4 into main Feb 12, 2026
22 checks passed
@graphite-app graphite-app bot deleted the 02-12-semantic_keep_astnode_id_api_and_remove_node_id_callsites branch February 12, 2026 08:14
Limerio pushed a commit to Limerio/oxc that referenced this pull request Feb 12, 2026
OskarLebuda pushed a commit to OskarLebuda/oxc that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments