refactor(oxfmt/lsp): pass LanguageId to run_format#19286
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 17, 2026
Merged
refactor(oxfmt/lsp): pass LanguageId to run_format#19286graphite-app[bot] merged 1 commit intomainfrom
LanguageId to run_format#19286graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-cli
Sysix
changed the title
LanguageId to run_formatLanguageId to run_format
github-actions
bot
added
the
C-cleanup
Merging this PR will not alter performance
Comparing 
Footnotes
|
Sysix
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
66bb3a7 to
4c9346f
Compare
Sysix
force-pushed
the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
2 times, most recently
from
a9b1aca to
10b8c79
Compare
Sysix
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
598a1c1 to
a67ac66
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the language server formatting pipeline so that a document’s LanguageId (from textDocument/didOpen) is propagated down into tool formatting hooks, enabling formatters to make decisions even when file extensions are missing.
Changes:
- Extend the
Tool::run_formathook to accept&LanguageId. - Thread
LanguageIdthroughBackend::formatting→WorkspaceWorker::format_file→Tool::run_format. - Update the oxfmt LSP formatter tool implementation to match the new trait signature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/tool.rs | Extends Tool::run_format to accept a LanguageId parameter. |
| crates/oxc_language_server/src/worker.rs | Updates format_file to forward LanguageId into run_format. |
| crates/oxc_language_server/src/backend.rs | Fetches (LanguageId, content) from the in-memory FS and passes both into format_file. |
| apps/oxfmt/src/lsp/server_formatter.rs | Adjusts ServerFormatter’s run_format signature to match the updated trait. |
Sysix
force-pushed
the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
from
10b8c79 to
bfe263c
Compare
Sysix
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
a67ac66 to
76c4be8
Compare
Sysix
force-pushed
the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
from
bfe263c to
e4fa5ef
Compare
Sysix
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
76c4be8 to
23751ee
Compare
Sysix
force-pushed
the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
from
e4fa5ef to
001e002
Compare
Sysix
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
23751ee to
7ac6368
Compare
leaysgur
reviewed
Feb 16, 2026
Sysix
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
7ac6368 to
ec95217
Compare
Sysix
force-pushed
the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
from
001e002 to
5d5aa58
Compare
Contributor
Merge activity
|
related oxc-project/oxc-vscode#25 > This PR updates the language server formatting pipeline so that a document’s `LanguageId` (from `textDocument/didOpen`) is propagated down into tool formatting hooks, enabling formatters to make decisions even when file extensions are missing.
graphite-app
bot
force-pushed
the
02-11-chore_lsp_introduce_languageid_enum
branch
from
ec95217 to
88ec03e
Compare
graphite-app
bot
force-pushed
the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
from
5d5aa58 to
0eb9a2d
Compare
Base automatically changed from
02-11-chore_lsp_introduce_languageid_enum
to
main
February 17, 2026 02:12
graphite-app
bot
deleted the
02-11-refacor_oxfmt_lsp_pass_languageid_to_run_format_
branch
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
…9286) related oxc-project/oxc-vscode#25 > This PR updates the language server formatting pipeline so that a document’s `LanguageId` (from `textDocument/didOpen`) is propagated down into tool formatting hooks, enabling formatters to make decisions even when file extensions are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related oxc-project/oxc-vscode#25