fix(linter/import-no-cycle): avoid traversal-order false negatives with type-only edges by camc314 · Pull Request #19267 · oxc-project/oxc

camc314 · 2026-02-11T14:24:48Z

Root cause:
ModuleGraphVisitor marked a module as traversed before applying the rule
filter. For no-cycle with ignoreTypes: true, a type-only edge could claim
a node first, then a later value edge to the same node was skipped. Because
sibling import iteration order is filename-dependent, this produced
deterministic-but-order-sensitive misses.

Before:

parent
  -> type-only edge to X      (filtered out by rule)
       [X added to traversed too early]
  -> value edge to X
       [skipped: already traversed]
  => real cycle can be missed

After:

parent
  -> type-only edge to X
       [filtered out first, not marked traversed]
  -> value edge to X
       [accepted, then marked traversed]
  => cycle path remains discoverable

Changes included:

Move traversed insertion to run after filter in ModuleGraphVisitor.
Add a dedicated regression test for issue linter: import/no-cycle false negative depends on filename/traversal order with type-only import path #19245.
Add TS fixture set reproducing the filename/type-only branch scenario.
Add snapshot asserting the cycle diagnostic is emitted.

fixes #19245

AI disclosure: this commit was prepared with AI assistance and reviewed.

camc314 · 2026-02-11T14:25:03Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-11T14:32:23Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-11-fix_linter_import-no-cycle_avoid_traversal-order_false_negatives_with_type-only_edges_fix_import_no-cycle_false_negatives_reported_in_issue_19245_by_adjusting_module_graph_traversal_semantics (2a47617) with main (e5baf60)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2026-02-11T14:50:19Z

Merge activity

Feb 11, 2:50 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 11, 2:57 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 11, 3:03 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

Fixes import/no-cycle traversal-order false negatives when ignoreTypes: true by ensuring modules are only marked traversed after the rule-specific edge filter accepts the edge, so filtered type-only edges can’t “claim” a node and block later value-edge traversal.

Changes:

Move traversed insertion in ModuleGraphVisitor to occur after the filter check.
Add a regression scenario for issue #19245 plus a new TypeScript fixture set.
Update the import_no_cycle snapshot for the new test output.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_linter/src/module_graph_visitor.rs	Fixes traversal bookkeeping by applying the filter before marking nodes as traversed.
crates/oxc_linter/src/rules/import/no_cycle.rs	Adds a new failing test case intended to reproduce #19245.
crates/oxc_linter/src/snapshots/import_no_cycle.snap	Updates snapshots to include the new test output.
crates/oxc_linter/fixtures/import/cycles/typescript/issue_19245/simpleInterestLoanManager.ts	New TS fixture module for #19245 reproduction.
crates/oxc_linter/fixtures/import/cycles/typescript/issue_19245/installmentLoanManager.ts	New TS fixture module for #19245 reproduction.
crates/oxc_linter/fixtures/import/cycles/typescript/issue_19245/dataReport/avenAccountDataReportManager.ts	New TS fixture module for #19245 reproduction.
crates/oxc_linter/fixtures/import/cycles/typescript/issue_19245/balanceSweepDetailsManager.ts	New TS fixture entrypoint for #19245 reproduction.
crates/oxc_linter/fixtures/import/cycles/typescript/issue_19245/aaaInternal.ts	New TS fixture module for filename-order path in #19245 reproduction.

crates/oxc_linter/src/rules/import/no_cycle.rs

…th type-only edges (#19267) Root cause: `ModuleGraphVisitor` marked a module as `traversed` before applying the rule filter. For `no-cycle` with `ignoreTypes: true`, a type-only edge could claim a node first, then a later value edge to the same node was skipped. Because sibling import iteration order is filename-dependent, this produced deterministic-but-order-sensitive misses. Before: ```text parent -> type-only edge to X (filtered out by rule) [X added to traversed too early] -> value edge to X [skipped: already traversed] => real cycle can be missed ``` After: ```text parent -> type-only edge to X [filtered out first, not marked traversed] -> value edge to X [accepted, then marked traversed] => cycle path remains discoverable ``` Changes included: - Move `traversed` insertion to run after `filter` in `ModuleGraphVisitor`. - Add a dedicated regression test for issue #19245. - Add TS fixture set reproducing the filename/type-only branch scenario. - Add snapshot asserting the cycle diagnostic is emitted. fixes #19245 AI disclosure: this commit was prepared with AI assistance and reviewed.

# Oxlint ### 🚀 Features - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) - 2879fc5 linter: Implement fixer for unicorn/prefer-math-trunc (#19275) (camc314) - a204eda linter: Implement fixer for unicorn/no-typeof-undefined (#19274) (camc314) - ab46d9c linter: Implement typescript/class-literal-property-style (#19252) (Vincent R) - 1a61f58 linter: Implement typescript/no-invalid-void-type (#19242) (Vincent R) ### 🐛 Bug Fixes - 45adda2 oxlint/lsp: Use blocking stdio in Oxlint (#19292) (overlookmotel) - 05bc855 linter/import: Count unique module sources in max-dependencies (#19270) (camc314) - 8566b44 linter: Check for preceeding token in math trunc fixer (#19277) (camc314) - f16f2b6 linter/import-no-cycle: Avoid traversal-order false negatives with type-only edges (#19267) (camc314) - d4937e7 linter: Recognize module-scoped callback refs as stable in exhaustive-deps (#19220) (Sreetam Das) - 140c9bd linter: Detect fallthrough from `default` when it is not the last case (#19261) (Boshen) - 740a009 linter: Accept digits after 'use' in hook names (#19254) (Sreetam Das) - 31b562f linter: Update `import/no-named-as-default` to allow named import if equivalent to the default import (#19100) (connorshea) - 79c82cc linter: Avoid applying object-level docs to nested object methods in require-param (#19231) (camc314) ### ⚡ Performance - 5670291 linter/class-literal-property-style: Avoid unneeded string allocations (#19262) (camc314) # Oxfmt ### 🚀 Features - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) ### 🐛 Bug Fixes - 1957908 formatter: Avoid unnecessary parentheses for string literal in labeled statement (#19272) (Dunqing) Co-authored-by: camc314 <[email protected]>

…th type-only edges (oxc-project#19267) Root cause: `ModuleGraphVisitor` marked a module as `traversed` before applying the rule filter. For `no-cycle` with `ignoreTypes: true`, a type-only edge could claim a node first, then a later value edge to the same node was skipped. Because sibling import iteration order is filename-dependent, this produced deterministic-but-order-sensitive misses. Before: ```text parent -> type-only edge to X (filtered out by rule) [X added to traversed too early] -> value edge to X [skipped: already traversed] => real cycle can be missed ``` After: ```text parent -> type-only edge to X [filtered out first, not marked traversed] -> value edge to X [accepted, then marked traversed] => cycle path remains discoverable ``` Changes included: - Move `traversed` insertion to run after `filter` in `ModuleGraphVisitor`. - Add a dedicated regression test for issue oxc-project#19245. - Add TS fixture set reproducing the filename/type-only branch scenario. - Add snapshot asserting the cycle diagnostic is emitted. fixes oxc-project#19245 AI disclosure: this commit was prepared with AI assistance and reviewed.

# Oxlint ### 🚀 Features - ebb80b3 ast: Add `node_id` field to all AST struct nodes (oxc-project#18138) (Boshen) - 2879fc5 linter: Implement fixer for unicorn/prefer-math-trunc (oxc-project#19275) (camc314) - a204eda linter: Implement fixer for unicorn/no-typeof-undefined (oxc-project#19274) (camc314) - ab46d9c linter: Implement typescript/class-literal-property-style (oxc-project#19252) (Vincent R) - 1a61f58 linter: Implement typescript/no-invalid-void-type (oxc-project#19242) (Vincent R) ### 🐛 Bug Fixes - 45adda2 oxlint/lsp: Use blocking stdio in Oxlint (oxc-project#19292) (overlookmotel) - 05bc855 linter/import: Count unique module sources in max-dependencies (oxc-project#19270) (camc314) - 8566b44 linter: Check for preceeding token in math trunc fixer (oxc-project#19277) (camc314) - f16f2b6 linter/import-no-cycle: Avoid traversal-order false negatives with type-only edges (oxc-project#19267) (camc314) - d4937e7 linter: Recognize module-scoped callback refs as stable in exhaustive-deps (oxc-project#19220) (Sreetam Das) - 140c9bd linter: Detect fallthrough from `default` when it is not the last case (oxc-project#19261) (Boshen) - 740a009 linter: Accept digits after 'use' in hook names (oxc-project#19254) (Sreetam Das) - 31b562f linter: Update `import/no-named-as-default` to allow named import if equivalent to the default import (oxc-project#19100) (connorshea) - 79c82cc linter: Avoid applying object-level docs to nested object methods in require-param (oxc-project#19231) (camc314) ### ⚡ Performance - 5670291 linter/class-literal-property-style: Avoid unneeded string allocations (oxc-project#19262) (camc314) # Oxfmt ### 🚀 Features - ebb80b3 ast: Add `node_id` field to all AST struct nodes (oxc-project#18138) (Boshen) ### 🐛 Bug Fixes - 1957908 formatter: Avoid unnecessary parentheses for string literal in labeled statement (oxc-project#19272) (Dunqing) Co-authored-by: camc314 <[email protected]>

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 11, 2026

camc314 force-pushed the c/02-11-fix_linter_import-no-cycle_avoid_traversal-order_false_negatives_with_type-only_edges_fix_import_no-cycle_false_negatives_reported_in_issue_19245_by_adjusting_module_graph_traversal_semantics branch from 5f2bf93 to 2eeb280 Compare February 11, 2026 14:25

camc314 self-assigned this Feb 11, 2026

camc314 marked this pull request as ready for review February 11, 2026 14:49

Copilot AI review requested due to automatic review settings February 11, 2026 14:49

camc314 force-pushed the c/02-11-fix_linter_import-no-cycle_avoid_traversal-order_false_negatives_with_type-only_edges_fix_import_no-cycle_false_negatives_reported_in_issue_19245_by_adjusting_module_graph_traversal_semantics branch from 2eeb280 to 2a47617 Compare February 11, 2026 14:49

Copilot started reviewing on behalf of camc314 February 11, 2026 14:49 View session

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 11, 2026

Copilot AI reviewed Feb 11, 2026

View reviewed changes

crates/oxc_linter/src/rules/import/no_cycle.rs Show resolved Hide resolved

graphite-app bot force-pushed the c/02-11-fix_linter_import-no-cycle_avoid_traversal-order_false_negatives_with_type-only_edges_fix_import_no-cycle_false_negatives_reported_in_issue_19245_by_adjusting_module_graph_traversal_semantics branch from 2a47617 to f16f2b6 Compare February 11, 2026 14:58

graphite-app bot merged commit f16f2b6 into main Feb 11, 2026
21 checks passed

graphite-app bot deleted the c/02-11-fix_linter_import-no-cycle_avoid_traversal-order_false_negatives_with_type-only_edges_fix_import_no-cycle_false_negatives_reported_in_issue_19245_by_adjusting_module_graph_traversal_semantics branch February 11, 2026 15:03

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 11, 2026

Boshen mentioned this pull request Feb 12, 2026

release(apps): oxlint v1.47.0 && oxfmt v0.32.0 #19315

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter/import-no-cycle): avoid traversal-order false negatives with type-only edges#19267

camc314 commented Feb 11, 2026 •

edited

Loading

Uh oh!

camc314 commented Feb 11, 2026

Uh oh!

codspeed-hq bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

camc314 commented Feb 11, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Uh oh!

Conversation

camc314 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Feb 11, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 commented Feb 11, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

camc314 commented Feb 11, 2026 •

edited

Loading

codspeed-hq bot commented Feb 11, 2026 •

edited

Loading

camc314 commented Feb 11, 2026 •

edited by graphite-app bot

Loading