fix(oxlint, oxfmt): update bindings.js files#19229
Merged
overlookmotel merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the auto-generated NAPI-RS bindings.js files for Oxlint and Oxfmt so their native binding package version checks match the versions that were actually released, unblocking CI’s Test NAPI task.
Changes:
- Update Oxlint native binding expected version checks from
1.44.0→1.45.0. - Update Oxfmt native binding expected version checks from
0.29.0→0.30.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/bindings.js | Bumps the expected @oxlint/binding-* package version used by the optional NAPI-RS version enforcement check. |
| apps/oxfmt/src-js/bindings.js | Bumps the expected @oxfmt/binding-* package version used by the optional NAPI-RS version enforcement check. |
Member
Author
|
Am going to merge this just to get CI green again. |
overlookmotel
deleted the
om/02-10-fix_oxlint_oxfmt_update_bindings.js_files
branch
owjs3901
pushed a commit
to owjs3901/oxc
that referenced
this pull request
Feb 11, 2026
We had a failed apps release today. In the first attempt at releasing a87b845 the `bindings.js` files got updated with new version numbers. But in the 2nd release (the successful one) c705f95, for some reason they weren't. Run `pnpm run build-js` for both Oxlint and Oxfmt to update the `bindings.js` files to contain the correct version numbers. The packages published to NPM [have incorrect version numbers](https://www.npmjs.com/package/oxlint?activeTab=code) but I don't think this is a big problem - it'll only cause an error if Oxlint/Oxfmt are run with `NAPI_RS_ENFORCE_VERSION_CHECK=1`. So I think this PR is probably all we need to do, just to get CI Test NAPI task passing again.
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
We had a failed apps release today. In the first attempt at releasing a87b845 the `bindings.js` files got updated with new version numbers. But in the 2nd release (the successful one) c705f95, for some reason they weren't. Run `pnpm run build-js` for both Oxlint and Oxfmt to update the `bindings.js` files to contain the correct version numbers. The packages published to NPM [have incorrect version numbers](https://www.npmjs.com/package/oxlint?activeTab=code) but I don't think this is a big problem - it'll only cause an error if Oxlint/Oxfmt are run with `NAPI_RS_ENFORCE_VERSION_CHECK=1`. So I think this PR is probably all we need to do, just to get CI Test NAPI task passing again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a failed apps release today. In the first attempt at releasing a87b845 the
bindings.jsfiles got updated with new version numbers. But in the 2nd release (the successful one) c705f95, for some reason they weren't.Run
pnpm run build-jsfor both Oxlint and Oxfmt to update thebindings.jsfiles to contain the correct version numbers.The packages published to NPM have incorrect version numbers but I don't think this is a big problem - it'll only cause an error if Oxlint/Oxfmt are run with
NAPI_RS_ENFORCE_VERSION_CHECK=1.So I think this PR is probably all we need to do, just to get CI Test NAPI task passing again.