perf(isolated-declarations): replace hash collections with index-based Vec#19221
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 11, 2026
Merged
perf(isolated-declarations): replace hash collections with index-based Vec#19221graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-isolated-declarations
Merging this PR will improve performance by 7.77%
Performance Changes
Comparing 
Footnotes
|
Dunqing
force-pushed
the
perf/isolated-declarations
branch
2 times, most recently
from
33e63d4 to
4e70d87
Compare
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
force-pushed
the
perf/isolated-declarations
branch
from
4e70d87 to
6de0e78
Compare
Member
Author
|
Much clearer than before |
Member
Merge activity
|
…d Vec (#19221) ## Summary - Eliminate redundant `transformed_spans: FxHashSet<Span>` by consolidating passthrough cases into `transformed_stmts` - Replace `transformed_stmts: FxHashMap<Span, Statement>` with `Vec<Option<Statement>>` indexed by statement position for O(1) lookups - Merge `get_assignable_properties_for_namespaces` into `report_error_for_expando_function` as a single forward pass **Benchmark (vue-id.ts):** 8.53ms → 6.57ms (**~23% faster**) ## Test plan - [x] `cargo test -p oxc_isolated_declarations` — all 20 tests pass - [x] `cargo clippy` — no warnings - [x] `cargo bench -p oxc_benchmark --bench transformer -- isolated-declarations` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
perf/isolated-declarations
branch
from
6de0e78 to
e5baf60
Compare
camc314
pushed a commit
that referenced
this pull request
Feb 16, 2026
### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (#19306) (Boshen)
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
…d Vec (oxc-project#19221) ## Summary - Eliminate redundant `transformed_spans: FxHashSet<Span>` by consolidating passthrough cases into `transformed_stmts` - Replace `transformed_stmts: FxHashMap<Span, Statement>` with `Vec<Option<Statement>>` indexed by statement position for O(1) lookups - Merge `get_assignable_properties_for_namespaces` into `report_error_for_expando_function` as a single forward pass **Benchmark (vue-id.ts):** 8.53ms → 6.57ms (**~23% faster**) ## Test plan - [x] `cargo test -p oxc_isolated_declarations` — all 20 tests pass - [x] `cargo clippy` — no warnings - [x] `cargo bench -p oxc_benchmark --bench transformer -- isolated-declarations` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (oxc-project#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (oxc-project#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (oxc-project#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (oxc-project#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (oxc-project#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (oxc-project#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (oxc-project#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (oxc-project#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (oxc-project#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (oxc-project#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (oxc-project#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (oxc-project#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (oxc-project#19306) (Boshen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transformed_spans: FxHashSet<Span>by consolidating passthrough cases intotransformed_stmtstransformed_stmts: FxHashMap<Span, Statement>withVec<Option<Statement>>indexed by statement position for O(1) lookupsget_assignable_properties_for_namespacesintoreport_error_for_expando_functionas a single forward passBenchmark (vue-id.ts): 8.53ms → 6.57ms (~23% faster)
Test plan
cargo test -p oxc_isolated_declarations— all 20 tests passcargo clippy— no warningscargo bench -p oxc_benchmark --bench transformer -- isolated-declarations🤖 Generated with Claude Code