fix(linter/plugins): support legacy context.report(node, ...) calls#19193
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2026
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses ESLint-compatibility for JS plugins by supporting the legacy context.report(node, ...) positional call signature, fixing failures like “Either message or messageId is required” reported in #19192.
Changes:
- Normalize
context.report()arguments to support legacy positional signatures and forward a descriptor to the shared reporter. - Add a new CLI fixture to validate legacy positional
context.report(node, message)behavior end-to-end via snapshots.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/context.ts | Adds argument normalization so Context#report can accept legacy positional args and still call the shared report() with a descriptor. |
| apps/oxlint/test/fixtures/report_legacy_positional_args/plugin.ts | Fixture plugin that calls context.report(node, message) using the legacy signature. |
| apps/oxlint/test/fixtures/report_legacy_positional_args/.oxlintrc.json | Fixture config enabling the legacy-report rule. |
| apps/oxlint/test/fixtures/report_legacy_positional_args/files/index.js | Minimal input file that triggers a DebuggerStatement. |
| apps/oxlint/test/fixtures/report_legacy_positional_args/output.snap.md | Snapshot asserting expected CLI output from both built-in and plugin diagnostics. |
camc314
force-pushed
the
c/02-09-fix_linter_plugins_support_legacy_context.report_node_._calls
branch
from
ac3c716 to
3136acd
Compare
Member
Merge activity
|
graphite-app
bot
force-pushed
the
c/02-09-fix_linter_plugins_support_legacy_context.report_node_._calls
branch
from
3136acd to
d07059c
Compare
graphite-app
bot
deleted the
c/02-09-fix_linter_plugins_support_legacy_context.report_node_._calls
branch
This was referenced Feb 10, 2026
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…call forms (#19239) Follow on after #19193. Refactor. That PR introduced support for legacy call styles for `context.report`. Move that implementation into `report.ts`, shorten the code a little, and produce consistent object shapes. Avoid calling `convertLegacyCallArgs` in the common case that `report` is called in the modern way.
owjs3901
pushed a commit
to owjs3901/oxc
that referenced
this pull request
Feb 11, 2026
owjs3901
pushed a commit
to owjs3901/oxc
that referenced
this pull request
Feb 11, 2026
…call forms (oxc-project#19239) Follow on after oxc-project#19193. Refactor. That PR introduced support for legacy call styles for `context.report`. Move that implementation into `report.ts`, shorten the code a little, and produce consistent object shapes. Avoid calling `convertLegacyCallArgs` in the common case that `report` is called in the modern way.
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
…call forms (oxc-project#19239) Follow on after oxc-project#19193. Refactor. That PR introduced support for legacy call styles for `context.report`. Move that implementation into `report.ts`, shorten the code a little, and produce consistent object shapes. Avoid calling `convertLegacyCallArgs` in the common case that `report` is called in the modern way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19192