refactor(linter/plugins): pass fix/suggestion offsets to Rust as `i64`s by overlookmotel · Pull Request #19159 · oxc-project/oxc

overlookmotel · 2026-02-08T20:24:30Z

Follow-on after #19092.

That PR added 1 to offsets of fixes before sending them to Rust side, to support offset -1 (legal when fix is to remove a BOM).

Upon reflection, I think that solution is too complicated and confusing. Instead, represent start and end offsets of fixes as i64s in JsFix. This supports -1 as an offset, and also the full range of valid u32 values. Check on Rust side that the values are in range before converting to u32s.

This also makes for better error messages for invalid offsets - no more inexplicable "Failed to deserialize JSON returned by lintFile" errors.

overlookmotel · 2026-02-08T20:24:51Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-08T20:32:51Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s (7c71615) with main (825f148)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (6e8ef38) during the generation of this report, so 825f148 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR simplifies JS→Rust fix/suggestion range handling by removing the “+1 offset” workaround and instead representing fix start/end offsets as signed 64-bit integers, enabling -1 (BOM-relative) while still supporting the full u32 range once validated on the Rust side.

Changes:

Refactors Rust JsFix to use start: i64 / end: i64 and adds validation/conversion logic for negative/out-of-range offsets.
Updates JS plugin FixReport to send start/end directly (no +1 encoding).
Updates fixture snapshots to reflect new error surfaces and output formatting.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/external_linter.rs	Switches `JsFix` offsets to `i64` and adds conversion/validation path for invalid offsets and BOM `-1`.
apps/oxlint/src-js/plugins/fix.ts	Updates JS-side payload shape to `{ start, end, text }` and adjusts documentation accordingly.
apps/oxlint/test/fixtures/suggestions/output.snap.md	Snapshot updates reflecting new error behavior/output.
apps/oxlint/test/fixtures/suggestions/fix.snap.md	Snapshot updates reflecting new error behavior/output.
apps/oxlint/test/fixtures/suggestions/fix-suggestions.snap.md	Snapshot updates reflecting new error behavior/output.
apps/oxlint/test/fixtures/fixes/output.snap.md	Snapshot updates reflecting new error behavior/output.
apps/oxlint/test/fixtures/fixes/fix.snap.md	Snapshot updates reflecting new error behavior/output.

apps/oxlint/src-js/plugins/fix.ts

crates/oxc_linter/src/external_linter.rs

overlookmotel · 2026-02-08T20:58:47Z

Merge activity

Feb 8, 8:58 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 8, 9:04 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Feb 8, 9:10 PM UTC: Merged by the Graphite merge queue.

…`s (#19159) Follow-on after #19092. That PR added 1 to offsets of fixes before sending them to Rust side, to support offset `-1` (legal when fix is to remove a BOM). Upon reflection, I think that solution is too complicated and confusing. Instead, represent `start` and `end` offsets of fixes as `i64`s in `JsFix`. This supports `-1` as an offset, and also the full range of valid `u32` values. Check on Rust side that the values are in range before converting to `u32`s. This also makes for better error messages for invalid offsets - no more inexplicable "Failed to deserialize JSON returned by `lintFile`" errors.

…`s (oxc-project#19159) Follow-on after oxc-project#19092. That PR added 1 to offsets of fixes before sending them to Rust side, to support offset `-1` (legal when fix is to remove a BOM). Upon reflection, I think that solution is too complicated and confusing. Instead, represent `start` and `end` offsets of fixes as `i64`s in `JsFix`. This supports `-1` as an offset, and also the full range of valid `u32` values. Check on Rust side that the values are in range before converting to `u32`s. This also makes for better error messages for invalid offsets - no more inexplicable "Failed to deserialize JSON returned by `lintFile`" errors.

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Feb 8, 2026

overlookmotel mentioned this pull request Feb 8, 2026

feat(linter/plugins): RuleTester test suggestions #19104

Merged

github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 8, 2026

overlookmotel force-pushed the om/02-08-docs_linter_plugins_correct_and_expand_jsdoc_comment_for_ruletester_config branch from ea456c1 to f7e0221 Compare February 8, 2026 20:26

overlookmotel force-pushed the om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s branch from 896e1a6 to 58d4d89 Compare February 8, 2026 20:26

overlookmotel marked this pull request as ready for review February 8, 2026 20:39

overlookmotel requested a review from camc314 as a code owner February 8, 2026 20:40

Copilot AI review requested due to automatic review settings February 8, 2026 20:40

Copilot started reviewing on behalf of overlookmotel February 8, 2026 20:40 View session

graphite-app bot changed the base branch from om/02-08-docs_linter_plugins_correct_and_expand_jsdoc_comment_for_ruletester_config to graphite-base/19159 February 8, 2026 20:41

overlookmotel self-assigned this Feb 8, 2026

Copilot AI reviewed Feb 8, 2026

View reviewed changes

apps/oxlint/src-js/plugins/fix.ts Outdated Show resolved Hide resolved

crates/oxc_linter/src/external_linter.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/external_linter.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/external_linter.rs Show resolved Hide resolved

graphite-app bot force-pushed the om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s branch from 58d4d89 to f3db61b Compare February 8, 2026 20:48

graphite-app bot force-pushed the graphite-base/19159 branch from f7e0221 to 6e8ef38 Compare February 8, 2026 20:48

graphite-app bot changed the base branch from graphite-base/19159 to main February 8, 2026 20:49

graphite-app bot force-pushed the om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s branch from f3db61b to 215f80e Compare February 8, 2026 20:49

overlookmotel force-pushed the om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s branch from 215f80e to 7c71615 Compare February 8, 2026 20:58

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 8, 2026

graphite-app bot force-pushed the om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s branch from 7c71615 to 55be9fe Compare February 8, 2026 21:04

graphite-app bot merged commit 55be9fe into main Feb 8, 2026
21 checks passed

graphite-app bot deleted the om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s branch February 8, 2026 21:10

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(linter/plugins): pass fix/suggestion offsets to Rust as `i64`s#19159

refactor(linter/plugins): pass fix/suggestion offsets to Rust as `i64`s#19159
graphite-app[bot] merged 1 commit intomainfrom
om/02-08-refactor_linter_plugins_pass_fix_suggestion_offsets_to_rust_as_i64_s

overlookmotel commented Feb 8, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Feb 8, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel commented Feb 8, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Uh oh!

Conversation

overlookmotel commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel commented Feb 8, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

overlookmotel commented Feb 8, 2026 •

edited

Loading

overlookmotel commented Feb 8, 2026 •

edited

Loading

codspeed-hq bot commented Feb 8, 2026 •

edited

Loading

overlookmotel commented Feb 8, 2026 •

edited by graphite-app bot

Loading