feat(linter): add typescript/no-unnecessary-condition by camc314 · Pull Request #19130 · oxc-project/oxc

camc314 · 2026-02-08T01:34:11Z

No description provided.

camc314 · 2026-02-08T01:34:37Z

feat(linter): add typescript/no-unnecessary-condition #19130 👈 (View in Graphite)
chore(oxlint,parser,e2e): explicitly set strict: false in tsconfigs #19129 : 1 other dependent PR (#19141 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-08T01:40:39Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule (31b5fa4) with main (9f65861)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (d804295) during the generation of this report, so 9f65861 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

apps/oxlint/fixtures/tsgolint_rule_options/.oxlintrc.json

apps/oxlint/fixtures/tsgolint/no-unnecessary-condition.ts

camc314 · 2026-02-12T12:49:17Z

Merge activity

Feb 12, 12:49 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 12, 1:03 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 12, 1:13 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

Adds the TypeScript ESLint rule typescript/no-unnecessary-condition to the oxlint rule set (as a tsgolint-backed, type-aware rule), including configuration schema support and fixture/snapshot coverage to validate the new diagnostics.

Changes:

Introduces the new NoUnnecessaryCondition rule wrapper and its JSON-config schema/types.
Registers the rule in the TypeScript rules module and in generated rule registries/runners.
Updates oxlint fixtures and snapshots to exercise and lock in the new rule’s behavior (including option coverage).

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/typescript/no_unnecessary_condition.rs	Adds the rule wrapper plus config types/schema/docs for `no-unnecessary-condition`.
crates/oxc_linter/src/rules.rs	Registers the new TypeScript rule module.
crates/oxc_linter/src/generated/rules_enum.rs	Adds the rule to the generated rule enum/dispatch/registry.
crates/oxc_linter/src/generated/rule_runner_impls.rs	Adds generated `RuleRunner` metadata for the new rule.
apps/oxlint/fixtures/tsgolint_rule_options/test.ts	Adds fixture code to validate the rule and the `allowConstantLoopConditions` option.
apps/oxlint/fixtures/tsgolint_rule_options/.oxlintrc.json	Enables/configures the rule for the rule-options fixture suite.
apps/oxlint/fixtures/tsgolint/no-unneccessary-condition.ts	Adds a new fixture exercising a truthy-object condition case.
apps/oxlint/fixtures/tsgolint/.oxlintrc.json	Enables the rule in the main tsgolint fixture suite.
apps/oxlint/src/snapshots/[email protected]	Updates expected output to include the new rule’s diagnostics.
apps/oxlint/src/snapshots/[email protected]	Updates expected output/error counts to include the new rule’s diagnostics.

crates/oxc_linter/src/rules/typescript/no_unnecessary_condition.rs

apps/oxlint/fixtures/tsgolint/no-unnecessary-condition.ts

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

)

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (oxc-project#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (oxc-project#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (oxc-project#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (oxc-project#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (oxc-project#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (oxc-project#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (oxc-project#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (oxc-project#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (oxc-project#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (oxc-project#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (oxc-project#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (oxc-project#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (oxc-project#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (oxc-project#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (oxc-project#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (oxc-project#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (oxc-project#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (oxc-project#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (oxc-project#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (oxc-project#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (oxc-project#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (oxc-project#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (oxc-project#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (oxc-project#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (oxc-project#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (oxc-project#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (oxc-project#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (oxc-project#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (oxc-project#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (oxc-project#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (oxc-project#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (oxc-project#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (oxc-project#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (oxc-project#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (oxc-project#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (oxc-project#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (oxc-project#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (oxc-project#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (oxc-project#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (oxc-project#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (oxc-project#19386) (sapphi-red)

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Feb 8, 2026

camc314 mentioned this pull request Feb 8, 2026

chore(oxlint,parser,e2e): explicitly set strict: false in tsconfigs #19129

Merged

camc314 force-pushed the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch 2 times, most recently from 406d1a6 to 1a8891a Compare February 8, 2026 02:05

camc314 mentioned this pull request Feb 8, 2026

refactor(oxlint): enable useUnknownInCatchVariables tsconfig setting #19141

Merged

connorshea reviewed Feb 9, 2026

View reviewed changes

apps/oxlint/fixtures/tsgolint_rule_options/.oxlintrc.json Show resolved Hide resolved

connorshea reviewed Feb 9, 2026

View reviewed changes

apps/oxlint/fixtures/tsgolint/no-unnecessary-condition.ts Show resolved Hide resolved

graphite-app bot changed the base branch from c/02-08-chore_all_explicitly_set_strict_false_in_tsconfigs to graphite-base/19130 February 9, 2026 09:35

camc314 force-pushed the graphite-base/19130 branch from 36f3872 to 1130bef Compare February 9, 2026 10:51

camc314 force-pushed the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch from 1a8891a to 0a17461 Compare February 9, 2026 10:51

camc314 changed the base branch from graphite-base/19130 to main February 9, 2026 10:51

camc314 changed the title ~~feat(linter/typescript/no-unneccessary-condition): add rule~~ feat(linter/typescript/no-unnecessary-condition): add rule Feb 9, 2026

camc314 self-assigned this Feb 10, 2026

camc314 force-pushed the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch from 0a17461 to 6dbd711 Compare February 12, 2026 12:47

camc314 changed the title ~~feat(linter/typescript/no-unnecessary-condition): add rule~~ feat(linter): add typescript/no-unnecessary-condition Feb 12, 2026

camc314 force-pushed the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch from 6dbd711 to 31b5fa4 Compare February 12, 2026 12:48

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026

camc314 marked this pull request as ready for review February 12, 2026 12:49

Copilot AI review requested due to automatic review settings February 12, 2026 12:49

Copilot started reviewing on behalf of camc314 February 12, 2026 12:49 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

crates/oxc_linter/src/rules/typescript/no_unnecessary_condition.rs Show resolved Hide resolved

apps/oxlint/fixtures/tsgolint/no-unnecessary-condition.ts Show resolved Hide resolved

camc314 force-pushed the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch 3 times, most recently from 4980c3b to 2bad9cb Compare February 12, 2026 12:55

feat(linter): add typescript/no-unnecessary-condition (#19130)

1612932

graphite-app bot force-pushed the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch from 2bad9cb to 1612932 Compare February 12, 2026 13:06

graphite-app bot merged commit 1612932 into main Feb 12, 2026
21 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026

graphite-app bot deleted the c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule branch February 12, 2026 13:13

Boshen mentioned this pull request Feb 16, 2026

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

OskarLebuda pushed a commit to OskarLebuda/oxc that referenced this pull request Feb 17, 2026

feat(linter): add typescript/no-unnecessary-condition (oxc-project#19130

4a5ffca

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): add typescript/no-unnecessary-condition#19130

feat(linter): add typescript/no-unnecessary-condition#19130
graphite-app[bot] merged 1 commit intomainfrom
c/02-08-feat_linter_typescript_no-unneccessary-condition_add_rule

camc314 commented Feb 8, 2026

Uh oh!

camc314 commented Feb 8, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 12, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

camc314 commented Feb 8, 2026

Uh oh!

camc314 commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 12, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

camc314 commented Feb 8, 2026 •

edited

Loading

codspeed-hq bot commented Feb 8, 2026 •

edited

Loading

camc314 commented Feb 12, 2026 •

edited by graphite-app bot

Loading