refactor(oxlint/lsp): introduce FixedContentKind enum#19113
Merged
graphite-app[bot] merged 1 commit intoFeb 9, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
the
C-cleanup
Sysix
force-pushed
the
02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport
branch
from
February 7, 2026 18:05
fc0f04f to
fb2aaeb
Compare
Sysix
force-pushed
the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
from
February 7, 2026 18:05
479e8f4 to
8e4fa49
Compare
Sysix
force-pushed
the
02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport
branch
from
February 7, 2026 18:25
fb2aaeb to
595ad64
Compare
Sysix
force-pushed
the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
from
February 7, 2026 18:25
8e4fa49 to
38ef22f
Compare
Sysix
force-pushed
the
02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport
branch
from
February 7, 2026 19:52
595ad64 to
85e4608
Compare
Sysix
force-pushed
the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
from
February 7, 2026 19:52
38ef22f to
37e4e2e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the oxlint LSP “fixed content” representation by introducing a FixedContentKind enum and threading it through fix creation so each fix can be tagged with an LSP-specific kind.
Changes:
- Added a new
FixedContentKindenum and stored it onFixedContentaslsp_kind. - Updated
fix_to_fixed_contentto accept and propagate the new kind. - Tagged different fix sources (
LintRule, ignore-line/section, unused-directive) when building code actions.
Sysix
marked this pull request as ready for review
February 7, 2026 20:09
graphite-app
Bot
changed the base branch from
02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport
to
graphite-base/19113
February 9, 2026 10:36
graphite-app
Bot
force-pushed
the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
from
February 9, 2026 10:44
37e4e2e to
407d5bd
Compare
graphite-app
Bot
force-pushed
the
graphite-base/19113
branch
from
February 9, 2026 10:44
85e4608 to
18f58bd
Compare
graphite-app
Bot
force-pushed
the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
from
February 9, 2026 10:45
407d5bd to
f895cf9
Compare
camc314
approved these changes
Feb 9, 2026
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
from
February 9, 2026 12:52
f895cf9 to
d6aba50
Compare
graphite-app
Bot
deleted the
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
branch
February 9, 2026 12:59
graphite-app Bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
ESLint shows by default suggestions in the editor. We did not have the right architecture to difference between safe or dangerous fix / suggestions. With #19113 we know now what kind of fix this is. This allows us now to align more with the ESLint editor experience. The last found tech dep was #19795. This will not apply for editors which manage its own configurations like VS Code editor and IntelliJ Plugin (cc @nrayburn-tech). These editors need their own default value changed. When using auto save `source.fixAll.oxc` or `source.fixAll` code action, or the `oxc.fixAll` command, the suggestions will be applied too. Because this is always in a context of one file only, I guess this is safe. Or we can change the line for this: https://github.com/oxc-project/oxc/blob/a45b9f4f808e4761ee615c31ea32bccfad322602/apps/oxlint/src/lsp/code_actions.rs#L96-L100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.