test(linter/plugins): test fixes in files with unicode#19057
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Feb 6, 2026
Member
Author
This was referenced Feb 6, 2026
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for UTF-16 to UTF-8 conversion of fix offsets in the oxlint linter plugin system. It introduces test fixtures containing Unicode emoji characters and Byte Order Marks (BOM) to ensure that code fixes are applied at the correct positions when multi-byte characters are present.
Changes:
- Added two new test fixture files (
unicode.jsandbom_and_unicode.js) to both thefixesandsuggestionstest directories - Updated snapshot files to reflect the expected output when linting and fixing files with Unicode characters
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/test/fixtures/suggestions/files/unicode.js | New test fixture with Unicode emoji characters to test fix offset conversion |
| apps/oxlint/test/fixtures/suggestions/files/bom_and_unicode.js | New test fixture with BOM and Unicode emojis to test combined offset handling |
| apps/oxlint/test/fixtures/fixes/files/unicode.js | New test fixture for fixes plugin with Unicode emoji characters |
| apps/oxlint/test/fixtures/fixes/files/bom_and_unicode.js | New test fixture for fixes plugin with BOM and Unicode emojis |
| apps/oxlint/test/fixtures/suggestions/output.snap.md | Updated snapshot with expected linting output for new Unicode test files (25 errors across 4 files) |
| apps/oxlint/test/fixtures/suggestions/fix.snap.md | Updated snapshot with expected fix output for new Unicode test files |
| apps/oxlint/test/fixtures/suggestions/fix-suggestions.snap.md | Updated snapshot showing files are correctly fixed with Unicode preservation |
| apps/oxlint/test/fixtures/fixes/output.snap.md | Updated snapshot with expected linting output for new Unicode test files (24 errors across 4 files) |
| apps/oxlint/test/fixtures/fixes/fix.snap.md | Updated snapshot showing fixes are correctly applied with BOM and emoji preservation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
om/02-06-fix_linter_plugins_fix_fixes_in_files_with_bom
branch
from
18aa98a to
4823b58
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Add tests for applying fixes and suggestions in files containing non-ASCII characters, to ensure the UTF-16 -> UTF-8 conversion of fix offsets is working correctly.
graphite-app
bot
force-pushed
the
om/02-06-test_linter_plugins_test_fixes_in_files_with_unicode
branch
from
e5778cb to
d44ed04
Compare
Base automatically changed from
om/02-06-fix_linter_plugins_fix_fixes_in_files_with_bom
to
main
February 6, 2026 13:07
Add tests for applying fixes and suggestions in files containing non-ASCII characters, to ensure the UTF-16 -> UTF-8 conversion of fix offsets is working correctly.
graphite-app
bot
force-pushed
the
om/02-06-test_linter_plugins_test_fixes_in_files_with_unicode
branch
from
d44ed04 to
6e54567
Compare
graphite-app
bot
deleted the
om/02-06-test_linter_plugins_test_fixes_in_files_with_unicode
branch
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
…9057) Add tests for applying fixes and suggestions in files containing non-ASCII characters, to ensure the UTF-16 -> UTF-8 conversion of fix offsets is working correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for applying fixes and suggestions in files containing non-ASCII characters, to ensure the UTF-16 -> UTF-8 conversion of fix offsets is working correctly.