test(linter/plugins): reduce nesting in test plugin code#19053
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
Member
Author
This was referenced Feb 6, 2026
github-actions
bot
added
A-linter
github-actions
bot
added
the
C-test
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the fixes test fixture plugin to reduce nesting by extracting the rule definition into a standalone rule variable, preparing the fixture for future expansion while keeping behavior unchanged.
Changes:
- Import
Ruleand extract thefixesrule intoconst rule: Rule = { ... }. - Recompose
plugin: Pluginusingrules: { fixes: rule }with the same plugin metadata.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 6, 2026
Contributor
Merge activity
|
Pure refactor of tests. Reduce nesting of code by splitting into vars for the `Rule` and the `Plugin`. This is preparation for adding to this test fixture in later PRs.
graphite-app
bot
force-pushed
the
om/02-06-refactor_linter_move_logic_for_combining_jsfix_es_into_separate_function
branch
from
46334f3 to
b1ac16a
Compare
graphite-app
bot
force-pushed
the
om/02-05-test_linter_plugins_reduce_nesting_in_test_plugin_code
branch
from
3cde087 to
a8ae9a9
Compare
Base automatically changed from
om/02-06-refactor_linter_move_logic_for_combining_jsfix_es_into_separate_function
to
main
February 6, 2026 13:02
graphite-app
bot
deleted the
om/02-05-test_linter_plugins_reduce_nesting_in_test_plugin_code
branch
OskarLebuda
pushed a commit
to OskarLebuda/oxc
that referenced
this pull request
Feb 17, 2026
…#19053) Pure refactor of tests. Reduce nesting of code by splitting into vars for the `Rule` and the `Plugin`. This is preparation for adding to this test fixture in later PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor of tests. Reduce nesting of code by splitting into vars for the
Ruleand thePlugin. This is preparation for adding to this test fixture in later PRs.