Skip to content

feat(tasks/benchmark): add mangler keep_names case#19026

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-feat_tasks_benchmark_add_mangler_keep_names_case
Feb 6, 2026
Merged

feat(tasks/benchmark): add mangler keep_names case#19026
graphite-app[bot] merged 1 commit intomainfrom
02-06-feat_tasks_benchmark_add_mangler_keep_names_case

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 6, 2026 •
edited
Loading

Added mangler case with keep_names enabled to the benchmark.

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Feb 6, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Feb 6, 2026
This was referenced Feb 6, 2026
Merged
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 02-06-feat_tasks_benchmark_add_mangler_keep_names_case (8c37339) with main (463d60d)

Summary

✅ 46 untouched benchmarks
🆕 1 new benchmark
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation mangler[RadixUIAdoptionSection.jsx_keep_names] N/A 14.8 µs N/A

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sapphi-red sapphi-red marked this pull request as ready for review February 6, 2026 06:24
Copilot AI review requested due to automatic review settings February 6, 2026 06:24
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a benchmark case to test the mangler with keep_names enabled, which preserves function and class names during mangling. This allows measuring the performance impact of the keep_names feature compared to the default mangler behavior.

Changes:

  • Import MangleOptions and MangleOptionsKeepNames from oxc_mangler
  • Add a new benchmark block that tests mangling with keep_names set to preserve all names (functions and classes)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red requested a review from Boshen February 6, 2026 06:34
This was referenced Feb 6, 2026
Merged
Merged
@sapphi-red sapphi-red force-pushed the 02-06-feat_tasks_benchmark_add_mangler_keep_names_case branch from d0e96a4 to 8c37339 Compare February 6, 2026 06:45
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 6, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 6, 2026 •
edited
Loading

Merge activity

@sapphi-red
feat(tasks/benchmark): add mangler keep_names case (#19026)
d4ad45b 
Added mangler case with keep_names enabled to the benchmark.
@graphite-app graphite-app bot force-pushed the 02-06-feat_tasks_benchmark_add_mangler_keep_names_case branch from 8c37339 to d4ad45b Compare February 6, 2026 07:28
@graphite-app graphite-app bot merged commit d4ad45b into main Feb 6, 2026
21 checks passed
@graphite-app graphite-app bot deleted the 02-06-feat_tasks_benchmark_add_mangler_keep_names_case branch February 6, 2026 07:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen

Comments